[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-12 Thread Kai Uwe Broulik
broulik added a comment. `QCoreApplication::desktopFileName()` is the full desktop file name without the path, ie. as far as I can tell with the `.desktop` suffix, the Gnome spec explicitly says it should be sent without it, though. REPOSITORY R289 KNotifications REVISION DETAIL https:/

[Differential] [Request, 8 lines] D4587: [ContainmentInterface] Ungrab mouse on context menu close

2017-02-12 Thread Anthony Fieroni
anthonyfieroni created this revision. anthonyfieroni added a reviewer: Plasma. anthonyfieroni added subscribers: mart, davidedmundson. anthonyfieroni set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Appli

[Differential] [Commented On] D4587: [ContainmentInterface] Ungrab mouse on context menu close

2017-02-12 Thread Martin Gräßlin
graesslin added a comment. > Looks like Qt 5.8 has a grabber bug Then Qt should fix and not we workaround it. Also: how do you know whether your change will still work in Qt 5.7? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4587 EMAIL

[Differential] [Commented On] D4587: [ContainmentInterface] Ungrab mouse on context menu close

2017-02-12 Thread Anthony Fieroni
anthonyfieroni added a comment. > Also: how do you know whether your change will still work in Qt 5.7? I noticed same downside there, if someone still has Qt 5.7 can test it. Tested Qt 5.6 on Kubuntu backport -> works. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https

[Differential] [Request, 7 lines] D4590: [PanelView] Don't emit availableScreenRegionChanged just because we set a new length

2017-02-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The panel length might not actually ch

[Differential] [Request, 11 lines] D4591: [Widget Explorer] Remove pointless QSignalMapper

2017-02-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We no longer have the ability to insta

[Differential] [Commented On] D4590: [PanelView] Don't emit availableScreenRegionChanged just because we set a new length

2017-02-12 Thread David Edmundson
davidedmundson added a comment. Old code is wrong, new code is also wrong. length is the implicitWidth/height of the contents, it is /not/ the size of the panel. The only place for this signal is the geometryChanged event. REPOSITORY R120 Plasma Workspace REVISION DETAIL https:

[Differential] [Accepted] D4591: [Widget Explorer] Remove pointless QSignalMapper

2017-02-12 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. btw, if you have this code open to set the transient parent on the WE wialogs, I started that and it's not trivial. REPOSITO

[Differential] [Updated] D4557: Fix gtk-primary-button-warps-slider with GTK 2

2017-02-12 Thread Aleix Pol Gonzalez
apol added a comment. Looks to me like it needs both alternatives? Something like `bool isTrue(const QString &f) { return f=="1" || f=="true"; }` REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D4557 EMAIL PREFERENCES https://phabricator.kde.org/s

[Differential] [Updated] D4571: Fix adding files to data project

2017-02-12 Thread Leslie Zhai
lesliezhai added a comment. Hi Kai Uwe, Thanks a lot for the fix! And I will try to fix clang analyzer's false positive ;-) Regards, Leslie Zhai REPOSITORY R467 K3b REVISION DETAIL https://phabricator.kde.org/D4571 EMAIL PREFERENCES https://phabricator.kde.org/settings

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 749 - Still Unstable!

2017-02-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/749/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 04:54:19 + Build duration: 6 min 24 sec CHANGE SET Revision 126fc2f9e350204fd538b7852608

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 618 - Still Unstable!

2017-02-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/618/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 04:53:19 + Build duration: 20 min CHANGE SET Revision 43d884a8eab484866c91f416d2397816d4aa

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 64 - Still Unstable!

2017-02-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 06:37:02 + Build duration: 14 min CHANGE SET Revision 5412cea917527a93a31ba13c