Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 11:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > But Marco already implemented that

Re: Review Request 129835: [IconDialog] Set proper icons group

> On Jan. 21, 2017, 7:24 a.m., Anthony Fieroni wrote: > > All IconDialogs from QML are with small and hard to visible icons e.g. > > Kicker (right click -> change icon -> small icons) > > Anthony Fieroni wrote: > Ping Marco, did you think this approach is not correct? - Anthony ---

[Differential] [Changed Subscribers] D4301: [System Tray] SNI fallback to context menu on failing Activate

broulik added inline comments. INLINE COMMENTS > statusnotifieritemsource.cpp:472 > if (m_statusNotifierItemInterface && > m_statusNotifierItemInterface->isValid()) { > -m_statusNotifierItemInterface->call(QDBus::NoBlock, > QStringLiteral("Activate"), x, y); > +m_statusNoti

[Differential] [Commented On] D4301: [System Tray] SNI fallback to context menu on failing Activate

davidedmundson added inline comments. INLINE COMMENTS > statusnotifieritemsource.cpp:472 > if (m_statusNotifierItemInterface && > m_statusNotifierItemInterface->isValid()) { > -m_statusNotifierItemInterface->call(QDBus::NoBlock, > QStringLiteral("Activate"), x, y); > +m_sta

[Differential] [Updated] D4301: [System Tray] SNI fallback to context menu on failing Activate

subdiff marked an inline comment as done. subdiff added inline comments. INLINE COMMENTS > broulik wrote in statusnotifieritemsource.cpp:472 > This spins its own event loop which is dangerous when dealing with QML > This spins its own event loop which is dangerous when dealing with QML Since th

[Differential] [Commented On] D4301: [System Tray] SNI fallback to context menu on failing Activate

davidedmundson added inline comments. INLINE COMMENTS > subdiff wrote in statusnotifieritemsource.cpp:472 > > This spins its own event loop which is dangerous when dealing with QML > > Since the event loop is part of the service, isn't the QML shielded from it > anyway? The QML code connects on

[Differential] [Accepted] D4304: Split Keyboard Repeat handling into a dedicated InputEventSpy

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH keyboard-repeat REVISION DETAIL https://phabricator.kde.org/D4304 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: gr

[Differential] [Accepted] D4215: Make notifications execute the "default" action on click.

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. so (didn't really want to be the one to put a ship it on this but whatever) let's go with this in master, so is still as early as possible in 5.10 cycle, and let's

[Differential] [Requested Changes To] D4290: [Calculator Runner] Use "approximate" approximation mode

mart requested changes to this revision. mart added a reviewer: mart. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > qalculate_engine.cpp:103 > +// to avoid memory overflow for seemingly innocent calculations (Bug > 277011) > +eo.approximatio

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 9:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > But Marco already implemented that,

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 11:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > But Marco already implemented that

[Differential] [Closed] D4302: Clip by bounding delegate size instead of Item.clip.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3b5d1fcb42b6: Clip by bounding delegate size instead of Item.clip. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4302?vs=10607&id=10612

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 576 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/576/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 27 Jan 2017 12:22:36 + Build duration: 6 min 26 sec CHANGE SET Revision 3b5d1fcb42b6a0a365f92bfc142b97

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

albertvaka added a comment. I still have to make the change to not close the notification if there is no action. As soon as I change it I will push it. I agree it's good to have this early in master, so we can have feedback and see if we need any tweak before the next release. REPOSITORY

[Differential] [Request, 1 line] D4307: [RFC] Introduce an adoption command in the wallpaper knsrc file

apol created this revision. apol added reviewers: Frameworks, mart, whiting, leinir. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Using the same semantics as the InstallationCommand, makes it possible for the client t

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 705 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/705/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 27 Jan 2017 13:28:46 + Build duration: 19 min CHANGE SET Revision 2212c42417398d4e6237e578c43206e94d

[Differential] [Request, 27 lines] D4309: fix isOutputRedundant logic

mart created this revision. mart added reviewers: Plasma, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY isOutputRedundant badly failed when two screens had the exact same geometry (that should be, the base cas

[Differential] [Updated, 27 lines] D4309: fix isOutputRedundant logic

mart updated this revision to Diff 10617. mart added a comment. - fix comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4309?vs=10616&id=10617 BRANCH phab/redundant REVISION DETAIL https://phabricator.kde.org/D4309 AFFECTED FILES shel

[Differential] [Commented On] D4309: fix isOutputRedundant logic

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:1127 > there's a bug here, but I'm not sure what the right fix is. > > If you have two screens A, B > > both are new (so have ID == -1) > > A is wider than B but B is taller than A > > you return true for bo

[Differential] [Updated] D4307: [RFC] Introduce an adoption command in the wallpaper knsrc file

mart added a comment. this could be a nice idea. if this goes in, the stock knewstuff install dialog should use it as well REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4307 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Changed Subscribers] D4309: fix isOutputRedundant logic

davidedmundson added inline comments. INLINE COMMENTS > shellcorona.cpp:1127 > + //measure of othergeometry is bigger, has a bigger area > + otherGeometry.width() > thisGeometry.width() || > + otherGeometry.height() > thisGeometry.height() || there's a bug her

[Differential] [Commented On] D4307: [RFC] Introduce an adoption command in the wallpaper knsrc file

apol added a comment. In https://phabricator.kde.org/D4307#80774, @mart wrote: > if this goes in, the stock knewstuff install dialog should use it as well I'm not sure. In this specific case, if you're in the KNS Dialog means that you already have the Wallpapers kcm open already,

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102285 --- I'm sorry, but this looks rather badly rebased. You deleted

[Differential] [Closed] D4304: Split Keyboard Repeat handling into a dedicated InputEventSpy

This revision was automatically updated to reflect the committed changes. Closed by commit R108:eb92477210a7: Split Keyboard Repeat handling into a dedicated InputEventSpy (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4304?vs=10609&id=10

[Differential] [Closed] D4299: Disable standard actions on VirtualKeyboard SNI

This revision was automatically updated to reflect the committed changes. Closed by commit R108:b636feb8eb57: Disable standard actions on VirtualKeyboard SNI (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4299?vs=10601&id=10626 REVISION

[Differential] [Updated, 35 lines] D4309: fix isOutputRedundant logic

mart updated this revision to Diff 10629. mart added a comment. - reconsider outputs when the primary changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4309?vs=10617&id=10629 BRANCH phab/redundant REVISION DETAIL https://phabricator.kde.

[Differential] [Accepted] D4309: fix isOutputRedundant logic

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. Maybe 5.8 material too. REPOSITORY R120 Plasma Workspace BRANCH phab/redundant REVISION DETAIL https://phabricator.kd

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 27, 2017, 4:55 p.m., Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.h, line 152 > > > > > > why move this line? I will fix it this mistake. > On Jan. 27, 2017, 4:55 p.m., Martin Gräßlin wrote: > > kc

[Differential] [Commented On] D4309: fix isOutputRedundant logic

mart added a comment. In https://phabricator.kde.org/D4309#80804, @davidedmundson wrote: > Maybe 5.8 material too. definitely, as is a serious multiscreen bug REPOSITORY R120 Plasma Workspace BRANCH phab/redundant REVISION DETAIL https://phabricator.kde.org/D4309 EMAIL PR

[Differential] [Closed] D4309: fix isOutputRedundant logic

This revision was automatically updated to reflect the committed changes. Closed by commit R120:996f5b199f40: fix isOutputRedundant logic (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4309?vs=10629&id=10630 REVISION DETAIL http

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 33 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 27 Jan 2017 15:45:33 + Build duration: 6 min 40 sec CHANGE SET Revision f4faa6f1547c499489

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 706 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/706/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 27 Jan 2017 15:44:02 + Build duration: 14 min CHANGE SET Revision 996f5b199f40ade64b4d833f5ece5300c5

[Differential] [Request, 135 lines] D4315: Provide kxbk config through kwinApp

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY So far KWin parsed the kxbkrc at multiple places (once in Xkb, once

[Differential] [Commented On] D4307: [RFC] Introduce an adoption command in the wallpaper knsrc file

mart added a comment. In https://phabricator.kde.org/D4307#80790, @apol wrote: > In https://phabricator.kde.org/D4307#80774, @mart wrote: > > > if this goes in, the stock knewstuff install dialog should use it as well > > > I'm not sure. In this specific case, if you're in the KN

[Differential] [Request, 106 lines] D4317: Make it possible to change icon themes from elsewhere in kns

apol created this revision. apol added reviewers: Frameworks, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Splits the logic into a separate binary, also cleans some unneeded code in the KCM. Introduces the exp

[Differential] [Updated] D4317: Make it possible to change icon themes from elsewhere in kns

apol edited reviewers, added: Plasma; removed: Frameworks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4317 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jen

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 31 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 27 Jan 2017 19:26:08 + Build duration: 15 min CHANGE SET Revision 733ac20c8df1afdb9784b04633

[Differential] [Updated, 27 lines] D4301: [System Tray] SNI fallback to context menu on failing Activate

subdiff updated this revision to Diff 10649. subdiff added a comment. One more try with guarding against dangling pointers. Just trying out stuff here. So in case this is utter bullshit please tell me if and why it doesn't work. My thinking was the following: - Guard code execution

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 707 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/707/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 28 Jan 2017 05:38:14 + Build duration: 5 min 34 sec CHANGE SET Revision e52728089a2bda9eb23673d19a9d

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 577 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/577/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 28 Jan 2017 05:37:56 + Build duration: 18 min CHANGE SET Revision fc7211ec3192ee29d651ab17fbc859269721

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 28, 2017, 9:35 преди обяд) Review request for Plasma, Kai Uw

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 32 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 28 Jan 2017 07:16:36 + Build duration: 5 min 46 sec CHANGE SET Revision d5ea4a65b17764905307

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 34 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 28 Jan 2017 07:16:51 + Build duration: 19 min CHANGE SET Revision 109a4087ad6d2284082d69b3