mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D4208
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ervin, mart
Cc: plasma-devel, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6bcf5405a217: Deal with missing drawers (authored by
ervin).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4208?vs=10366&id=10483
REVISION DETAIL
https://phabr
https://bugs.kde.org/show_bug.cgi?id=375333
Kai Uwe Broulik changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Latest Commit|
https://bugs.kde.org/show_bug.cgi?id=375333
--- Comment #7 from Mahendra Tallur ---
What a quick fix ! Thank you, you made my day :-)
--
You are receiving this mail because:
You are the assignee for the bug.
broulik added a comment.
So, should we go with this now?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4157
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, a
https://bugs.kde.org/show_bug.cgi?id=375333
--- Comment #8 from Kai Uwe Broulik ---
Thanks for your investigation, was the right spot in the code you found :)
--
You are receiving this mail because:
You are the assignee for the bug.
apol updated this revision to Diff 10489.
apol added a comment.
Removed hover state as requested by David and Marco
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4214?vs=10379&id=10489
BRANCH
master
REVISION DETAIL
https://phabrica
https://bugs.kde.org/show_bug.cgi?id=375333
--- Comment #9 from Mahendra Tallur ---
I just bothered the right persons ;) Rog came up with the location of the
issue.
--
You are receiving this mail because:
You are the assignee for the bug.
sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D4105
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/email
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/702/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 24 Jan 2017 11:54:58 +
Build duration: 5 min 54 sec
CHANGE SET
Revision 4065c6958b112e7da1f33c55a205
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/567/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 24 Jan 2017 11:54:18 +
Build duration: 23 min
CHANGE SET
Revision 4f1bfd58696bc8d9fda243e2dc54947db2e9
davidedmundson added a comment.
+1
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4214
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks, lesliez
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:2b87302d9d01: Fix compare for undefined argument in
playFeedback() (authored by drosca).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4104?vs=10102&id=10493#toc
REPOSITORY
R115 Plasma Audi
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:27c8c9aa84b4: Pass correct index to playFeedback
(authored by drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4105?vs=10104&id=10492
REV
drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 375495
FIXED-IN: 5.9.0
TEST PLAN
Mute is no longer changed on first open of popup, feedback is also
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4214
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefere
drosca updated this revision to Diff 10495.
drosca added a comment.
Make sure not to play feedback for volume changes that comes outside widget
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4140?vs=10175&id=10495
BRANCH
feedback-rewor
drosca updated the summary for this revision.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D4140
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: drosca, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed,
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 24 Jan 2017 13:29:12 +
Build duration: 22 min
CHANGE SET
Revision 1cddd0f28845057e6b6713bb97
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 24 Jan 2017 13:29:42 +
Build duration: 21 min
CHANGE SET
Revision ad66dc81817ea7b7d4bf98dd
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:54e87fe879ba: Make sure we display enabled ListItem on
hover (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4214?vs=10489&id=
mck182 added a comment.
Thanks, that's a nice list. I think real examples using actual native apps
would provide better insight (like calendar, low battery or music player
notification), but that'd be like a weekend project, so it's ok.
**macOS**: Clicking a notification popup will in mo
colomar added a comment.
+1 from me, with clicking on a notification that does not define a default
action doing nothing
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4215
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
T
broulik added a comment.
OK, let's go with this then, ie. do nothing if no default action is set.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4215
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: albertvaka, #plasma,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/
---
(Updated Ян. 24, 2017, 9:40 след обяд)
Review request for Plasma, Kai Uwe
I have the following situation and I would like you to clarify it in
order to open a bug in the distro that should fix this...
KDE_INSTALL_LOCALEDIR for CMAKE
in openSUSE
points to /usr/share/locale but the translations are in
/usr/share/locale/kf5
and in Arch
points to /usr/share/locale
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/
---
(Updated Ян. 24, 2017, 10 след обяд)
Review request for Plasma, Kai Uwe B
davidedmundson added inline comments.
INLINE COMMENTS
> modifier_only_shortcut_test.cpp:281
> // currently caps lock is on
> -// shift is ignored
> +// shift still triggers
> kwinApp()->platform()->keyboardKeyPressed(modifier, timestamp++);
I don't get this change:
This is the
davidedmundson added a comment.
One comment, but otherwise ship it.
That contextMenu thing will come back to haunt us in the future, but
hopefully SNI will be fixed by then.
INLINE COMMENTS
> keyboard_layout.cpp:142
> m_layout = m_xkb->currentLayout();
> +initNotifierItem();
>
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
BRANCH
osm-skip-close-animation
REVISION DETAIL
https://phabricator.kde.org/D4091
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefe
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
touch-input-deco-workaround
REVISION DETAIL
https://phabricator.kde.org/D4074
EMAIL PREFERENCES
https://phabricator.kde.or
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
effects-singleton-arg
REVISION DETAIL
https://phabricator.kde.org/D3571
EMAIL PREFERENCES
https://phabricator.kde.org/sett
davidedmundson added inline comments.
INLINE COMMENTS
> ListItemBase.qml:176
>
> onValueChanged: {
> if (!ignoreValueChange) {
can you not just add
if (Component.status != Ready) to the top of this method
and get rid of the bool?
REPOSIT
drosca added inline comments.
INLINE COMMENTS
> davidedmundson wrote in ListItemBase.qml:176
> can you not just add
>
> if (Component.status != Ready) to the top of this method
>
> and get rid of the bool?
No, because `Component.status` is not attached property and so is not
accessible from t
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4269
EMAIL PREFERENCES
https://phabricator.k
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 06:34:02 +
Build duration: 17 min
CHANGE SET
Revision d4a25ca56d46cfd962b52e96ed
dfaure added inline comments.
INLINE COMMENTS
> iconapplet.cpp:108
> +if (desiredDesktopFileName.isEmpty()) {
> +desiredDesktopFileName =
> QString::fromLatin1(QCryptographicHash::hash(m_url.toDisplayString().toUtf8(),
> QCryptographicHash::Md5).toHex());
> +}
Not c
37 matches
Mail list logo
