[Differential] [Updated] D4202: use proper packagestructures

subdiff added a reviewer: subdiff. REPOSITORY R108 KWin BRANCH phab/packageplugins REVISION DETAIL https://phabricator.kde.org/D4202 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, graesslin, subdiff Cc: graesslin, plasma-devel, kwin, #

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

luebking added a comment. "On Wayland that kded has no real access to the layouts and cannot properly implement switching. Given that it's better to integrate the SNI directly in KWin." I'll raise a fundamental question: is wayland prone to end up being PID 0: systemd PID 1: kwin

[kio-extras] [Bug 375333] New: Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 Bug ID: 375333 Summary: Folders thumbnails : custom folder icon overridden by default folder icon Product: kio-extras Version: 5.8.5 Platform: Neon Packages OS: Li

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #1 from Mahendra Tallur --- I'm pasting Rog's comment on my preview bugreport which I'm about to close : By my knowledge the kio-extras. Folder thumbnailing is using the icon theme directory icon. ie: https://cgit.kde.org/kio-extras.git/

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #2 from Mahendra Tallur --- *** Bug 370247 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

konstantinshtepa added a comment. WARNING: Found a bug with plasmoid don't free all his space in LayoutManager when changed from compactRepresentation to fullRepresentation. Don't push this patch before I fix this bug. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.k

[Differential] [Changed Subscribers] D4220: Add a basic SNI for keyboard layout

davidedmundson added inline comments. INLINE COMMENTS > keyboard_layout.cpp:165 > +[this] { > +// TODO: introduce helper function to start kcmshell5 > +QProcess *p = new Process(this); so KToolInvocation::startServiceByName()? > keyboard_layout.cpp:182 > + > +

[Differential] [Request, 212 lines] D4223: Remove local copy of dialog.h

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY From before PlasmaQuick existed TEST PLAN Compiles REPOSITORY R119 Plasma Desktop BRANCH

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 Christoph Feck changed: What|Removed |Added CC||lui...@lftabera.es --- Comment #3 from Christo

[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in ListItem.qml:97 > > in fact it's what it was supposed to happen in the first place > > We have the highlight for the item under mouse. > Why should the delegate change too? If that's the case, then we should remove the opaci

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in keyboard_layout.cpp:165 > so KToolInvocation::startServiceByName()? yes, except that we used to use KToolInvocation and ported away from it. Something - in the case of KWin - doesn't work for it. The standard case of KW

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added a comment. > I'll raise a fundamental question: is wayland prone to end up being Yes, we are renaming kwin to kwind :-) > it may need an interface in such occasions, signalling the change, exposing the layout and allow clients to alter the layout. Yes, that's b

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added inline comments. INLINE COMMENTS > graesslin wrote in keyboard_layout.cpp:182 > uh nice, didn't know that and followed the existing code too blindly. This doesn't work :-( I added the actions, but the menu doesn't get shown at all. REPOSITORY R108 KWin REVISION DETAIL http

[Differential] [Closed] D4202: use proper packagestructures

This revision was automatically updated to reflect the committed changes. Closed by commit R108:405518c41da9: use proper packagestructures (authored by mart). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4202?vs=10357&id=10387 REVISION DETAIL https://phabric

[Differential] [Updated] D4202: use proper packagestructures

subdiff added a comment. Just for keeping record: The only issue I noticed is that the config button in scripts isn't displayed. Besides works very nice! REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4202 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

luebking added a comment. In https://phabricator.kde.org/D4220#78878, @graesslin wrote: > > This change is about the opposite: supporting *changing* the layout. Not about notifying the layout change, that is something we already support for at least a year. Yes. Afai

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added a comment. In https://phabricator.kde.org/D4220#78887, @luebking wrote: > In https://phabricator.kde.org/D4220#78878, @graesslin wrote: > > > > > > > > > This change is about the opposite: supporting *changing* the layout. Not about notifying the layout chang

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 Elvis Angelaccio changed: What|Removed |Added Ever confirmed|0 |1 CC|

[Differential] [Request, 29 lines] D4224: [Color Picker] Add border around color if contrast to surrounding view is too little

broulik created this revision. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When picking a light color on a light panel, it might not be obvious that t

[Differential] [Commented On] D4224: [Color Picker] Add border around color if contrast to surrounding view is too little

broulik added a comment. Just noticed I could have probably used QColor::getHsl REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D4224 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik Cc: plasma-devel, lesliezha

[Differential] [Updated, 151 lines] D4220: Add a basic SNI for keyboard layout

graesslin updated this revision to Diff 10391. graesslin added a comment. Scroll support REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4220?vs=10382&id=10391 BRANCH keyboard-layout-sni REVISION DETAIL https://phabricator.kde.org/D4220 AFFECTED FILES

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #5 from Ka

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. -1, I don't want to keep thinking "am I now going to close the notification or execute an action" everytime I'm about to click the notification popup. I want my workspace to have predictable behavior that doesn't get in my way. REPOSITORY R120 Plasma Workspace

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

apol added a comment. In https://phabricator.kde.org/D4215#78913, @mck182 wrote: > -1, I don't want to keep thinking "am I now going to close the notification or execute an action" everytime I'm about to click the notification popup. > > I want my workspace to have predictable behavio

[Differential] [Updated] D4215: Make notifications execute the "default" action on click.

apol added a reviewer: colomar. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4215 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #plasma, colomar Cc: apol, mck182, plasma-devel, lesliezhai, ali-mohamed, jensr

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. > If you just want to close then you have the big X, no? That doesn't change the fact that the behavior of clicking the popup itself would change in an unpredictable way. One time it's close and other times it's execute and there's no visual way of telling when it

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

apol added a comment. > That doesn't change the fact that the behavior of clicking the popup itself would change in an unpredictable way. One time it's close and other times it's execute and there's no visual way of telling when it will do what. That's the actual problem. I have never c

[Differential] [Updated] D4215: Make notifications execute the "default" action on click.

colomar added a comment. In https://phabricator.kde.org/D4215#78928, @mck182 wrote: > > If you just want to close then you have the big X, no? > > That doesn't change the fact that the behavior of clicking the popup itself would change in an unpredictable way. One time it's close and

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

albertvaka added a comment. It looks like the explanation on the commit message lead to confusion about the "two different behaviours" thing. Let me explain it a bit more. First of all, note that notifications always close when you click them, in both cases. The notification disappears b

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. > I have never considered unpredictable on Android that when I press the "new e-mail" notification I get the e-mail client with the new e-mail. On Android, you close the notification by swiping to a side. On Plasma, you close the notification by clicking it. On An

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

broulik added a comment. I absolutely *hate* that clicking a notification closes it. I always do that by accident and for closing I *always* use the X button. I agree that having some sort of visual indication of what clicking the popup will do would be beneficial. But then if we remove

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

apol added a comment. > However, since we're conditioned by the way Plasma worked for years to always have a visible action button might be hard to change, especially since it involves a slew of third party apps we can't control and/or will take forever to adapt. That's not entirely tru

[Differential] [Updated, 197 lines] D4220: Add a basic SNI for keyboard layout

graesslin updated this revision to Diff 10395. graesslin added a comment. Support config option for show/hiding the sni REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4220?vs=10391&id=10395 BRANCH keyboard-layout-sni REVISION DETAIL https://phabricator.k

[Differential] [Request, 168 lines] D4229: Overhaul group popup dialog

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY A set of UI improvements to the group popup dialog: - The dialog was height-limited but not scrollable. It now shows a vertical

[Differential] [Commented On] D4229: Overhaul group popup dialog

hein added a comment. F2091685: Screenshot_20170121_055203.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4229 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma Cc:

[Differential] [Commented On] D4229: Overhaul group popup dialog

hein added a comment. Note: I think I need to make collecting the active task more robust still. Feel free to review, but I will probably update after the weekend. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4229 EMAIL PREFERENCES https://phabricator.kd

Re: Review Request 129013: Fix handling of paths with whitespace in bash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129013/ --- (Updated Jan. 20, 2017, 10:44 p.m.) Status -- This change has been m

Re: Review Request 129255: Fixed unrar version check.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129255/ --- (Updated Jan. 20, 2017, 11:13 p.m.) Status -- This change has been m

Re: Review Request 127223: Don't emit destroyedChanged(true) twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127223/#review102121 --- Doesn't apply anymore. - Albert Astals Cid On Feb. 29, 20

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126418/#review102134 --- Unfortunately noone commited this patch and doesn't apply an

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

apol added a comment. In https://phabricator.kde.org/D4090#76737, @mart wrote: > so, let's keep 5.9 as is, and get sizing tought better for 5.10 So should I push to master? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES h

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

albertvaka added a comment. I think Plasma is the only notification system that does close-on-activate instead of executing some action. Until now it wasn't even possible to add a default action, but now that it is possible I think we all agree this is something good that apps should adopt.

Re: Review Request 129835: [IconDialog] Set proper icons group

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129835/#review102153 --- All IconDialogs from QML are with small and hard to visible

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 696 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/696/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 21 Jan 2017 05:46:17 + Build duration: 22 min CHANGE SET Revision 91b4115bc7aed1c8bb94ef8c8f76401dd1

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. > I think Plasma is the only notification system that does close-on-activate instead of executing some action Plasma might also be the only system that uses buttons for actions and I see nothing wrong with that; it's what we've had forever and it works well, there