mart added inline comments.
INLINE COMMENTS
> ToolTipInstance.qml:92
> Column {
> -spacing: 0.75 * units.smallSpacing
> -PlasmaComponents.Label {
> +PlasmaExtras.Heading {
> width: isWin ? textWidth : undefined
try to restore this spa
mart added a comment.
I also think that's a bit too verbose
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4178
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, mart
Cc: broulik, plasma-devel, lesliezhai, ali-moham
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D4181
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #plasma, mart
Cc
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
LGTM :)
REPOSITORY
R304 KNewStuff
BRANCH
phab/sort
REVISION DETAIL
https://phabricator.kde.org/D4156
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:6393cd598bb7: sort alphabetically category list (authored
by mart).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4156?vs=10274&id=10312
REVISION DETAIL
https
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Right. I think we can sensibly pick this. I would like a comment added,
though, that future "don't simply install things" logic should go into the
section above this one, rather than into t
mart updated this revision to Diff 10313.
mart added a comment.
- more comments
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4118?vs=10132&id=10313
BRANCH
phab/isarchive
REVISION DETAIL
https://phabricator.kde.org/D4118
AFFECTED FILES
src/core/
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:1388fb14b9d9: if is not an archive, always copy (authored
by mart).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4118?vs=10313&id=10314
REVISION DETAIL
https
broulik added a comment.
Are there other cursors that Mono might use? In Unity's 3D editor I get the
same ugly (but mirrored) cursor. I tried symlinking top_right_arrow but that
didn't help.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D3459
EMAIL PREFERENCES
htt
elvisangelaccio added a comment.
In https://phabricator.kde.org/D3459#78340, @broulik wrote:
> Are there other cursors that Mono might use? In Unity's 3D editor I get the
same ugly (but mirrored) cursor. I tried symlinking top_right_arrow but that
didn't help.
Your best bet is st
elvisangelaccio added a comment.
In https://phabricator.kde.org/D3459#78342, @elvisangelaccio wrote:
> In https://phabricator.kde.org/D3459#78340, @broulik wrote:
>
> > Are there other cursors that Mono might use? In Unity's 3D editor I get
the same ugly (but mirrored) cursor. I tried
marten created this revision.
marten added reviewers: Frameworks, Plasma.
marten set the repository for this revision to R290 KPackage.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As described in https://bug
https://bugs.kde.org/show_bug.cgi?id=363860
Jonathan Marten changed:
What|Removed |Added
CC||p.suetter...@royac.iac.es
--- Comment #2 from
https://bugs.kde.org/show_bug.cgi?id=363860
--- Comment #3 from Pit ---
So the other bugreport (368955) is marked as 'solved (duplicate)', and this one
here still stays unconfirmed (despite Comment 1)?
Yes, I can confirm that this is a bug, and it is a very annoying one.
And to add the informat
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/685/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 14:28:45 +
Build duration: 2 min 16 sec
CHANGE SET
Revision 77e57190edea71fc5cb6868f2e5fe
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 14:48:06 +
Build duration: 2 min 13 sec
CHANGE SET
Revision 899ea779750b0552931
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/686/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 15:11:25 +
Build duration: 7 min 21 sec
CHANGE SET
Revision 918aa7482567b4ff61585deb3fe8
graesslin updated this revision to Diff 10323.
graesslin added a comment.
- Rebased to current master
- Removed dependency to InputRedirection as no longer needed
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4135?vs=10169&id=10323
BRANCH
keyboard-layout
graesslin added a comment.
ping!
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4128
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, j
bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
event-spy-for-key-changes
REVISION DETAIL
https://phabricator.kde.org/D4128
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefere
bshah added inline comments.
INLINE COMMENTS
> keyboard_input.cpp:502
>
> +class KeyStateChangedSpy : public InputEventSpy
> +{
This code seems to be from https://phabricator.kde.org/D4128?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4135
EMAIL PREFERENCES
https:
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/687/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 15:41:37 +
Build duration: 5 min 33 sec
CHANGE SET
Revision fa92dad1fff534ebe321b68a1dfe
hein created this revision.
hein added reviewers: Plasma, mart.
hein added a subscriber: plasma-devel.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Means long main texts don't get truncated. One of the main use
hein updated this revision to Diff 10326.
hein added a comment.
Better pick.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4189?vs=10325&id=10326
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4189
AFFECTED FILES
src
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4189
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, mar
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:593f8183dd4e: Set wrapMode to Text.WrapAnywhere.
(authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4189?vs=10326&id=10327
REVIS
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 15:55:48 +
Build duration: 7 min 19 sec
CHANGE SET
Revision edd629b221af958616c
Hello people,
I guess it is time to start thinking about the topics we are going to
discuss at Plasma Sprint.
For that I've started a etherpad [1], and added the ideas that Martin
pointed in his earlier email. Please add topics you would like to
discuss.
Thanks
[1] https://notes.kde.org/p/plasm
broulik added inline comments.
INLINE COMMENTS
> mart wrote in ToolTipInstance.qml:92
> try to restore this spacing, maybe is the reson the tooltip is still a bit
> larger
I don't understand. Column (in contrast to ColumnLayout) has a default spacing
of 0
REPOSITORY
R119 Plasma Desktop
REV
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 16:32:00 +
Build duration: 11 min
CHANGE SET
Revision ad4eb8b6738c739b755b6012b
graesslin added inline comments.
INLINE COMMENTS
> bshah wrote in keyboard_input.cpp:502
> This code seems to be from https://phabricator.kde.org/D4128?
yeah, arc fail on my side. Please ignore :-)
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4135
EMAIL PREFERENCES
bshah added inline comments.
INLINE COMMENTS
> graesslin wrote in keyboard_input.cpp:502
> yeah, arc fail on my side. Please ignore :-)
Makes kinda hard to see actual change, can you perhaps redo this RR?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4135
EMAIL PREFERE
graesslin added inline comments.
INLINE COMMENTS
> bshah wrote in keyboard_input.cpp:502
> Makes kinda hard to see actual change, can you perhaps redo this RR?
I'll push the other change then it hopefully solves by updating
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:437edb45ca84: Use an InputEventSpy to notify about key
and modifier state changes (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4128?vs=10156
graesslin updated this revision to Diff 10330.
graesslin added a comment.
Rebased to master
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4135?vs=10323&id=10330
BRANCH
keyboard-layout
REVISION DETAIL
https://phabricator.kde.org/D4135
AFFECTED FILES
C
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/688/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 16:32:30 +
Build duration: 19 min
CHANGE SET
Revision 899ea779750b05529315ad0e4cb57b463e
Hi all,
I just had a look at build.kde.org and noticed that plasma-integration
for 5.9 is red:
16:54:01 [ 7%] Building CXX object
src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/kdeplatformtheme.cpp.o
16:54:02 In file included from
/home/jenkins/sources/plasma-integration/stable-kf5
bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
keyboard-layout
REVISION DETAIL
https://phabricator.kde.org/D4135
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
I'm on it.
David
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It didn't exist in Qt 5.6
TEST PLAN
Compiled on master and still had a working menu
CI wil
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 16:57:22 +
Build duration: 12 min
CHANGE SET
Revision b0c2d26470aa4d0a43f86b937
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:d6c0a5414eb2: Split implementation of keyboard layout
handling into a dedicated class (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4135?vs=1
bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4191
EMAIL PREFERENCES
https://phabricator.kde.org/settings/
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:9bc4c8280db5: Only use Qt's DBusMenuBar in Qt >= 5.7
(authored by davidedmundson).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
Am 2017-01-18 18:05, schrieb David Edmundson:
I'm on it.
Thank!
graesslin added a comment.
It looks like it wasn't the only usage...
[ 58%] Building CXX object
autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kfontsettingsdata.cpp.o
18:46:32 [ 60%]
/home/jenkins/sources/plasma-integration/stable-kf5-qt5/src/platformtheme/
davidedmundson added a comment.
I deliberately left them in because they were just normal DBus calls that
wouldn't do any harm (or be used) and didn't require any extra deps.
However it meant nothing was implicitly including and
failed.
It's rebuildling now.
REPOSITORY
R135 Integra
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/689/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 18:48:09 +
Build duration: 18 min
CHANGE SET
Revision 9831eee505f9dc089e72f8f6d285e53ca8
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/690/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 19:10:14 +
Build duration: 15 min
CHANGE SET
Revision a0470a089f91f4f381690b48eafe33587c
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 19:24:29 +
Build duration: 4 min 55 sec
CHANGE SET
Revision dd0d19d04b51fee0f17
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/691/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 19:29:17 +
Build duration: 6 min 32 sec
CHANGE SET
Revision b0c2d26470aa4d0a43f86b937428
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129851/
---
Review request for Plasma.
Repository: kio-extras
Description
---
graesslin added a comment.
Sorry David, it failed again:
19:20:10 [ 56%] Built target kfontsettingsdata_unittest
19:20:10 [ 58%] Building CXX object
autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/qdbusmenubar.cpp.o
19:20:11 In file included from
/home/j
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:c7f0b1453720: Fix segfault in trigrams generation and
expose MAXGRAMS constant in the header (authored by jsalatas).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4
davidedmundson added a comment.
A commented out warning doesn't make much sense.
Either it's a valid warning at which point the root cause needs fixing not
hiding, or it's wrong and should be removed.
The hard part of doing this change is working out which of those is correct.
REPOSITO
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129851/#review102089
---
Good idea. Did you test the rotation part? I don't know if t
arichardson created this revision.
arichardson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We currently get the following sequence of calls:
KDEPlatformFileDialogHelper::setDirectory
QUr
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
If an image is created with no size, QImage::data() points to nullptr.
We then pass this as a
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4196
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Currently the dialog just leaks. As a top level window it should get
cleaned up by the QAppli
Possible fix: https://phabricator.kde.org/D4197
It's a bit of a guess, so I'm not 100% confident.
Can you test and report back.
Note this only fixes Jan's crash, and not CFeck's which I think is
different.
David
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We want to rely on some Qt5.7 features in upcoming Plasma
for example qAsConst
REPOSITORY
jsalatas added a comment.
Seems to work.
It also fixes another (maybe related) issue in network mananager:
1. Right Click the nm applet and choose "Configure Network Connections"
2. Click "Add new connection"
3. Having the "Choose a connection type" window open, click "Cancel"
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129835/#review102090
---
Ping
- Anthony Fieroni
On Ян. 15, 2017, 12:27 след обяд,
graesslin added a comment.
Do we have 5.7 on the CI? If not we should tell sysadmins.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4198
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: graes
graesslin added inline comments.
INLINE COMMENTS
> kdeplatformfiledialoghelper.cpp:365-370
> +#if QT_VERSION < QT_VERSION_CHECK(5, 7, 1)
> +// Qt 5 at least <= 5.7.1 does not derive the directory from the passed
> url
> // and set the initialDirectory option accordingly, also not for kn
jgrulich accepted this revision.
jgrulich added a reviewer: jgrulich.
jgrulich added a comment.
This revision is now accepted and ready to land.
I just tested it and it works perfectly and the kcm doesn't crash anymore.
Thank you David!!.
Close this bug please with this review
https://bu
> On Jan. 19, 2017, 1:17 a.m., Christoph Feck wrote:
> > Good idea. Did you test the rotation part? I don't know if the rotation
> > options expected by Qt are the same as returned by the settings.
Yes, it works. There is only one rotation option in the settings - whether to
auto-rotate or not
68 matches
Mail list logo
