[Differential] [Updated, 7 lines] D4156: sort alphabetically category list

2017-01-17 Thread Marco Martin
mart updated this revision to Diff 10274. mart added a comment. - use QCollator REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4156?vs=10222&id=10274 BRANCH phab/sort REVISION DETAIL https://phabricator.kde.org/D4156 AFFECTED FILES src/attica/att

[Differential] [Updated, 283 lines] D4103: Support spring-loading on drag hover and drops into preview popups.

2017-01-17 Thread Eike Hein
hein updated this revision to Diff 10275. hein added a comment. Full spring-loading support for list view mode including CompactRepr. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4103?vs=10109&id=10275 BRANCH master REVISION DETAIL https://ph

[Differential] [Accepted] D4168: Move X11 specific KGlobalAccel handling into the x11-standalone platform

2017-01-17 Thread Roman Gilg
subdiff accepted this revision. subdiff added a reviewer: subdiff. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH action-kglobalaccel-to-x11 REVISION DETAIL https://phabricator.kde.org/D4168 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Changed Subscribers] D4165: Drop KWin's internal global shortcut handling

2017-01-17 Thread Roman Gilg
subdiff added inline comments. INLINE COMMENTS > globalshortcuts.cpp:173 > -{ > -QKeySequence s = getShortcutForAction(KWIN_NAME, action->objectName(), > shortcut); > -if (s.isEmpty()) { `getShortcutForAction` was only called here, so you could remove this function aswell? REPOSITORY

Re: Plasma 5.9 voice over text

2017-01-17 Thread Marco Martin
On Tuesday 17 January 2017 00:52:19 Łukasz Sawicki wrote: > Hi, > > Here is a script/voice over text for Plasma 5.9 video. It is heavily > based on Plasma 5.9 beta announcement. Please check it for grammar, > typos etc. > > https://notes.kde.org/p/Plasma_5.9_script > > Cheers, > > Łukasz Sawick

Re: "Software not found" Runner

2017-01-17 Thread Sebastian Kügler
On vrijdag 13 januari 2017 12:19:00 CET Harald Sitter wrote: > On Fri, Jan 13, 2017 at 11:56 AM, Marco Martin wrote: > > > > On Thursday 12 January 2017 14:46:49 Aleix Pol wrote: > > > >> On Tue, Jan 10, 2017 at 3:57 PM, Marco Martin wrote: > > > > >> Do we want this for 5.9? > > > > >

[Differential] [Reopened] D4113: Correct inital loading of BorderActivate

2017-01-17 Thread David Edmundson
davidedmundson reopened this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > I wonder what happens if we pass "-1" and what is " " cast as... If you pass -1, then registerScreenEdge would reject it, and " " would cast as 0. So absolutely wor

[Differential] [Updated, 4 lines] D4113: Correct inital loading of BorderActivate

2017-01-17 Thread David Edmundson
davidedmundson updated this revision to Diff 10276. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application added a subscriber: KWin. Validate on JS side REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Request, 6 lines] D4169: Remove unavailable ServiceTypes

2017-01-17 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.or

[Differential] [Accepted] D4113: Correct inital loading of BorderActivate

2017-01-17 Thread Thomas Lübking
luebking accepted this revision. luebking added a reviewer: luebking. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D4113 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart, luebking Cc: #kwi

[Differential] [Accepted] D4169: Remove unavailable ServiceTypes

2017-01-17 Thread Marco Martin
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > KF5PlasmaMacros.cmake:17 > # wallpaper, shell, lookandfeel, etc. > -# @see Types column in plasmapkg --list-types > +# @see Types column in kpackagetool5 --list-types

[Differential] [Closed] D4113: Correct inital loading of BorderActivate

2017-01-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R108:3ba1d9c40557: Parse minimise all borders on the JS side (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4113?vs=10276&id=10278 REVISION D

[Differential] [Request, 8 lines] D4170: [KRDB] Fix wording in comment at the top of "gtkrc"

2017-01-17 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KDE is the Community ;) Also, take int

[Differential] [Closed] D4169: Remove unavailable ServiceTypes

2017-01-17 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:c07851470aa1: Remove unavailable ServiceTypes (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4169?vs=10277&id=10280 REVISION

[Differential] [Updated, 19 lines] D4171: [Task Manager] Remove arbitrary sizes from tooltip

2017-01-17 Thread Kai Uwe Broulik
broulik removed a subscriber: hein. broulik updated this revision to Diff 10282. broulik added a comment. Use Heading opacity instead of forcing it to be 1 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4171?vs=10281&id=10282 REVISION DETAIL https

[Differential] [Commented On] D4171: [Task Manager] Remove arbitrary sizes from tooltip

2017-01-17 Thread Eike Hein
hein added a comment. Screenshot? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, subdiff Cc: hein, plasma-devel, lesliezhai, ali-moha

[Differential] [Request, 34 lines] D4172: Generate DBusMenu Interface for libdbusmenuqt

2017-01-17 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This not only makes the code cleaner but more importantly avoids plasma making a blocking DBu

[Differential] [Accepted] D4172: Generate DBusMenu Interface for libdbusmenuqt

2017-01-17 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4172 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated] D4171: [Task Manager] Remove arbitrary sizes from tooltip

2017-01-17 Thread Kai Uwe Broulik
broulik updated the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, subdiff Cc: plasma-devel, lesliezhai, ali

[Differential] [Request, 17 lines] D4171: [Task Manager] Remove arbitrary sizes from tooltip

2017-01-17 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, subdiff. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use a level 3 He

[Differential] [Updated] D4171: [Task Manager] Remove arbitrary sizes from tooltip

2017-01-17 Thread Roman Gilg
subdiff added a comment. Before you commit give me a few minutes time please. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, hein, su

[Differential] [Accepted] D4171: [Task Manager] Remove arbitrary sizes from tooltip

2017-01-17 Thread Eike Hein
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_

[Differential] [Changed Subscribers] D4171: [Task Manager] Remove arbitrary sizes from tooltip

2017-01-17 Thread Roman Gilg
subdiff added a subscriber: Fuchs. subdiff added a comment. F2082185: edit.png The gap between the app name and the top of the tooltip is increased. Is it possible to reduce it? Otherwise the tooltip in total gets bigger again and the close button t

[Differential] [Commented On] D4172: Generate DBusMenu Interface for libdbusmenuqt

2017-01-17 Thread Kai Uwe Broulik
broulik added a comment. Doesn't compile: make[2]: *** No rule to make target: "../libdbusmenuqt/com.canonical.dbusmenu.xml", needed by "libdbusmenuqt/dbusmenu_interface.cpp" REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4172

[Differential] [Updated, 66 lines] D4165: Drop KWin's internal global shortcut handling

2017-01-17 Thread Martin Gräßlin
graesslin updated this revision to Diff 10288. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application added a subscriber: kwin. - Rebased to current master - Dropped no longer needed private method - which in turn allowed to dro

[Differential] [Closed] D4168: Move X11 specific KGlobalAccel handling into the x11-standalone platform

2017-01-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:2904d4a0be45: Move X11 specific KGlobalAccel handling into the x11-standalone platform (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4168?vs=

[Differential] [Updated, 70 lines] D4165: Drop KWin's internal global shortcut handling

2017-01-17 Thread Martin Gräßlin
graesslin updated this revision to Diff 10289. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. And drop some no longer needed includes REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4165?vs=10288&id=10289 BRANCH

[Differential] [Request, 5 lines] D4174: correctly forward status from applets to containment

2017-01-17 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY unfortunately hiddenvisibility is the "biggest" status that makes computing the proper stat

[Differential] [Accepted] D4165: Drop KWin's internal global shortcut handling

2017-01-17 Thread Roman Gilg
subdiff accepted this revision. subdiff added a reviewer: subdiff. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH drop-internal-global-shortcuts REVISION DETAIL https://phabricator.kde.org/D4165 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Accepted] D4174: correctly forward status from applets to containment

2017-01-17 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/visibilityforward REVISION DETAIL https://phabricator.kde.org/D4174 EMAIL PREFERENCES https://p

[Differential] [Accepted] D4170: [KRDB] Fix wording in comment at the top of "gtkrc"

2017-01-17 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4170 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Closed] D4174: correctly forward status from applets to containment

2017-01-17 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:47ec9b84db5c: correctly forward status from applets to containment (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4174?vs=102

[Differential] [Updated, 83 lines] D4172: Generate DBusMenu Interface for libdbusmenuqt

2017-01-17 Thread David Edmundson
davidedmundson updated this revision to Diff 10292. davidedmundson added a comment. Add .xml file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4172?vs=10283&id=10292 BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4172 AFFEC

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 684 - Unstable!

2017-01-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/684/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 Jan 2017 16:03:16 + Build duration: 30 min CHANGE SET Revision 25297320c2514c75abf734abf3f2d97e6c

[Differential] [Request, 6 lines] D4176: Don't re-evaluate the model constantly whilst looping through windows

2017-01-17 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We only want to set the menu to unavailable when we've searched all the transient windows and

[Differential] [Request, 15 lines] D4177: Hide menu if the menu disappears off DBus

2017-01-17 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This can happen without a focus change if focus is changed to a window that doesn't claim the

[Differential] [Request, 2 lines] D4178: The welcome message is better written now

2017-01-17 Thread Ivan Čukić
ivan created this revision. ivan added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4178 AFFECTED FILES lookandfeel/c

[Differential] [Commented On] D4178: The welcome message is better written now

2017-01-17 Thread Kai Uwe Broulik
broulik added a comment. -1 We're after the freeze and it's supposed to be a tagline "Plasma made by KDE" and not a Wikipedia article introduction. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4178 EMAIL PREFERENCES https://phabricator.kde.org/set

[Differential] [Accepted] D4177: Hide menu if the menu disappears off DBus

2017-01-17 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Bug 374995? REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4177 EMAIL PREFERENCES https://pha

[Differential] [Commented On] D4177: Hide menu if the menu disappears off DBus

2017-01-17 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > appmenumodel.cpp:35 > #include > +#include > +#include Unused REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4177 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Accepted] D4176: Don't re-evaluate the model constantly whilst looping through windows

2017-01-17 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4176 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Closed] D4172: Generate DBusMenu Interface for libdbusmenuqt

2017-01-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:9d58703d3725: Generate DBusMenu Interface for libdbusmenuqt (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4172?vs=10292&id=1

[Differential] [Closed] D4161: Signal which menu has updated in libdbusmenu-qt

2017-01-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:77e57190edea: Signal which menu has updated in libdbusmenu-qt (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4161?vs=10243&id

[Differential] [Closed] D4163: pre-load the first layer of sub menus

2017-01-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6ed2c4a32b61: pre-load the first layer of sub menus (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4163?vs=10244&id=10299 RE

[Differential] [Closed] D4177: Hide menu if the menu disappears off DBus

2017-01-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:162543b7eb89: Hide menu if the menu disappears off DBus (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4177?vs=10295&id=10302

[Differential] [Closed] D4176: Don't re-evaluate the model constantly whilst looping through windows

2017-01-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:517be8484a80: Don't re-evaluate the model constantly whilst looping through windows (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 12 - Still Failing!

2017-01-17 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 Jan 2017 20:56:50 + Build duration: 10 min CHANGE SET Revision 77e57190edea71fc5cb6868f2

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 13 - Still Failing!

2017-01-17 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 Jan 2017 22:19:23 + Build duration: 12 min CHANGE SET Revision a735ac9d61c7886a14426a05a

[Differential] [Request, 14 lines] D4181: Sonnet: segfault in trigrams generation

2017-01-17 Thread John Salatas
jsalatas created this revision. jsalatas added a reviewer: Plasma. jsalatas set the repository for this revision to R246 Sonnet. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This patch fixes a Segm

[Differential] [Closed] D4165: Drop KWin's internal global shortcut handling

2017-01-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:32f4e115e2c6: Drop KWin's internal global shortcut handling (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4165?vs=10289&id=10309 REVISION DE