[Differential] [Request, 4 lines] D4138: Only update mute state after volume change is signalled from PA

2017-01-15 Thread David Rosca
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There is no difference for normal streams where setVolume and setMute are two different API calls, but it fix

Review Request 129835: [IconDialog] Set proper icons group

2017-01-15 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129835/ --- Review request for Plasma, Christoph Feck and Marco Martin. Repository: k

[Differential] [Request, 51 lines] D4140: Rework playing of volume feedback

2017-01-15 Thread David Rosca
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of manually playing feedback immediately on user interaction (but with wrong, old volume), connect to

[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow/precise scrolling is no longer intuitive

2017-01-15 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=375005 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- (Updated Jan. 15, 2017, 1:08 p.m.) Review request for Plasma. Changes -

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/#review102040 --- Ship it! Ship It! - Martin Koller On Jan. 15, 2017, 1:

Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-01-15 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/ --- Review request for Plasma and Kåre Särs. Bugs: 373776 http://bugs.kde

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-01-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/#review102043 --- seems mostly fine. applets/systemloadviewer/package/conten

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-01-15 Thread Martin Koller
> On Jan. 15, 2017, 3:29 p.m., David Edmundson wrote: > > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml, line 150 > > > > > > I think we want: > > > > connectedSources: sources() > >

Re: Review Request 123131: Port kio_man away from kdelibs4support

2017-01-15 Thread Martin Koller
> On March 25, 2015, 9:54 p.m., Lukáš Tinkl wrote: > > man/kio_man.cpp, line 242 > > > > > > Not correct, this returns only user configured list of languages, > > whereas it previously returned the full list. >

[Powerdevil] [Bug 365100] Power button ignored

2017-01-15 Thread Gordan Krešić
https://bugs.kde.org/show_bug.cgi?id=365100 Gordan Krešić changed: What|Removed |Added Version|5.6.5 |5.8.5 -- You are receiving this mail because:

[Differential] [Request, 1 line] D4143: Follow theme in taskmanager tooltip media controls background

2017-01-15 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently no colour is set, meaning it's defaulting to white. On Breeze dark this gives whit

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/#review102051 --- Ship it! Ship It! - Ivan Čukić On Jan. 15, 2017, 1:12

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- (Updated Jan. 15, 2017, 6:54 p.m.) Status -- This change has been ma

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- (Updated Jan. 15, 2017, 7:54 p.m.) Status -- This change has been ma

[Differential] [Request, 2 lines] D4145: Fix calling KWindowSystem::windowType without fetching the type

2017-01-15 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R120 Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabr

[Differential] [Accepted] D4145: Fix calling KWindowSystem::windowType without fetching the type

2017-01-15 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D4145 EMAIL PREFERENCES https://phabricator.

Re: Plasma Sprint discussion planning

2017-01-15 Thread Martin Gräßlin
Am 2017-01-13 16:27, schrieb Marco Martin: 3. Maintaining X11 specific code: Over the last half year exclusively on Wayland I realized that I cannot maintain X11 specific code any more. KWin is mostly no problem as XWayland windows are used the same way as native X windows. But things which hav

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 556 - Failure!

2017-01-15 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/556/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 05:10:51 + Build duration: 14 min CHANGE SET Revision c3971bb16e9680a0446831145422f2b4811bc

[Differential] [Request, 2 lines] D4153: Network manager configuration model is unreadable

2017-01-15 Thread John Salatas
jsalatas created this revision. jsalatas added reviewers: Plasma, Plasma: Design, jgrulich. jsalatas set the repository for this revision to R116 Plasma Network Management Applet. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUM

[Differential] [Updated, 4 lines] D4153: Network manager configuration model is unreadable

2017-01-15 Thread John Salatas
jsalatas updated this revision to Diff 10204. jsalatas added a comment. Previous diff was incomplete. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4153?vs=10203&id=10204 REVISION DETAIL https://phabricator.kde.org/D4153 AFFECT

[Differential] [Updated] D4153: Network manager configuration model is unreadable

2017-01-15 Thread Jan Grulich
jgrulich added a comment. I decided to try a different approach before we try to find a color which fits to all combinations (plasma theme + application color). I'm trying to get rid of Plasma QML components so it uses same colors which are used by the rest of application. REPOSITORY R116

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

2017-01-15 Thread John Salatas
jsalatas added a comment. In https://phabricator.kde.org/D4153#77525, @jgrulich wrote: > I'm trying to get rid of Plasma QML components so it uses same colors which are used by the rest of application. I guess that would be a better approach as it seems that plasma and applicatio

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 557 - Still Failing!

2017-01-15 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/557/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 05:56:11 + Build duration: 3 min 25 sec CHANGE SET Revision f5746ff9b77170b1945eae9d378c21b