Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- (Updated Jan. 7, 2017, 12:38 p.m.) Review request for Plasma. Changes -

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

> On Jan. 7, 2017, 4:48 a.m., Anthony Fieroni wrote: > > CMakeLists.txt, line 168 > > > > > > You still need find_package(KF5KHtml QUIET) In the line above, but QUIET is indeed prettier, thanks. - Andreas --

[Differential] [Commented On] D3085: Use DBusMenu if available

broulik added a comment. Meh. For the title bar button shouldn't matter, though, as there I create a new importer everytime you click the button, so the menu is always up-to-date. Dunno about the applet. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://p

[Differential] [Request, 74 lines] D4001: [Image Wallpaper] Simplify width/height management

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Directly expose "targetSize" as proper

[Differential] [Commented On] D4001: [Image Wallpaper] Simplify width/height management

davidedmundson added a comment. Cool, proper event compression, I'm a fan Two comments, then ship it. INLINE COMMENTS > image.cpp:235 > m_wallpaperPackage.removeDefinition("preferred"); > +emit targetSizeChanged(); > } I think this needs moving out of this

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 112 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/112/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 20:48:21 + Build duration: 57 sec CHANGE SET Revision bae324e37208d029c80d3d96bd897bdec93e2a

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 112 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/112/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 20:48:21 + Build duration: 57 sec CHANGE SET Revision bae324e37208d029c80d3d96bd897bdec93e2a

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 109 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/109/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 20:48:21 + Build duration: 5 min 55 sec CHANGE SET Revision bae324e37208d029c80d3d96b

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 109 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/109/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 20:48:21 + Build duration: 5 min 55 sec CHANGE SET Revision bae324e37208d029c80d3d96b

[Differential] [Updated, 80 lines] D4001: [Image Wallpaper] Simplify width/height management

broulik updated this revision to Diff 9824. broulik marked an inline comment as done. broulik added a comment. - Use magic plasmoid.width/plasmoid.height - Emit change whenever property changes, ie. move outside of single image if statement - Drop now unused width/height also from slidesho

[Differential] [Updated, 81 lines] D4001: [Image Wallpaper] Simplify width/height management

broulik updated this revision to Diff 9825. broulik added a comment. - Remove now unused m_size member, we just use m_targetSize REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4001?vs=9824&id=9825 REVISION DETAIL https://phabricator.kde.org/D400

[Differential] [Updated] D4001: [Image Wallpaper] Simplify width/height management

broulik updated the summary for this revision. broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4001 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: davide

[Differential] [Closed] D3943: Make sure we only initialize the appstream pool once

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6e1ca08eb9b4: Make sure we only initialize the appstream pool once (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3943?vs=9679&id=9833#toc REPOSITORY R119 Plasma Desktop

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #15 from Martin Klapetek --- > I will call that redundant information. For every one calling that a redundant information there will be someone calling that a missing information if it was removed. Sometimes redundant is better than missing