[Differential] [Commented On] D3714: Enable blurBehind effect if the window hints for it

graesslin added inline comments. INLINE COMMENTS > kwaylandintegration.cpp:35 > static const QByteArray s_schemePropertyName = > QByteArrayLiteral("KDE_COLOR_SCHEME_PATH"); > +static const QByteArray s_blurBehindPropertyName = > QByteArrayLiteral("ENABLE_BLUR_BEHIND_HINT"); > just wondering

[Differential] [Request, 19 lines] D3720: Place OSD windows again on size changes

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The position of an OSD is based on the size of the window. If the size of the OSD changed, it w

[Differential] [Request, 607 lines] D3723: Introduce a KWin internal on-screen-notification service

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Recently we noticed that there are multiple areas where KWin needs to inform the user about how

[Differential] [Request, 6 lines] D3724: Use OnScreenNotification in kill window

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Inform how to kill a window. REPOSITORY R108 KWin BRANCH kill-window-osd REVISION DETAIL

[Differential] [Updated] D3723: Introduce a KWin internal on-screen-notification service

graesslin added a dependent revision: D3724: Use OnScreenNotification in kill window. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3723 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin

[Differential] [Updated] D3723: Introduce a KWin internal on-screen-notification service

graesslin added a dependency: D3720: Place OSD windows again on size changes. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3723 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliez

[Differential] [Updated] D3724: Use OnScreenNotification in kill window

graesslin added a dependency: D3723: Introduce a KWin internal on-screen-notification service. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3724 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-de

[Differential] [Updated] D3720: Place OSD windows again on size changes

graesslin added a dependent revision: D3723: Introduce a KWin internal on-screen-notification service. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3720 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: p

Review Request 129669: WindowThumbnail] Update thumbnail content

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129669/ --- Review request for Plasma and David Edmundson. Repository: plasma-framewo

[Differential] [Request, 6 lines] D3725: [AppletQuickItem] Support launch error message

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Now that we can have C++ applet we ca

[Differential] [Request, 19 lines] D3726: Make sure pages are destroying when popping

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For some reason, reparenting the page is not enough. Also fixes the test which was not working properly.

[Differential] [Commented On] D3706: WIP: Global Menu Applet

davidedmundson added a comment. Bugs from running it: The menu doesn't immediately disappear when I focus from a window with a shared menu, to a window without. Interacting with menu still crashes. The config option for "compact and full" is a bit unusual. The Plasma style, is to tr

[Differential] [Updated, 1,884 lines] D3085: RFC: Use DBusMenu if available

davidedmundson updated this revision to Diff 9146. davidedmundson marked 2 inline comments as done. davidedmundson added a comment. - Working Qt5.8 build - Qt5.7 support..hopefully - remove our own alt key handling, Qt has it in 5.7.1 in a slightly neater way - Atom caching REPOSITORY

[Differential] [Commented On] D3706: WIP: Global Menu Applet

davidedmundson added inline comments. INLINE COMMENTS > appmenuapplet.cpp:141 > +if (e->key() == Qt::Key_Left) { > +emit requestActivateIndex(m_currentIndex - 1); > +return true; It's more normal to do the bounding to the right value before you emit a signal, rat

[Differential] [Request, 2 lines] D3728: [Kickoff] Support drag from bookmarks runner

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Bookmarks runner also sets the URL

[Differential] [Updated] D3728: [Kicker] Support drag from bookmarks runner

broulik retitled this revision from "[Kickoff] Support drag from bookmarks runner" to "[Kicker] Support drag from bookmarks runner". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3728 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc