[Differential] [Accepted] D3688: [Runners] Register actions right away

2016-12-16 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3688 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D2687: [Icon Widget] Bring back properties dialog

2016-12-16 Thread dfaure (David Faure)
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > iconapplet.cpp:285 > + > +// otherwise check if the applicaton supports the dropped type > +// TODO should we execute if *any* of the urls are supported,

Re: Selecting a Plasma logo

2016-12-16 Thread Marco Martin
On Wednesday 07 December 2016 13:58:34 Jens Reuterberg wrote: > About half a year ago this thread started and so far no actual change has > happened. > > The background is that the past logo for Plasma Desktop was disagreed upon > by the Plasma developer team and they wanted a new one. Thomas crea

[Differential] [Request, 2 lines] D3701: cmake: Raise KF5 requirement to 5.29.0

2016-12-16 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At least kwindowsystem-5.29.0 is needed since https://phabricator.kde.org/R120:bbbce3a55e011bd9d3c5

[Differential] [Accepted] D3701: cmake: Raise KF5 requirement to 5.29.0

2016-12-16 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3701 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D3701: cmake: Raise KF5 requirement to 5.29.0

2016-12-16 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf1dfd4da511: cmake: Raise KF5 requirement to 5.29.0 (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3701?vs=9064&id=9067 REVISI

[Differential] [Closed] D3687: take matching logic out of match method and put it into a class

2016-12-16 Thread sitter (Harald Sitter)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:8c7a95cc2cd7: take matching logic out of match method and put it into a class (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3687?vs=

[Differential] [Closed] D3685: Add SDDM theme install/uninstall with GHNS to the SDDM KCM

2016-12-16 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit R123:ea3e8d39731b: Add SDDM theme install/uninstall with GHNS to the SDDM KCM (authored by davidedmundson). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Updated, 1,015 lines] D2687: [Icon Widget] Bring back properties dialog

2016-12-16 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 9074. broulik added a comment. - Remove now unused icon qml plugin - Drop cumbersome drop handling – if the user explicitly dropped some files somewhere the application should just launch with them, shouting at the user if unsupported REPOSITORY R120

[Differential] [Commented On] D2687: [Icon Widget] Bring back properties dialog

2016-12-16 Thread dfaure (David Faure)
dfaure added a comment. Shouting or just coping with the file (e.g. displaying raw data, for a text editor) ;) Looks good, thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Request, 4 lines] D3703: Fix build (with clang at least)

2016-12-16 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY No need to capture the variable as it's static. Also apparently wrong. Used to get the following error message

[Differential] [Accepted] D3703: Fix build (with clang at least)

2016-12-16 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D3703 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Request, 24 lines] D3704: ensure results are sorted by relevance

2016-12-16 Thread sitter (Harald Sitter)
sitter created this revision. sitter added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY once we have built our actual final "raw-data" in the mapping hash, we iterate all runners and sort their match

[Differential] [Updated, 6 lines] D3704: ensure results are sorted by relevance

2016-12-16 Thread sitter (Harald Sitter)
sitter updated this revision to Diff 9078. sitter added a comment. remove cruft arc amended because I don't read (: REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3704?vs=9077&id=9078 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.o

[Differential] [Request, 2 lines] D3705: do not explicitly check NotShownIn it's not necessary and incomplete

2016-12-16 Thread sitter (Harald Sitter)
sitter created this revision. sitter added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KService::noDisplay() includes qualification for - NoDisplay entry itself - OnlyShowIn and NotShowIn

[Differential] [Closed] D3703: Fix build (with clang at least)

2016-12-16 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit R108:1f5356e609c2: Fix build (with clang at least) (authored by apol). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3703?vs=9076&id=9082 REVISION DETAIL https://phabri

[Differential] [Accepted] D3705: do not explicitly check NotShownIn it's not necessary and incomplete

2016-12-16 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3705 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, broulik Cc: plasm

[Differential] [Closed] D3705: do not explicitly check NotShownIn it's not necessary and incomplete

2016-12-16 Thread sitter (Harald Sitter)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b9ac84508645: do not explicitly check NotShownIn it's not necessary and incomplete (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D370

[Differential] [Closed] D3688: [Runners] Register actions right away

2016-12-16 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4440a0d0115f: [Runners] Register actions right away (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3688?vs=9043&id=9085 REVISION DE

[Differential] [Request, 884 lines] D3706: WIP: Global Menu Applet

2016-12-16 Thread chinmoyr (Chinmoy Ranjan Pradhan)
chinmoyr created this revision. chinmoyr added reviewers: Plasma, broulik. chinmoyr set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This restores the global me

[Differential] [Commented On] D3706: WIP: Global Menu Applet

2016-12-16 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > appmenuapplet.cpp:91 > +ctx->window()->mouseGrabberItem()->ungrabMouse(); > +} > + Somehow your indentation is a bit off? > configGeneral.qml:44 > +id: fullRepresentationRadio > +text: i18n("Ful

[Differential] [Closed] D2687: [Icon Widget] Bring back properties dialog

2016-12-16 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:caea0aa4ee22: [Icon Widget] Bring back properties dialog (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2687?vs=9074&id=9086#toc REPOSITORY R120 Plasma Workspace CHAN

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

2016-12-16 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=366299 --- Comment #7 from Wolfgang Bauer --- (In reply to Pavel from comment #6) > (In reply to Wolfgang Bauer from comment #5) > > For now, just open the settings in systemsettings5 ("Configure Desktop" in > > openSUSE), and they will have the scrollbar if t

[Differential] [Request, 235 lines] D3707: add simple test rig for service runner

2016-12-16 Thread sitter (Harald Sitter)
sitter created this revision. sitter added reviewers: broulik, dfaure. sitter added subscribers: plasma-devel, dfaure. Restricted Application added a project: Plasma. REVISION SUMMARY - make sure that chrome apps have lower relevance than chrome itself - makes sure that konsole has higher rele

[Differential] [Request, 2 lines] D3710: Fix resetMenu

2016-12-16 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If initialItem is not an actual item (now a Component), then it can't be used for stackView.pop(initialI

[Differential] [Accepted] D3710: Fix resetMenu

2016-12-16 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3710 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Closed] D3710: Fix resetMenu

2016-12-16 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit R169:169e16ce0787: Fix resetMenu (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3710?vs=9091&id=9092 REVISION DETAIL https://phabricator.kde.org/D

[Question-Problem]: Panel Configuration Window, a way to override it or replace it...

2016-12-16 Thread Michail Vourlakos
Hello everyone, In Now Dock I am using the default plasma panel's infrastructure on top of which I am providing in a secondary window all the various options from Now Dock for visibility states, settings etc... But there is an issue with this approach that there are two different settings wind

[Differential] [Requested Changes To] D3707: add simple test rig for service runner

2016-12-16 Thread dfaure (David Faure)
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > servicerunnertest.cpp:5 > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU Library General Publ

[Differential] [Accepted] D3216: WIP: Restore Menubar style config in application style

2016-12-16 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. what's with the notifyrc change? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3216 EMAIL

[Breeze] [Bug 373668] Tiny keyboard layout indicator is the Lock Screen

2016-12-16 Thread Anton
https://bugs.kde.org/show_bug.cgi?id=373668 --- Comment #6 from Anton --- (In reply to Eike Hein from comment #5) > I suggest you test 5.8.5 soon and see if you think the adjusted version is > good enough, and if not provide more feedback. I will test it once this version is available. The lates

[Breeze] [Bug 373668] Tiny keyboard layout indicator is the Lock Screen

2016-12-16 Thread Anton
https://bugs.kde.org/show_bug.cgi?id=373668 --- Comment #7 from Anton --- Created attachment 102827 --> https://bugs.kde.org/attachment.cgi?id=102827&action=edit tiny indicator Is it hide and seek game? It is almost impossible to find it if you don't know where to look for. Try to simulate a f

[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)

2016-12-16 Thread James Lee
https://bugs.kde.org/show_bug.cgi?id=363147 James Lee changed: What|Removed |Added Version|5.6.4 |5.8.4 --- Comment #1 from James Lee --- I've rebas