broulik closed this revision.
broulik added a comment.
Committed into master in
https://cgit.kde.org/breeze.git/commit/?id=ab984d2ed689322c3b11be6042053bcfd33f3807
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3660
EMAIL PREFERENCES
https://phabricator.kd
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3660
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kvermette
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R128 User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3658
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dav
This revision was automatically updated to reflect the committed changes.
Closed by commit R128:4761ae39b60d: Hide "automatic login" button in
UserAccounts since is does absolutely nothing (authored by davidedmundson).
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
https://phabricato
This revision was automatically updated to reflect the committed changes.
Closed by commit R128:b154c7522b63: Set Automatic login flag to adjust SDDM
config directly (authored by davidedmundson).
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3658?vs=8957
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:cec5bb27f111: Test the variable type without warning
(authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3666?vs=8977&id=8997
REVISION DETAIL
htt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129652/#review101433
---
Ship it!
Ship It!
- Marco Martin
On Dec. 14, 2016, 5:5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/#review101434
---
Ship it!
Ship It!
- Marco Martin
On Nov. 22, 2016, 1:0
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129642/#review101435
---
Ship it!
Ship It!
- Marco Martin
On Dec. 12, 2016, 3:1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129603/#review101436
---
Ship it!
Ship It!
- Marco Martin
On Dec. 2, 2016, 9:05
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129642/#review101438
---
Ship it!
Ship It!
- Dan Leinir Turthra Jensen
On Dec.
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, graesslin.
broulik set the repository for this revision to R133 KScreenLocker.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
... and unpause
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/
---
(Updated Dec. 14, 2016, 1:52 p.m.)
Status
--
This change has been ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/#review101439
---
sorry, I submitted this yesterday, I just forgot to add the
apol created this revision.
apol added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
less warnings when compiling plasma-workspace
REPOSITORY
R242 Plasma Frameworks
BRANCH
master
REVISION DETAIL
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Frameworks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3679
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma, mart
Cc: pla
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7b5f5b57b0cf: Introduce undefined fields (authored by
apol).
REPOSITORY
R242 Plasma Frameworks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3679?vs=9010&id=9011
REVISION DETAIL
https:
apol created this revision.
apol added reviewers: Plasma, Frameworks, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Since recently we're also listing the metadata.desktop file which is the code
path we wanted to
mart added a comment.
I would rather have media controls in the greeter.
I don't like yet another option that does something rather weird :/
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D3674
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/em
mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> packageloader.cpp:251
> +
> +if (dirs.contains(dir))
> +continue;
use { }
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
davidedmundson added a comment.
Seems sensible. +1
As it's an RFC, it's a shame we have so much duplicated code for media player
management; but I don't think there's any existing simple way round that. Any
thoughts on how we collectively can fix that?
REPOSITORY
R133 KScreenLocker
apol updated this revision to Diff 9014.
apol added a comment.
{} for marco
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3680?vs=9012&id=9014
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3680
AFFECTED FILES
src/kpackage/packageloader.cpp
EMAIL PREFERENCES
apol marked an inline comment as done.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3680
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb
apol closed this revision.
REVISION DETAIL
https://phabricator.kde.org/D3680
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129603/
---
(Updated Dec. 14, 2016, 3:45 p.m.)
Status
--
This change has been ma
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
setting an errorDescription on an object then replacing an object
doesn't do anything.
TEST
graesslin added a comment.
Like Marco I would prefer proper media controls. The feature like that
doesn't make sense IMHO.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D3674
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To
broulik abandoned this revision.
broulik added a comment.
IMHO this feature is completely orthogonal to "proper" media controls. But I
respect your decision.
So, about proper media controls, would re-using the mpris data engine in
Plasma from QML be an option or should it rather be some
davidedmundson added a comment.
> The feature like that doesn't make sense IMHO.
Why?
Media controls doesn't help with this usecase. You come back, you press
resume, your movie resumes...whilst your screen is still locked.
And if you unlock first..then you don't have the controls v
oliverhenshaw added a comment.
Surely the ideal world is one where the movie player realises the screen is
locked and makes the decision to pause by itself? Media controls might still be
a better option for audio players, but I wonder whether volume controls are
better than that?
REPOSITORY
graesslin added a comment.
In https://phabricator.kde.org/D3674#68838, @davidedmundson wrote:
> > The feature like that doesn't make sense IMHO.
>
> Why?
>
> Media controls doesn't help with this usecase. You come back, you press
resume, your movie resumes...whilst your screen is
graesslin added a comment.
> So, about proper media controls, would re-using the mpris data engine in
Plasma from QML be an option or should it rather be some implementation in
ksldapp given you wanted to disable dbus access for the locker?
reusing the existing engine is fine. For disabl
davidedmundson added a comment.
> But for the sake of argument let's assume the usecase is valid.
No assumption is needed, it *is* valid. Assuming you have lock on suspend,
which is the default:
Case 1:
You run out of power.
Case 2:
You close the lid
Having the movie co
graesslin added a comment.
> Having the movie contiue before you've logged back in is a state I've been
in.
Arguable that could also be handled by the media players by doing a temp
inhibit to pause the movie. But yes that makes sense, but maybe more in
powermanagement than in lock scree
broulik added a comment.
> use apparmor at some future point
and from what I understand DBus access can be restricted on a
per-interface/service basis with that? Dunno if it can do wildcards, though.
> Kai, can you expand on your use cases
At Randa I was listening to music, then
https://bugs.kde.org/show_bug.cgi?id=366299
Pavel changed:
What|Removed |Added
CC||zol...@gmail.com
--- Comment #4 from Pavel ---
I don't
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:cd78b8ca4926: Make kirigami.qrc ressource path relative
to CMAKE_CURRENT_SOURCE_DIR (authored by franckarrecot).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D364
subdiff updated this revision to Diff 9024.
subdiff added a comment.
Using David's superior method. With this method it's also possible to have in
the VLC case, where they don't append the pid, atleast the one controllable
media player instance identified.
REPOSITORY
R120 Plasma Workspace
> On Nov. 2, 2016, 3:49 p.m., David Edmundson wrote:
> > do you have commit access?
>
> Miklós Máté wrote:
> I don't have commit access.
I noticed that this hasn't been committed yet. Is there something wrong with
the patch?
- Miklós
subdiff updated this revision to Diff 9025.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3667?vs=9024&id=9025
REVISION DETAIL
https://phabricator.kde.org/D3667
AFFECTED FILES
dataengines/mpris2/playercontainer.cpp
EMAIL PREFERENCES
https://p
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/
---
(Updated Dec. 14, 2016, 11:15 p.m.)
Status
--
This change has been m
> On Nov. 2, 2016, 2:49 p.m., David Edmundson wrote:
> > do you have commit access?
>
> Miklós Máté wrote:
> I don't have commit access.
>
> Miklós Máté wrote:
> I noticed that this hasn't been committed yet. Is there something wrong
> with the patch?
Done, sorry about that. Thanks fo
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> iconapplet.cpp:242
> +{
> +new KRun(QUrl::fromLocalFile(m_localPath), nullptr);
> +}
Just wondering, why is the parent widget nullptr here, while it's
QA
https://bugs.kde.org/show_bug.cgi?id=366299
--- Comment #5 from Wolfgang Bauer ---
(In reply to Pavel from comment #4)
> but as far as I remember, there was a scrollbar on the right side
> of the window, so I was able to scroll the frame with settings controls by
> using this scrollbar or using t
https://bugs.kde.org/show_bug.cgi?id=373668
Bug ID: 373668
Summary: Tiny keyboard layout indicator is the Lock Screen
Product: Breeze
Version: 5.8.4
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity:
https://bugs.kde.org/show_bug.cgi?id=366299
--- Comment #6 from Pavel ---
(In reply to Wolfgang Bauer from comment #5)
> (In reply to Pavel from comment #4)
> > but as far as I remember, there was a scrollbar on the right side
> > of the window, so I was able to scroll the frame with settings con
https://bugs.kde.org/show_bug.cgi?id=373668
Kai Uwe Broulik changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
CC|
47 matches
Mail list logo
