[Differential] [Changed Subscribers] D3617: [Touchpad KCM] New KWin Wayland version

graesslin added inline comments. INLINE COMMENTS > kwinwaylandbackend.cpp:59-63 > +foreach (QObject *d, m_devices) { > +if (d) { > +delete d; > +} > +} check qDeleteAll > kwinwaylandbackend.cpp:60-61 > +foreach (QObject *d, m_devices) { > +if (d)

[Differential] [Commented On] D3598: rework kscreen's OSD logic

broulik added a comment. A bunch of nitpicks below. Haven't tried it yet, though :) Is there a chance we could serve the novice user usecase of Meta+P and then *click* / choose the desired setup? As far as I can tell we only show "You now use $setup" but not "You can choose: [Clone, Left

[Differential] [Accepted] D3615: [Kicker] Hide "Edit Applications..." context menu entry if system immutable

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3615 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D3606: Listen for broadcast notifications on system bus

mart added a comment. In https://phabricator.kde.org/D3606#67898, @broulik wrote: > What would be the best place to put a little utility (similar to notify-send or kdialog --passivepopup) for this? kde-cli-tools REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabri

[Differential] [Commented On] D3598: rework kscreen's OSD logic

mart added a comment. In https://phabricator.kde.org/D3598#67455, @sebas wrote: > protocol), we'll move this code into its own daemon and kwin will authorize that daemon. THat's basically the same approach we'll have to take with powerdevil. so in the end the authorized process w

[Differential] [Closed] D3615: [Kicker] Hide "Edit Applications..." context menu entry if system immutable

This revision was automatically updated to reflect the committed changes. Closed by commit R119:00d160aab929: [Kicker] Hide "Edit Applications..." context menu entry if system immutable (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 475 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/475/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Dec 2016 09:04:58 + Build duration: 3 min 25 sec CHANGE SET Revision 00d160aab9291ae2eb4b21aeddf95ec

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 476 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/476/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Dec 2016 09:14:20 + Build duration: 9 min 49 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 476 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/476/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Dec 2016 09:14:20 + Build duration: 9 min 49 sec CHANGE SET No changes JUNIT RESULTS Name

Re: KaOS locale KCM (KDE 4 vs 5, regional settings and dolphin)

On woensdag 7 december 2016 16:04:05 CET René J. V. Bertin wrote: > René J. V. Bertin wrote: > > I just played with a full Plasma5 desktop (KaOS) and noticed that it has a > > Regional Settings/Locale KCM I don't have on my own install, for as yet > > unclear reasons. It seems it gives an additiona

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

elvisangelaccio added a comment. So it seems that moving `desktop://` creates more problems than it solves. Maybe we should leave it in plasma? That would also solve the co-installability problem. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kd

[Differential] [Accepted] D3582: [Task Manager] Honor activateTaskManagerEntry by plasmashell

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3582 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, hein Cc: plasma-devel

[Differential] [Accepted] D3581: [PlasmaShell] Introduce activateTaskManagerEntry(index) method

mart accepted this revision. mart added a reviewer: mart. mart added a comment. not pretty for sure, but unfortunately i don't see much ways to avoid this, so go for it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3581 EMAIL PREFERENCES https://phabric

[Differential] [Commented On] D3605: Revert "Do not ask for root permissions when it's unnecessary"

sitter added a comment. In https://phabricator.kde.org/D3605#67912, @davidedmundson wrote: > You've already done all the research which is 90% of the work, and now it's "just" a case of making sure m_infoToSave is always set for new users right? As I've mentioned I think this has

[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

mart added a comment. yes, if you are comparing with an item height, it should stay in pixelSize REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, mart

[Differential] [Commented On] D3598: rework kscreen's OSD logic

sebas added a comment. Correct, that's the idea. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D3598 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: mart, graesslin, broulik, plasma-devel, davidedmundson, lesl

[Differential] [Request, 2 lines] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

franckarrecot created this revision. franckarrecot added a reviewer: mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The point is that a project embedding kirigami as submodule would have CMAKE_SOURCE_DIR wrong i

Minutes Monday Plasma Meeting

Plasma Meeting minutes 12-12-2016 Present: Sho, kbroulik, romangg, bshah, notmart, d_ed, sebas Logo discussion: - We want to finalize this topic (finally), notmart to check with mgraesslin Sho: * [Kicker] Fixed recent documents action in the context menus for app item search results not launch

[Differential] [Accepted] D3606: Listen for broadcast notifications on system bus

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. kbroulik: kde-cli-tools? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3606 EMAIL PREFE

[Differential] [Request, 2 lines] D3650: lower mouse acceleration limit to 0.0

sitter created this revision. sitter added a reviewer: plasma-devel. sitter added a subscriber: jensreuterberg. Restricted Application added a project: Plasma. REVISION SUMMARY as seen in bug 95928 this used to be locked at 1 but was lowered to 0.1 as acceleration != speed, so <1 makes perfect

[Differential] [Closed] D3589: Add a notication service to inhibit certain notifications based on metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7f7d22984397: Add a notication service to inhibit certain notifications based on metadata (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricat

[Differential] [Closed] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

This revision was automatically updated to reflect the committed changes. Closed by commit R114:a08ef2ea5a93: Add Plasmoid that shows multiple other plasmoids in a tabbed interface (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Closed] D3605: Revert "Do not ask for root permissions when it's unnecessary"

This revision was automatically updated to reflect the committed changes. Closed by commit R128:f2c69db182fb: Revert "Do not ask for root permissions when it's unnecessary" (authored by sitter). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3605?vs=8801&

[Differential] [Closed] D3606: Listen for broadcast notifications on system bus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dcf8e3dca547: Listen for broadcast notifications on system bus (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3606?vs=8854&id=8943#toc REPOSITORY R120 Plasma Workspace

[Differential] [Request, 121 lines] D3651: Add utility to send broadcast notifications

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R126 KDE CLI Utilities. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds a command-line utility kbro

[Differential] [Closed] D3616: [Lock Screen / Login] Add "reveal password button"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2f9bfbc5e153: [Lock Screen / Login] Add "reveal password button" (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3616?vs=8841&id=8947

Review Request 129642: Introduce org.kde.kconfig QML import with KAuthorized

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129642/ --- Review request for KDE Frameworks, Plasma and Dan Leinir Turthra Jensen.

[Technical Question] - Where is CompactRepresentation's popup placement code?

Hello everyone, Do you know where to find the popup placement code for the CompactRepresentation? I use in my dock a transparent panel with masking techniques, that has as a consequence many times the popups from compactRepresentation applets to be placed far from the element that triggered

[Differential] [Request, 12 lines] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This introduces a new lineedit_reveal

[Differential] [Updated] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

broulik updated the test plan for this revision. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3654 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterber

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

broulik added a comment. I think KWin's Wayland input mapping logic needs to be adjusted then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: b

[Differential] [Closed] D3581: [PlasmaShell] Introduce activateTaskManagerEntry(index) method

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea4579f312c6: [PlasmaShell] Introduce activateTaskManagerEntry(index) method (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3581?vs=

[Differential] [Closed] D3582: [Task Manager] Honor activateTaskManagerEntry by plasmashell

This revision was automatically updated to reflect the committed changes. Closed by commit R119:008099974805: [Task Manager] Honor activateTaskManagerEntry by plasmashell (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3582?vs=8730

[Differential] [Changed Subscribers] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:16 > > -qt5_add_resources(RESOURCES ${CMAKE_SOURCE_DIR}/kirigami.qrc) > +qt5_add_resources(RESOURCES ${CMAKE_CURRENT_SOURCE_DIR}/../kirigami.qrc) > Sounds like `${kirigami_SOURCE_DIR}/kirigami.qrc` would be best. I don't really un

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

sitter added a comment. Possibly. The KCM does not appear to actually work on wayland though ^^ if (!QX11Info::isPlatformX11()) { return; REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/s

[Differential] [Request, 301 lines] D3655: Kicker backend changes for Simple Menu.

hein created this revision. hein added reviewers: Plasma, mart. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This does two changes needed to support the Simple Menu UI: - Support for pagination with configurable page size and relate

[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

hein added a comment. Note: There seems to be unrelated borkage in master. Kicker-based UIs don't apply plasmoid XML default config correctly on applet instanciation now. It only works intermittently, as if it's some sort of new race condition. This happens with and without this change. REP

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

graesslin added a comment. In https://phabricator.kde.org/D3650#68360, @sitter wrote: > Possibly. > > The KCM does not appear to actually work on wayland though ^^ It does. I ported it and it works and adjusts the settings for Wayland if KWin is used. REPOSITORY R119 Plasma

[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

broulik added a comment. some minor minor nitpicks, +1 from me though INLINE COMMENTS > rootmodel.cpp:281 > > -foreach (const AbstractEntry *groupEntry, m_entryList) { > -AbstractModel *model = groupEntry->childModel(); > +for (int i = 0; i < subModel

[Differential] [Commented On] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

franckarrecot added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:16 > Sounds like `${kirigami_SOURCE_DIR}/kirigami.qrc` would be best. I don't > really understand the `..` you added though. Well my main problem is when embedding kirigami as submodule in my cmake project, CMA

[Differential] [Commented On] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

franckarrecot added a comment. " CMAKE_SOURCE_DIR is pointing to my top level source dir, not kirigami' one, " > so : qt5_add_resources(RESOURCES ${CMAKE_SOURCE_DIR}/kirigami.qrc) would refer to an incorrect path and then make cmake fails at config time, for any projecting embedding kir

[Differential] [Commented On] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

franckarrecot added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:16 > Sounds like `${kirigami_SOURCE_DIR}/kirigami.qrc` would be best. I don't > really understand the `..` you added though. In my case kirigami_SOURCE_DIR points to /MyProject/3rdparty/kirigami/src and not kir

[plasmashell] [Bug 191394] add "minimize all" action to window list plasmoid

https://bugs.kde.org/show_bug.cgi?id=191394 Christoph Feck changed: What|Removed |Added Target Milestone|--- |1.0 Component|widget-windowlist

[Differential] [Updated, 302 lines] D3655: Kicker backend changes for Simple Menu.

hein updated this revision to Diff 8955. hein added a comment. Address Kai's review comments. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3655?vs=8952&id=8955 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3655 AFFECTED FILES

[Differential] [Accepted] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Right, of course. that makes sense. With `CMAKE_CURRENT_SOURCE_DIR` should be fine. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3649

[Differential] [Request, 122 lines] D3658: Set Automatic login flag to adjust SDDM config directly

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY AccountsService is a bit weird, the automatic login flag adjusts a config file in /etc/gdm/

[Differential] [Request, 0 lines] D3660: Plasma 5.9 "Canopee" Wallpaper

kvermette created this revision. kvermette added a reviewer: Plasma. kvermette set the repository for this revision to R119 Plasma Desktop. kvermette added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY New wallpaper for Plasma 5.9, called "Canopee"

[Differential] [Commented On] D3660: Plasma 5.9 "Canopee" Wallpaper

broulik added a comment. Overall I quite like it, especially the stylized 9 referencing Plasma 5.9 (not sure if that was fully intentional, though? ;) The blurry jaggy, coronal mass ejection like edges of the yellow band, look weird. F708275: Screenshot_20161213_081935.png