[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten added a comment. This is what happens with a QFormLayout with fieldGrowthPolicy=ExpandingFieldsGrow and fields' sizePolicy=MinimumExpanding/Fixed. The effect is not good - it moves the spin box controls a long way away. Shall I stick with the grid layout? F349555: mouse-kcmshel

Re: Review Request 129078: Don't load containment actions for embedded containments (system trays)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129078/#review99727 --- Ship it! Ship It! - Marco Martin On Sept. 30, 2016, 11:

[Differential] [Accepted] D2910: don't block startkde sending DBus call to KSplash

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2910 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Changed Subscribers] D2913: Make the background of the logout screen darker

mart added inline comments. INLINE COMMENTS > Logout.qml:61 > > +Rectangle { > +color: PlasmaCore.ColorScope.backgroundColor making the background darker makes sense. But you already have a translucent black Rectangle at line 83, no need to add another one, just tweak opacity of t

[Differential] [Commented On] D2914: folderview: port the context menu away from KonqPopupMenu.

mart added a comment. +1 killing the copy of libkonq would be sweet, yes REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2914 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, broulik, hein Cc: mart, plas

[Differential] [Closed] D2910: don't block startkde sending DBus call to KSplash

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE4c403bd66a4e: don't block startkde sending DBus call to KSplash (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

davidedmundson added a comment. Weird, with your patch I get F350007: Spectacle.Vm2529.png which looks spot on. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2853 EMAIL PREFERENCES https://phabricator.kde.or

[Differential] [Closed] D2875: index.model()->data(... -> index.data(index,..

davidedmundson closed this revision. davidedmundson added a comment. was merged as https://phabricator.kde.org/rSDDMKCM21b29371ae673e0411dc0a5a1c57799d51217283 REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D2875 EMAIL PREFERENCES https:

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129086/#review99728 --- Ship it! very good point - Marco Martin On Oct. 3, 2016

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

mart added a comment. In https://phabricator.kde.org/D2853#54136, @davidedmundson wrote: > Weird, with your patch I get F350007: Spectacle.Vm2529.png which looks spot on. latest version (that uses a grid) or formlayout version with hints chang

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

davidedmundson added a comment. Urgh, I got confused. I assumed had Marten had uploaded a patch when he uploaded a screenshot. Well deduced :) @marten can you upload your form based patch that looks wrong and I'll take a look. I think you just need to wrap it in a hboxlayout with the

Re: Review Request 129078: Don't load containment actions for embedded containments (system trays)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129078/ --- (Updated Oct. 3, 2016, 10:45 a.m.) Status -- This change has been ma

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129086/ --- (Updated Oct. 3, 2016, 10:45 a.m.) Status -- This change has been ma

[Differential] [Updated, 6 lines] D2877: Use Plasma::PluginLoader to list applets

davidedmundson updated this revision to Diff 7048. davidedmundson added a comment. fixup REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2877?vs=6965&id=7048 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2877 AFFECTED

[Differential] [Updated, 126 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten updated this revision to Diff 7049. marten added a comment. Apologies for the confusion... this patch corresponds to the last screen shot, with ExpandingFieldsGrow and MinimumExpanding (currently only for the "Advanced" tab). Adding an outer layout with a stretch to the right seem

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

andreaska added a comment. thanks @marten for this update. If you are interested into some system setting changes let me know. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2853 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Updated, 170 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten updated this revision to Diff 7051. marten added a comment. Using a form layout wrapped in an outer layout with stretch added to the right. Gives the intended effect, with all spin boxes the same size and lining up on both tabs. The boxes for the "Keyboard Navigation" tab are wider t

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

mart added a comment. looks fine here with latest version of the patch F350250: dadel5.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2853 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

Minutes Monday Plasma Meeting

Attached are minutes and log. Plasma Meeting 3rd October, 2016, 12:00, via IRC present: notmart, bshah, llucas, d_ed, Riddell, sebas notmart: * simplified krunner: config baed upon plugins again, categories based was brittle and based on locale, lots of code killed (purely ui, backend still s

Re: Minutes Monday Plasma Meeting

On Mon, Oct 3, 2016 at 2:00 PM, Sebastian Kügler wrote: > Attached are minutes and log. > > Plasma Meeting 3rd October, 2016, 12:00, via IRC > > present: notmart, bshah, llucas, d_ed, Riddell, sebas > > > notmart: > * simplified krunner: config baed upon plugins again, categories based was > britt

[Differential] [Request, 2 lines] D2918: Use Item property that exists

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QQuickItem has a size method but no size property. This was currently giving a warning and do

[Differential] [Request, 2 lines] D2919: Image has width and height properties, not "size"

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this makes it actually do what it was intended to, set the source size to the actual thumbnail size to keep a sca

[Differential] [Accepted] D2919: Image has width and height properties, not "size"

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH phab/actthumbnail REVISION DETAIL https://phabricator.kde.org/D2919 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

[Differential] [Abandoned] D2918: Use Item property that exists

davidedmundson abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2918 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreut

[Differential] [Changed Subscribers] D2919: Image has width and height properties, not "size"

apol added inline comments. INLINE COMMENTS > ActivityItem.qml:77 > source: "image://wallpaperthumbnail/" + background > -sourceSize: size > +sourceSize: Qt.size(width, height) > } Won't this mess with the image's aspect relation? REPOSITORY rPLAS

[Breeze] [Bug 369676] New: White lockscreen text's readability depends on background

https://bugs.kde.org/show_bug.cgi?id=369676 Bug ID: 369676 Summary: White lockscreen text's readability depends on background Product: Breeze Version: 5.8.0 Platform: Other OS: Linux Status: UNCO

[Differential] [Commented On] D2919: Image has width and height properties, not "size"

broulik added a comment. Make sure the image item doesn't change its size erroneously upon opening it as changing source size will cause the image to be reloaded from disk REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH phab/actthumbnail REVISION DETAIL https://phabricator.kde.org/D29

[Differential] [Commented On] D2919: Image has width and height properties, not "size"

mart added a comment. In https://phabricator.kde.org/D2919#54183, @broulik wrote: > Make sure the image item doesn't change its size erroneously upon opening it as changing source size will cause the image to be reloaded from disk there is one single widthchanged/heightchanged at

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

davidedmundson added a comment. Ship it! I can't click approve again apparently. I really appreciate that you put in the extra time finding the neatest solution. Good stuff. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2853 EMAIL PREFER

[Differential] [Accepted] D2919: Image has width and height properties, not "size"

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. INLINE COMMENTS > apol wrote in ActivityItem.qml:77 > Won't this mess with the image's aspect relation? Not by itself, this is just pure metadata sent to the image provid

[Differential] [Accepted] D2853: Mouse KCM: Align spin boxes, port to Qt5

mart accepted this revision. mart added a reviewer: mart. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2853 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, davidedmundson, #plasma, mart Cc: andreaska, mart

[Differential] [Closed] D2919: Image has width and height properties, not "size"

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP7cbcf46b332e: Image has width and height properties, not "size" (authored by mart). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2919?vs

[Differential] [Closed] D2853: Mouse KCM: Align spin boxes, port to Qt5

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP8bee1a78b04a: Mouse KCM: Align spin boxes, port to Qt5 (authored by marten). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2853?vs=7051&i

[Differential] [Updated, 2 lines] D2913: Make the background of the logout screen darker

jsalatas updated the test plan for this revision. jsalatas updated this revision to Diff 7058. jsalatas added a comment. According to mart's suggestion there is already a rectangle, so there is no need to add a new one (the "after" screenshot is also updated to reflect this) REPOSITORY rPLA

[Powerdevil] [Bug 365281] ksystemsettings5 powerdevilprofilesconfig module doesn't fit to height in standalone

https://bugs.kde.org/show_bug.cgi?id=365281 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at Status|UNCONFIRMED

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

https://bugs.kde.org/show_bug.cgi?id=366299 Wolfgang Bauer changed: What|Removed |Added CC||housegregory...@gmail.com --- Comment #2 from

[Differential] [Request, 9 lines] D2922: [Digital Clock] Silence warning

broulik created this revision. broulik added reviewers: Plasma, eliasp. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 369734 FIXE

Review Request 129091: Add icons for Fcitx

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Accepted] D2922: [Digital Clock] Silence warning

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2922 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Plasma Workspace Wallpapers] [Bug 365761] Get Hot New Stuff for Wallpaper not working

https://bugs.kde.org/show_bug.cgi?id=365761 --- Comment #5 from p...@alicious.com --- I have the same issue -- no response beyond "some categories not available" from the Get Hot New Stuff dialog for "Get New Wallpapers". Re Thomas Pfeiffer's comment in #4 though I have (via "sudo apt list plasma

[Plasma Workspace Wallpapers] [Bug 365761] Get Hot New Stuff for Wallpaper not working

https://bugs.kde.org/show_bug.cgi?id=365761 p...@alicious.com changed: What|Removed |Added CC||p...@alicious.com --- Comment #6 from p...@a

Re: Review Request 129007: Update windowspecific (Window Rules) docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129007/#review99750 --- Ship it! Ship It! - Martin Gräßlin On Sept. 23, 2016, 9

[Differential] [Reopened] D2882: Don't load QPT in kcminit

graesslin reopened this revision. graesslin added a comment. This revision is now accepted and ready to land. Reopening due to @broulik's comment. This clearly must be called before creating the QGuiApplication as the ctor of QGuiApplication creates the QPT plugin. REPOSITORY rPLASMAWORKSP

[Differential] [Closed] D2882: Don't load QPT in kcminit

broulik closed this revision. broulik added a comment. https://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=efa3e0ba0fe4a10c4015576689385365c532e124 :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2882 EMAIL PREFERENCES https://phab