Re: Fwd: Cron ~/bin/update_kf5.sh

On Mon, Sep 19, 2016 at 4:11 PM, Jonathan Riddell wrote: > It should be moved out of kde/workspace anyway, would playground/mobile make > sense? It's unmaintained as far as I know I will file request to move it to playground/mobile, where it should be.. I am not sure of the reasons why it was m

Re: RFC: plasma-framework IndicatorArea formFactor()

On Mon, Sep 19, 2016 at 8:37 PM, David Edmundson wrote: > applet->pluginInfo().pluginName()) { > -applet->destroy(); > +QMetaObject::invokeMethod(applet, "cleanUpAndDelete"); > > (in all 3 cases) > > But it's equally messy, and has an issue that transient won't get set, so

Re: New shapes and colors for Breeze mime-types icons

Il 19 settembre 2016 19:22:01 CEST, Marco Martin ha scritto: >On Mon, Sep 19, 2016 at 10:56 AM, kainz.a wrote: >> Different shapes = different contend >> Different colors = different file types > >I find the reasoning convincing. >Maybe will still need some fixes after being widely tested in the

[Differential] [Request, 24 lines] D2817: better bookeeping of the config

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY be able to destroy applets even when locked: delete their config by hand. Except in one case: when the applet gets automatically destroyed b

[Differential] [Updated] D2817: better bookeeping of the config

mart updated the test plan for this revision. mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2817 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, le

[Differential] [Changed Subscribers] D2817: better bookeeping of the config

sebas added inline comments. INLINE COMMENTS > systemtray.cpp:139 > +Applet *applet = Plasma::PluginLoader::self()->loadApplet(task, > m_knownPlugins.value(task), QVariantList()); > +applet->setProperty("org.kde.plasma:force-create", true); > +addApplet(applet); I think

[Differential] [Changed Subscribers] D2817: better bookeeping of the config

davidedmundson added inline comments. INLINE COMMENTS > systemtray.cpp:136 > > -createApplet(task, QVariantList() << "org.kde.plasma:force-create"); > +//known one, recycle the id to reuse old config > +if (m_knownPlugins.contains(task)) { Is this for the DBus activated case? > sy

[Differential] [Commented On] D2817: better bookeeping of the config

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in systemtray.cpp:381 > C++ applets can override cleanupAndDelete > > You're skipping that. > (not that any do) Edit. I was wrong, it is virtual, but private within p-f. Ignore this. REPOSITORY rPLASMAWORKSPACE Pla

[Differential] [Commented On] D2817: better bookeeping of the config

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in systemtray.cpp:136 > Is this for the DBus activated case? not only, actually this case is true for each startup after the first, during normal config restore. This is the branch always executed except when a previously unkno

[Differential] [Commented On] D2817: better bookeeping of the config

mart added inline comments. INLINE COMMENTS > mart wrote in systemtray.cpp:154 > don't know how to properly fix it without changes in p-f tough ( i could > still call destroy() in case of mutable, tough when an applet goes away for > dbus reasons, its config should actually not be removed (so s

[Breeze] [Bug 352510] Wifi Icons (Airplane Mode, Wifi) Doesn't display sometimes in network menu in menu bar

https://bugs.kde.org/show_bug.cgi?id=352510 pinheiro changed: What|Removed |Added CC||past...@gmail.com --- Comment #6 from pinheiro ---

[Differential] [Commented On] D2817: better bookeeping of the config

mart added a comment. or could (ouch)manually emit applet::appletDeleted() from the outside that's yeah, horrible but would immediately remove the applet from applets().. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2817 EMAIL PREFERENCES h

Review Request 128955: Minor optimisation/cleanup in scripengine loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128955/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

> On Sept. 19, 2016, 9:52 p.m., Marco Martin wrote: > > shell/scripting/panel.cpp, line 189 > > > > > > this can't rely on the order of qGuiApp->screens, but should use > > screenpool in shellcorona, it's the on

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 349 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/349/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 20 Sep 2016 10:16:52 + Build duration: 18 min CHANGE SET Revision 358be49018990db9e274bd27b89cdf9ad64e

[Differential] [Commented On] D2817: better bookeeping of the config

davidedmundson added a comment. In https://phabricator.kde.org/D2817#52467, @mart wrote: > or could (ouch)manually emit applet::appletDeleted() from the outside that's yeah, horrible but would immediately remove the applet from applets().. Looks like it would work. REPOSITORY r

[Differential] [Updated, 34 lines] D2817: better bookeeping of the config

mart updated this revision to Diff 6826. mart added a comment. - address issues REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2817?vs=6825&id=6826 BRANCH phab/cleansystray REVISION DETAIL https://phabricator.kde.org/D2817 AFFECT

Review Request 128957: Make KF5Baloo optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128957/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 128956: Make KF5Baloo optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128956/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: RFC: plasma-framework IndicatorArea formFactor()

On Mon, Sep 19, 2016 at 9:16 PM, Marco Martin wrote: > On Mon, Sep 19, 2016 at 8:37 PM, David Edmundson > wrote: > >> perhaps you are right, semantically they are two things, not sure what > >> could be used instead more "proper"(suggestions welcome), will think > >> more about it. > > > > > > L

Re: Review Request 128956: Make KF5Baloo optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128956/#review99316 --- >Usage of krunner without any segfaults. You can just disabl

[Differential] [Commented On] D2817: better bookeeping of the config

mart added inline comments. INLINE COMMENTS > mart wrote in systemtray.cpp:154 > instead of applet->destroyed() i could connect to its destroyed signal and > keep a list of deleteLater()ed applets... restarting Networkmanager seems to cause the applet to reload correctly REPOSITORY rPLASMAWO

[Differential] [Commented On] D2817: better bookeeping of the config

mart added inline comments. INLINE COMMENTS > mart wrote in systemtray.cpp:154 > restarting Networkmanager seems to cause the applet to reload correctly hm, in that case still seems to create a spurious duplicate config group tough REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

Re: Review Request 128956: Make KF5Baloo optional

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. That's not quite true; even with runtime-disabled baloo there have bee

Re: Review Request 128956: Make KF5Baloo optional

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. > > Andreas Sturmlechner wrote: > That's not quite true; even with

[Differential] [Updated, 37 lines] D2817: better bookeeping of the config

mart updated this revision to Diff 6827. mart added a comment. - update knownplugins when creating a new applet REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2817?vs=6826&id=6827 BRANCH arcpatch-D2817 REVISION DETAIL https://phab

[Differential] [Commented On] D2817: better bookeeping of the config

mart added a comment. in the latest version restarting networkmanager fully works as expected: it gets restarted and its old config group gets used REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2817 EMAIL PREFERENCES https://phabricator.kde.

Re: Review Request 128956: Make KF5Baloo optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128956/#review99320 --- -1, would mean one code path/build config option to maintain

Re: RFC: plasma-framework IndicatorArea formFactor()

On Tue, Sep 20, 2016 at 2:05 PM, David Edmundson wrote: > > Actually adding a virtual is, but the design pattern of a virtual is do-able > in multiple other ways which are binary compatiable. > *if* that's the approach we want (and it's my preferred option) I'll make a > RR that does it. I know a

Review Request 128959: Fix Plasma::knownLanguages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128959/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 128956: Make KF5Baloo optional

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. > > Andreas Sturmlechner wrote: > That's not quite true; even with

Re: Review Request 128959: Fix Plasma::knownLanguages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128959/#review99323 --- Ship it! Ship It! - Marco Martin On Sept. 20, 2016, 12:

Re: RFC: plasma-framework IndicatorArea formFactor()

On Tue, Sep 20, 2016 at 1:32 PM, Marco Martin wrote: > On Tue, Sep 20, 2016 at 2:05 PM, David Edmundson > wrote: > > > > Actually adding a virtual is, but the design pattern of a virtual is > do-able > > in multiple other ways which are binary compatiable. > > *if* that's the approach we want (a

Re: RFC: plasma-framework IndicatorArea formFactor()

On Tue, Sep 20, 2016 at 2:42 PM, David Edmundson wrote: > > then we change our Q_PROPERTY in Plasma::Applet to go to a real > implementation > > system tray containment can then also implements the property. nnnuuuh :/ > Another possible technique is we export a new class which inherts Applet, >

Re: Review Request 128955: Minor optimisation/cleanup in scripengine loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128955/#review99326 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 20, 201

Re: Review Request 128956: Make KF5Baloo optional

> On Sept. 20, 2016, 12:29 p.m., Marco Martin wrote: > > -1, would mean one code path/build config option to maintain for us I would understand if Plasma did much more with Baloo. But I don't see that right now, it enables two rather isolated modules. While the config option can be revoked any

[Differential] [Accepted] D2817: better bookeeping of the config

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. Ideally maybe split the m_knownTasks loading and the deletion changes into two commits, they're not entirely related REPOSIT

[Differential] [Closed] D2817: better bookeeping of the config

mart closed this revision. mart added a comment. merged in 2 separate commits REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2817 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, davidedmundson

[Differential] [Request, 6 lines] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

broulik created this revision. broulik added reviewers: Plasma, sitter. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It does X calls and mig

Re: Review Request 128959: Fix Plasma::knownLanguages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128959/ --- (Updated Sept. 20, 2016, 1:32 p.m.) Status -- This change has been m

Re: Review Request 128955: Minor optimisation/cleanup in scripengine loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128955/ --- (Updated Sept. 20, 2016, 6:32 p.m.) Status -- This change has been m

Re: Review Request 128956: Make KF5Baloo optional

> On Sept. 20, 2016, 12:29 p.m., Marco Martin wrote: > > -1, would mean one code path/build config option to maintain for us > > Andreas Sturmlechner wrote: > I would understand if Plasma did much more with Baloo. But I don't see > that right now, it enables two rather isolated modules. Whi

[plasmashell] [Bug 328593] Dual screen has regressed in plasma-shell

https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 344076, which changed state. Bug 344076 Summary: Panels appear on top of each other when switching back to single-monitor https://bugs.kde.org/show_bug.cgi?id=344076 What|Removed |Added -

[Differential] [Closed] D2810: Fixed loading of the wallpapers in the activity switcher

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP947f430e6059: Fixed loading of the wallpapers in the activity switcher (authored by ivan). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

[Differential] [Commented On] D2810: Fixed loading of the wallpapers in the activity switcher

ivan added inline comments. INLINE COMMENTS > mart wrote in switcherbackend.cpp:156 > could this have the implementation after the class definition, just for > immediate readability? Strange preference, but ok :) > davidedmundson wrote in switcherbackend.cpp:181 > why not ScaledAndCached? sav

[Differential] [Updated, 221 lines] D2810: Fixed loading of the wallpapers in the activity switcher

ivan updated this revision to Diff 6830. ivan added a comment. Fixed complaints REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2810?vs=6802&id=6830 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2810 AFFECTED FILES

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/ --- (Updated Sept. 20, 2016, 2:25 p.m.) Review request for Plasma. Changes

[Differential] [Closed] D2747: Don't list raw containments in panels menu

davidedmundson closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2747 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, j

Re: Review Request 128956: Make KF5Baloo optional

> On Sept. 20, 2016, 3:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. > > Andreas Sturmlechner wrote: > That's not quite true; even with

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 7 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 20 Sep 2016 12:52:29 + Build duration: 36 min CHANGE SET Revision 675803316aeb614eb410c37c10b

[Differential] [Request, 42 lines] D2820: Updating the wallpaper cache only when the configuration file settles

ivan created this revision. ivan added reviewers: Plasma, davidedmundson, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The file changed even can happen often, we should wait a bit before reacting. REPOSITORY

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 350 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/350/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 20 Sep 2016 14:23:53 + Build duration: 30 min CHANGE SET Revision 675803316aeb614eb410c37c10b0123db525

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 20 Sep 2016 14:47:49 + Build duration: 32 min CHANGE SET Revision 947f430e6059426904e7744b7d5

Re: Review Request 128948: Update shortcuts kcm docbook

> On Sept. 19, 2016, 9:21 nachm., Marco Martin wrote: > > doc/kcontrol/keys/index.docbook, line 137 > > > > > > that part of loading/saving custom config schemes, even if isn't really > > something that should b

Re: Review Request 128948: Update shortcuts kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128948/ --- (Updated Sept. 20, 2016, 5:26 nachm.) Review request for Documentation an

Re: Review Request 128947: Update screenlocker docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128947/ --- (Updated Sept. 20, 2016, 6:54 p.m.) Status -- This change has been m

[Differential] [Request, 25 lines] D2823: [Device Notifier] Only ever pop up if device is visible in the list

broulik created this revision. broulik added reviewers: Plasma, sitter. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When a device noti

[Differential] [Accepted] D2823: [Device Notifier] Only ever pop up if device is visible in the list

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2823 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

NM-Qt: tens of blocking DBus calls for every nm device

Hi networkmanagerers, plasmers, I have been looking into what kind of things happen between the plasma shell is booted and actually starts. An obvious way to check where we're blocking, is by seeing who is making blocking dbus calls. Adding a breakpoint to whenever there's a blocking dbus call goes

[Powerdevil] [Bug 369129] New: Powerdevil does not provide a way to inhibit screen saving

https://bugs.kde.org/show_bug.cgi?id=369129 Bug ID: 369129 Summary: Powerdevil does not provide a way to inhibit screen saving Product: Powerdevil Version: 5.7.3 Platform: Other OS: other Status:

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

https://bugs.kde.org/show_bug.cgi?id=369129 --- Comment #1 from Manuel Amador (Rudd-O) --- The relevant PA thread is this one: https://lists.freedesktop.org/archives/pulseaudio-discuss/2016-September/026910.html -- You are receiving this mail because: You are the assignee for the bug.

Review Request 128965: Update color kcm docbook to 5.8

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128965/ --- Review request for Documentation, Plasma and Olivier Churlaud. Repository

Review Request 128966: Don't include kdeglobals when dealing with a cache config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128966/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

https://bugs.kde.org/show_bug.cgi?id=369129 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de Status|UNC

Re: NM-Qt: tens of blocking DBus calls for every nm device

Hi, I'm aware that we do this. Give me few days to fix this in all NMQT classes, like we do in Manager class. Regards, Jan -- Jan Grulich Software Engineer, Desktop team Red Hat Czech On středa 21. září 2016 1:46:29 CEST Aleix Pol wrote: > Hi networkmanagerers, plasmers, > I have been looking