graesslin accepted this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision is now accepted and ready to land.
The logic seems correct to me.
REPOSITORY
rLIBKSCREEN KScreen Library
BRANCH
sebas/positionnormalization
REVISION DETAIL
https://phabrica
Am 18.08.2016 um 17:52 schrieb Marco Martin:
> On Tuesday 16 August 2016 20:23:45 Martin Gysel wrote:
>> Hi
>> Here are some patches I have in my branch.
>> It contains a script to (re)generate the qml file, one the generate a
>> resource file with possibly used icons and one to generaste a qmltype
On Thursday 18 August 2016 22:07:08 Dirk Hohndel wrote:
> From fb2d355d00011f7ff9a0a7ea69ea93ecc36a5486 Mon Sep 17 00:00:00 2001
> From: Dirk Hohndel
> Date: Thu, 18 Aug 2016 22:05:25 -0700
> Subject: [PATCH] Remove reference to Icon.qml under desktop style
thanks, pushed
--
Marco Martin
bearsh created this revision.
bearsh added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
add simple script to generate a qrc containing all qml files
add script to find possible used icons in kir
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEc22f0ce63e64: remove dead code (authored by
mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2345?vs=6043&id=6058#toc
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SI
> On Aug. 19, 2016, 8:23 a.m., Martin Gräßlin wrote:
> > I'm not happy with the QWebEngineView as that's going to crash on Wayland.
> > Every application using QWebEngine needs to be on xcb unfortunately. So
> > that means that we cannot really use anything of QWebEngine in Plasma
> > (which i
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPda07e3f66345: use dbus interface to switch shell
l&f (authored by mart).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2448?vs=6038&id=60
Am 19.08.2016 um 03:24 schrieb Aleix Pol:
> Can you please upload the patches to phabricator.kde.org or
> reviewboard.kde.org?
>
done
> Thanks!
> Aleix
>
> On Tue, Aug 16, 2016 at 8:23 PM, Martin Gysel wrote:
>> ---
>> scripts/gen_qml_qrc.sh | 39 +++
>> 1
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMASDKa3d6dff738d2: small utility to create L&F packages
(authored by mart).
REPOSITORY
rPLASMASDK Plasma SDK
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2449?vs=5983&id=6060
REVISION D
> On Aug. 19, 2016, 8:23 a.m., Martin Gräßlin wrote:
> > I'm not happy with the QWebEngineView as that's going to crash on Wayland.
> > Every application using QWebEngine needs to be on xcb unfortunately. So
> > that means that we cannot really use anything of QWebEngine in Plasma
> > (which i
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This would eventually all
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2495
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/email
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP3b212cb8094f: [Desktop Containment] Animate
margin changes due to available screen rect (authored by broulik).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://p
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP6fbb178f03a6: [Containment Actions
Configuration] Add labels for Back / Forward mouse buttons (authored by
broulik).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP84c9b27b9784: [Desktop Toolbox] Animate position
change (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2490?vs=6046&id=6063#toc
REPOSITORY
rPLASMADESKTOP Plas
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPb26c6ed1ef92: [Kickoff] Mirror breadcrumb arrow
in right-to-left layout (authored by broulik).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP50dc4358753f: [Panel Containment] Cleanup
(authored by broulik).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2492?vs=6048&id=6066
REVI
mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:7
> +include_directories(../../)
> +set (kwinrules_MOC_HDRS yesnobox.h ../../client_machine.h ../../cursor.h
> ../../plugins/pla
graesslin added inline comments.
INLINE COMMENTS
> mart wrote in CMakeLists.txt:7
> is ../../ needed for those paths if there is already
> include_directories(../../) ?
I tried without, but it didn't pick it up. This whole thing is weird and needs
to somehow be reworked.
REPOSITORY
rKWIN KW
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN2a8ab547e186: Move X11Cursor into the x11standalone
platform plugin (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2473?vs=6009&id=6068#toc
REPOSITORY
rKWIN KWin
CH
davidedmundson abandoned this revision.
davidedmundson added a comment.
I merged this a while ago. Closing.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2240
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dav
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPe202289ea3d7: Supress QML warning (authored by
davidedmundson).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2495?vs=6053&id=6069
REVIS
mart added a comment.
> the propertieschanged signal doesn't seem to be emitted :/
so us this working or not? what is the problem?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2499
EMAIL PREFERENCES
https://phabricator.kde.org/settings/
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2481
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sitter
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rKIRIGAMI Kirigami
BRANCH
bearsh
REVISION DETAIL
https://phabricator.kde.org/D2498
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bearsh, mart
Cc: plasma-devel
bshah accepted this revision.
bshah added a reviewer: bshah.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2481
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sitter, davidedmundson, bshah
Cc:
bshah added a subscriber: plasma-devel.
REPOSITORY
rUSERMANAGER User Manager
REVISION DETAIL
https://phabricator.kde.org/D2494
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE40e5ffbb357b: install new header (authored by
sitter).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2481?vs=6027&id=6070
REVISION
bshah added a subscriber: plasma-devel.
REPOSITORY
rUSERMANAGER User Manager
REVISION DETAIL
https://phabricator.kde.org/D2493
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rUSERMANAGER User Manager
REVISION DETAIL
https://phabricator.kde.org/D2493
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmunds
colomar added a comment.
Can you please provide screenshots of the tool? Yes, even developer-centric
tools should get a UI review ;)
REPOSITORY
rPLASMASDK Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D2449
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpre
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rUSERMANAGER User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2494
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
mart added a comment.
http://imgur.com/a/jAKSv
REPOSITORY
rPLASMASDK Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D2449
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, davidedmundson, #plasma
Cc: colomar, davidedmundson, plasma-devel,
mart added a comment.
the patch is ok for me.
can you go forward with the devel account/submission process?
REPOSITORY
rKIRIGAMI Kirigami
BRANCH
bearsh
REVISION DETAIL
https://phabricator.kde.org/D2498
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
broulik abandoned this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2499
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterbe
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This ensures the desktop
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Action button now word wraps at grid unit * 4
but will expand to fit the largest word in tha
colomar added a comment.
Thanks!
Feedback:
- The lineedits should be made long enough to actually hold the whole content
(for the comment, maybe a textbox would be better?), because editing in a field
which is too small for the content is really annoying.
- How does one save changes?
mart added a comment.
In https://phabricator.kde.org/D2449#46735, @colomar wrote:
> Thanks!
> Feedback:
>
> - The lineedits should be made long enough to actually hold the whole
content (for the comment, maybe a textbox would be better?), because editing in
a field which is too sma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/#review98496
---
Ship it!
Honoured to oblige. :)
- Sebastian Kügler
On A
This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREENf04d6d3c3c8a: [kded] correctly restore lidOpened
configuration on startup (authored by sebas).
REPOSITORY
rKSCREEN KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2465?vs=6024&id
This revision was automatically updated to reflect the committed changes.
Closed by commit rLIBKSCREEN90d8ee283f88: normalize output positions in
setoperation (authored by sebas).
REPOSITORY
rLIBKSCREEN KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2496?vs=6054&id=60
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/#review98497
---
Ship it!
Go go go ;)
- Kai Uwe Broulik
On Aug. 18, 2016
mart added a comment.
better, tough, i guess wether would be possible for this line of buttons to
out all buttons at the same space (so using the size of the biggest one)
without ending up in horrible binding loops
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://pha
davidedmundson added a comment.
In https://phabricator.kde.org/D2501#46741, @mart wrote:
> better, tough, i guess wether would be possible for this line of buttons to
out all buttons at the same space (so using the size of the biggest one)
without ending up in horrible binding loops
colomar added a comment.
In https://phabricator.kde.org/D2449#46736, @mart wrote:
>
> it's instant save, some pieces couldn't be done differently at the moment
Hm, I think that's a problem.
1. Instant apply is not a common pattern in KDE software at all and therefor
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE236b475a1c28: Make ActionButton expand to fit
largest word in the row (authored by davidedmundson).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabri
This revision was automatically updated to reflect the committed changes.
Closed by commit rUSERMANAGERe63e702adf78: Install avatar icons in subfolders
(authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2494?vs=6050&id=6076#toc
REPOSITORY
rUSERMANAGER User Man
mart added a comment.
In https://phabricator.kde.org/D2449#46744, @colomar wrote:
> In https://phabricator.kde.org/D2449#46736, @mart wrote:
>
> >
>
>
> 2. Instant save in an edit field cannot really be done predictably, as the
user can never tell exactly when it's saved (certai
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
change the logout screen to the new design: user avatar and action buttons
shared with SDDM, old custom files removed
REPOSITORY
rPLASMAWORKSP
mart added a reviewer: Plasma.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2502
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
mart added a comment.
http://imgur.com/a/B6abc
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2502
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jen
mart added a comment.
difference from the mockup, only buttons currently supported by the logout
screen implemented atm
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2502
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpref
bearsh added a comment.
In https://phabricator.kde.org/D2498#46714, @mart wrote:
> can you go forward with the devel account/submission process?
"Developer account application submitted successfully on KDE Identity" :)
REPOSITORY
rKIRIGAMI Kirigami
BRANCH
bearsh
REVISION DET
graesslin added a comment.
Unfortunately that won't work either. KWin will load the effect again
whenever compositing is getting restarted.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2500
EMAIL PREFERENCES
https://phabricator.kde.org/sett
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This means if it's used elsewhere (for example the logout screen) we
don't create a pointless
mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.
thanks :)
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2503
EMAIL PREFERENCES
https://phabricat
graesslin added a comment.
I would like to see this integrated. But I think a few things need to be done:
- I would love to see the example you had in your blog post added to tests
- I'm still unhappy about the name KWinQml - it's just not saying what it is.
And actually it's not Qml at
sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.
REPOSITORY
rKWAYLAND KWayland
BRANCH
linux-input-optional
REVISION DETAIL
https://phabricator.kde.org/D2344
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpre
broulik added inline comments.
INLINE COMMENTS
> Logout.qml:45
> +function sleepRequested() {
> +suspendRequested(2);
> +}
Can we have an enum for that?
> Logout.qml:67
> +onTriggered: root.cancelRequested()
> +shortcut: "Escape"
> +}
There's no "Return"/"En
broulik added inline comments.
INLINE COMMENTS
> Logout.qml:147
> +text: {
> +switch (sdtype) {
> +case ShutdownType.ShutdownTypeReboot:
Also bind to currentAction insted of sdtype
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
summary is a required field in appstream data, without one we won't show
up in appstream-based stores
REPOSITORY
rKINFOCENTER KInfoCenter
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEde7c54a6c038: Don't assume UserDelegate is in
a ListView (authored by davidedmundson).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rKINFOCENTER KInfoCenter
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2504
EMAIL PREFERENCES
https://phabricator.kde.org/sett
This revision was automatically updated to reflect the committed changes.
Closed by commit rKINFOCENTERf7e4966ebd38: add a comment to get a summary in
autogenerated appstream data (authored by sitter).
REPOSITORY
rKINFOCENTER KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
use a save button instead of having instant save on all the fields
this is more coherent with the behavior of normal applications
REPOSITORY
mart added a reviewer: Plasma.
REPOSITORY
rPLASMASDK Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D2505
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
mart added a comment.
https://phabricator.kde.org/D2505
REPOSITORY
rPLASMASDK Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D2449
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, davidedmundson, #plasma
Cc: colomar, davidedmundson, plas
mart added a comment.
http://imgur.com/a/nckJh
REPOSITORY
rPLASMASDK Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D2505
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,
Il 19-08-2016 16:19 Olivier Churlaud ha scritto:
Il 11-08-2016 11:37 Ivan Čukić ha scritto:
Hi all,
For anyone interested I've also posted the SVG file (Andreas asked
for
it):
https://share.kde.org/index.php/s/0HRcGXCt6UCEWxp
Cheers,
Ivan
I updated it with the last version of my logo (poste
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The raw pointer button events intercepted in the XInput2 input filter
get sent through the Plat
Hi all,I just setup an Etherpad for the Plasma 5.8 Release announcement. Please fill in all the amazing stuff you did in the past months so we can come up with a good story and video for our LTS release. :)https://notes.kde.org/p/plasma_5_8Cheers,Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128616/#review98498
---
Ship it!
it's ok, but can you split the documentation chan
mart added inline comments.
INLINE COMMENTS
> broulik wrote in Logout.qml:45
> Can we have an enum for that?
it is an enum coming somewhere from solid, i don't think it has bindings?
> broulik wrote in Logout.qml:128
> Given you already set currentAction based on the sdtype, could be simplified
mart updated this revision to Diff 6084.
mart added a comment.
- Add new shared session QML files
- Avoid installing test data with SDDM
- use latest version of ActionButton
- Merge branch 'master' into mart/newLogoutScreen
- some keyboard navigation
REPOSITORY
rPLASMAWORKSPACE Plasm
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/
---
(Updated Aug. 19, 2016, 4:38 p.m.)
Status
--
This change has been ma
bearsh closed this revision.
bearsh added a comment.
pushed
REPOSITORY
rKIRIGAMI Kirigami
REVISION DETAIL
https://phabricator.kde.org/D2498
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bearsh, mart
Cc: plasma-devel
77 matches
Mail list logo
