[Differential] [Accepted] D2345: use a separate configuration per look and feel

2016-08-18 Thread Ivan Čukić
ivan accepted this revision. ivan added a reviewer: ivan. ivan added a comment. Since David has not objected to the last revision, I'm marking as accepted. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2345 EMAIL PREFERENCES https://phabricat

[Differential] [Commented On] D2487: Simpler KSplash design

2016-08-18 Thread broulik (Kai Uwe Broulik)
broulik added a comment. > with a transparent window i'm a bit concerned that all eventual flickering of compositor starting at half startup I didn't notice any issue, given the root window is black there's nothing to see with or without compositing. KWin just briefly freezes the screen

plasma-frameworks compile failure

2016-08-18 Thread Jonathan Riddell
Getting an error in plasma-frameworks today http://build.neon.kde.org/job/xenial_unstable_frameworks_plasma-framework_bin_amd64/92/console /workspace/build/src/plasmaquick/containmentview.cpp:205:69: error: ‘setTranslationDomain’ was not declared in this scope 16:37:02 setTranslation

[Differential] [Request, 2 lines] D2489: [Containment Actions Configuration] Add labels for Back / Forward mouse buttons

2016-08-18 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's not like we're doing any

Re: Review Request 128707: Add support for captive portals

2016-08-18 Thread Thomas Pfeiffer
> On Aug. 18, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > While I really appreciate that we get support for this I don't think just > > opening a webview automatically is a good idea. > > > > Can we perhaps show a notification [1] "log in to this network" with a > > button that will then open

Re: plasma-frameworks compile failure

2016-08-18 Thread rik
On 18/08/16 21:06, Jonathan Riddell wrote: > Getting an error in plasma-frameworks today > > http://build.neon.kde.org/job/xenial_unstable_frameworks_plasma-framework_bin_amd64/92/console > > /workspace/build/src/plasmaquick/containmentview.cpp:205:69: error: > ‘setTranslationDomain’ was not decl

Re: plasma-frameworks compile failure

2016-08-18 Thread David Edmundson
kdeclarative ​

Re: plasma-frameworks compile failure

2016-08-18 Thread rik
On 18/08/16 21:31, David Edmundson wrote: > kdeclarative > ​ Aha! Trying a new build of that. TY

[Differential] [Request, 7 lines] D2490: [Desktop Toolbox] Animate position change

2016-08-18 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This animates when the toolbox

Re: plasma-frameworks compile failure

2016-08-18 Thread Marco Martin
On Thursday 18 August 2016 21:06:00 Jonathan Riddell wrote: > > I've not updated any other frameworks, is there something that needs > updated first? kdeclarative needs to be updated -- Marco Martin

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

2016-08-18 Thread Ken Vermette
> On Aug. 18, 2016, 7:11 p.m., Marco Martin wrote: > > ship it from me.. maybe wait for a second as well, to see there is enough > > agreement Roger that. - Ken --- This is an automatically generated e-mail. To reply, visit: https://gi

[Differential] [Accepted] D2490: [Desktop Toolbox] Animate position change

2016-08-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ToolBoxRoot.qml:75 > +Behavior on x { > +NumberAnimation { duration: units.longDuration; easing.type: > Easing.InOutQuad }

[Differential] [Accepted] D2489: [Containment Actions Configuration] Add labels for Back / Forward mouse buttons

2016-08-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2489 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Request, 2 lines] D2491: [Kickoff] Mirror breadcrumb arrow in right-to-left layout

2016-08-18 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The breadcrumbs are already mi

[Differential] [Accepted] D2491: [Kickoff] Mirror breadcrumb arrow in right-to-left layout

2016-08-18 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Request, 63 lines] D2492: [Panel Containment] Cleanup

2016-08-18 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - When creating the applet con

[Differential] [Accepted] D2492: [Panel Containment] Cleanup

2016-08-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2492 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Request, 2 lines] D2495: Supress QML warning

2016-08-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Role LegacyWinIdList can be null, for example on a StartupItem or on Wayland. This means we a

[Differential] [Updated, 2 lines] D2495: Supress QML warning

2016-08-18 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 6053. davidedmundson added a comment. clearer syntax REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2495?vs=6052&id=6053 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2495 AFF

Re: [PATCH 1/7] add simple script to generate a qrc containing all qml files

2016-08-18 Thread Aleix Pol
Can you please upload the patches to phabricator.kde.org or reviewboard.kde.org? Thanks! Aleix On Tue, Aug 16, 2016 at 8:23 PM, Martin Gysel wrote: > --- > scripts/gen_qml_qrc.sh | 39 +++ > 1 file changed, 39 insertions(+) > create mode 100755 scripts/gen_q

[Differential] [Request, 76 lines] D2496: normalize output positions in setoperation

2016-08-18 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When setting a config, outputs may fall outside of the virtual screen layout. This can happen when, for example

fix Kirigami qrc file

2016-08-18 Thread Dirk Hohndel
>From fb2d355d00011f7ff9a0a7ea69ea93ecc36a5486 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Thu, 18 Aug 2016 22:05:25 -0700 Subject: [PATCH] Remove reference to Icon.qml under desktop style This file was removed in commit 2496430d9404 ("c++ implementation of Icon on Desktop style") Signed-

Re: Review Request 128707: Add support for captive portals

2016-08-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98490 --- I'm not happy with the QWebEngineView as that's going to cras

[Differential] [Accepted] D2465: [kded] correctly restore lidOpened configuration on startup

2016-08-18 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH sebas/lidopeninit REVISION DETAIL https://phabricator.kde.org/D2465 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

<    1   2