[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

2016-08-15 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio added a comment. Ping? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2365 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, graesslin Cc: pl

[Differential] [Closed] D2252: [ksmserver] Create a dedicated binary from KSMShutdownDlg

2016-08-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE4af2c532268e: [ksmserver] Create a dedicated binary from KSMShutdownDlg (authored by graesslin). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricat

[Differential] [Closed] D2257: [ksmserver] Use the new logout greeter binary to show the shutdown dialog

2016-08-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE0256d5f8b568: [ksmserver] Use the new logout greeter binary to show the shutdown dialog (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2257?vs=5418&id=5920#t

[Differential] [Request, 99 lines] D2445: [ksmerver/logout] KWayland integration to create PlasmaShell surface for absolute positioning

2016-08-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Positions the shutdown dialog in the absolute space if there is the PlasmaShell interface. REPOSITORY

[Differential] [Closed] D2264: [ksmserver/greeter] Show one logout greeter on each screen

2016-08-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf9562b932e02: [ksmserver/greeter] Show one logout greeter on each screen (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2264?vs=5671&id=5919#toc REPOSITORY

[Differential] [Updated] D2365: Add failing test case for selected filter from mimetype

2016-08-15 Thread Martin Gräßlin
graesslin added a comment. As it's an expected failure I'm fine with it going in. I cannot really comment on the actual issue, because I have no clue about the file dialog. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org

Re: Review Request 128662: [DefaultToolTip] Enable LayoutMirroring

2016-08-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128662/#review98392 --- Ship it! Ship It! - Marco Martin On Aug. 12, 2016, 11:1

[Differential] [Accepted] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

2016-08-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2421 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D2422: [Clipboard Plasmoid] Adjust gradient for right-to-left languages

2016-08-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2422 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

Re: Kirigami build instructions

2016-08-15 Thread Marco Martin
On Monday 15 August 2016, Police Terror wrote: > 'CMakeFiles/create-apk-kirigamigallery.dir/all' failed > make[2]: *** [CMakeFiles/create-apk-kirigamigallery.dir/all] Error 2 > CMakeFiles/Makefile2:106: recipe for target > 'CMakeFiles/create-apk-kirigamigallery.dir/rule' failed > make[1]: *** [CMak

[Differential] [Accepted] D2426: [KRunner] Set componentDisplayName for shortcuts

2016-08-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2426 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

Re: Subsurface-mobile status update

2016-08-15 Thread Marco Martin
On Monday 15 August 2016, Dirk Hohndel wrote: > Kirigami as is has a few oddities. It compiles neither with cmake nor with > qmake. Hmm. > > I have patches for that, but on iOS it still dies at startup with a > BAD_ACCESS to address 0x1 when trying to loop over the > m_stylesFallbackChain in Kirig

[Differential] [Request, 6 lines] D2446: Remove redundant manual focusOut handling in DesktopView

2016-08-15 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It makes no sense to modify the focus of containment within it's FocusScope, and activeFocus

Re: Plasmoid can know widgets locking state?

2016-08-15 Thread Michail Vourlakos
Thank u :-) On 15/08/2016 09:29 πμ, Kai Uwe Broulik wrote: Hi, Yes, plasmoid.immutable [1] is true when widgets are locked. [1] https://api.kde.org/frameworks/plasma-framework/html/classAppletInterface.html

[Differential] [Updated] D2365: Add failing test case for selected filter from mimetype

2016-08-15 Thread dfaure (David Faure)
dfaure added a comment. The thing is, mimetype filters should be preferred above name filters. So the bug is in QFileDialog::selectMimeTypeFilter which "falls back" to selectNameFilter. Instead it should call some selectInitiallySelectedMimeTypeFilter in the options, like selectNameFilter d

[Differential] [Accepted] D2446: Remove redundant manual focusOut handling in DesktopView

2016-08-15 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2446 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Accepted] D2420: [Task Manager] Fix icon placement with right-to-left languages

2016-08-15 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2420 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

Review Request 128682: Fix typo in icon name

2016-08-15 Thread Fabian Vogt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128682/ --- Review request for Plasma. Repository: plasma-pk-updates Description --

Re: Review Request 128682: Fix typo in icon name

2016-08-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128682/#review98394 --- Ship it! Ship It! - David Edmundson On Aug. 15, 2016, 1

Re: Review Request 128682: Fix typo in icon name

2016-08-15 Thread Fabian Vogt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128682/ --- (Updated Aug. 15, 2016, 10:40 a.m.) Status -- This change has been m

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128654/#review98395 --- Fix it, then Ship it! kstyle/breezestyle.cpp (line 3072)

[Differential] [Updated] D2409: Update Color KCM

2016-08-15 Thread ochurlaud (Olivier Churlaud)
ochurlaud updated the summary for this revision. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma, andreask, #vdg, mart Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohame

Re: Review Request 128660: Add an optional reveal password button to TextField

2016-08-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98396 --- src/declarativeimports/plasmacomponents/qml/TextField.qml (l

Re: Review Request 128660: Add an optional reveal password button to TextField

2016-08-15 Thread Kai Uwe Broulik
> On Aug. 15, 2016, 10:52 vorm., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmastyle/TextFieldStyle.qml, line 80 > > > > > > Don't add units.smallSpacing if there's no actions, the padding is now > > un

Re: Review Request 128660: Add an optional reveal password button to TextField

2016-08-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98397 --- src/declarativeimports/plasmastyle/TextFieldStyle.qml (line

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128654/ --- (Updated Aug. 15, 2016, 11 vorm.) Review request for Plasma, David Rosca

Re: Review Request 128662: [DefaultToolTip] Enable LayoutMirroring

2016-08-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128662/ --- (Updated Aug. 15, 2016, 11:04 a.m.) Status -- This change has been m

[Differential] [Closed] D2420: [Task Manager] Fix icon placement with right-to-left languages

2016-08-15 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP7034546fefe1: [Task Manager] Fix icon placement with right-to-left languages (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Closed] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

2016-08-15 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEbe801f30eb89: [Digital Clock Tooltip] Enable LayoutMirroring (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2421?vs=5869&id=5925#toc REPOSITORY rPLASMAWORKS

[Differential] [Accepted] D2409: Update Color KCM

2016-08-15 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, andreask, #vdg, mart, #plasma, bshah C

[Differential] [Commandeered] D2409: Update Color KCM

2016-08-15 Thread bshah (Bhushan Shah)
bshah commandeered this revision. bshah edited reviewers, added: ochurlaud; removed: bshah. This revision now requires review to proceed. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, andreask, #vdg

[Differential] [Abandoned] D2409: Update Color KCM

2016-08-15 Thread bshah (Bhushan Shah)
bshah abandoned this revision. bshah added a comment. This has been submitted, I will just abandon changes.. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, andreask, #vdg, mart, #plasma, ochurlau

[Differential] [Commandeered] D2409: Update Color KCM

2016-08-15 Thread ochurlaud (Olivier Churlaud)
ochurlaud commandeered this revision. ochurlaud edited reviewers, added: bshah; removed: ochurlaud. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, andreask, #vdg, mart, #plasma, bshah Cc: whiting

[Differential] [Updated] D2409: Update Color KCM

2016-08-15 Thread ochurlaud (Olivier Churlaud)
ochurlaud reclaimed this revision. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, andreask, #vdg, mart, #plasma, bshah Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, jen

[Differential] [Accepted] D2409: Update Color KCM

2016-08-15 Thread bshah (Bhushan Shah)
bshah accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, andreask, #vdg, mart, #plasma, bshah Cc: whiting, colomar, andreaska,

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128654/#review98400 --- Ship it! Ship It! - David Edmundson On Aug. 15, 2016, 1

[Differential] [Closed] D2409: Update Color KCM

2016-08-15 Thread ochurlaud (Olivier Churlaud)
ochurlaud closed this revision. ochurlaud added a comment. This was submitted in commit https://phabricator.kde.org/rPLASMADESKTOPb9e2664cc7aa50aa9e6be8368f34390bc756b73a REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

Re: Review Request 128660: Add an optional reveal password button to TextField

2016-08-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/ --- (Updated Aug. 15, 2016, 11:22 a.m.) Review request for KDE Frameworks and

Review Request 128684: Proofread + update khtml-general kcm docbook

2016-08-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128684/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure.

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 256 - Failure!

2016-08-15 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/256/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 15 Aug 2016 11:26:15 + Build duration: 12 min CHANGE SET Revision b08caf02eed8a1cba3da44027585ff53f2158

Review Request 128683: Add overlay(s) to items in plasma folder view

2016-08-15 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128683/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128654/ --- (Updated Aug. 15, 2016, 11:48 a.m.) Status -- This change has been m

Review Request 128685: Proofread + update performance kcm docbook

2016-08-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128685/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure.

Review Request 128686: Proofread + update bookmarks kcm docbook

2016-08-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128686/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure.

Re: Review Request 128660: Add an optional reveal password button to TextField

2016-08-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98401 --- Fix it, then Ship it! src/declarativeimports/plasmacompon

Re: Kirigami build instructions

2016-08-15 Thread Police Terror
Yes, I can build other things fine such as the hello-jni example or compiling C libraries that use autotools too. I will try the qtcreator thing as you say. Marco Martin: > On Monday 15 August 2016, Police Terror wrote: >> 'CMakeFiles/create-apk-kirigamigallery.dir/all' failed >> make[2]: *** [CM

Review Request 128687: Proofread + update filemanager kcm docbook

2016-08-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128687/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure.

[Differential] [Updated] D2399: New new SDDM theme

2016-08-15 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > bshah wrote in KeyboardButton.qml:13 > I wonder if it ever worked to translate those in SDDM? Given KDeclarative > takes care of loading translation domain IIRC. It used to work. We don't have the i18n domain set because we're being loaded

[Differential] [Reopened] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

2016-08-15 Thread broulik (Kai Uwe Broulik)
broulik reopened this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2421 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: pla

plasma-devel@kde.org

2016-08-15 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY the shell has 2 methods to switch lnf layout: one that throws away the config contents, one that keeps them REPOSITORY rPLASMADESKTOP Plasm

plasma-devel@kde.org

2016-08-15 Thread mart (Marco Martin)
mart added a reviewer: Plasma. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2448 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

plasma-devel@kde.org

2016-08-15 Thread mart (Marco Martin)
mart added a dependency: D2345: use a separate configuration per look and feel. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2448 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, les

[Differential] [Updated, 378 lines] D2345: use a separate configuration per look and feel

2016-08-15 Thread mart (Marco Martin)
mart updated this revision to Diff 5927. mart added a comment. - methods to switch lnf REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=5812&id=5927 BRANCH mart/separateLookAndFeelLayout REVISION DETAIL https://phabricator.k

plasma-devel@kde.org

2016-08-15 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcm.cpp:33 > #include > +#include > #include unused > kcm.cpp:258 > + > +QDBusConnection::ses

[Differential] [Closed] D2426: [KRunner] Set componentDisplayName for shortcuts

2016-08-15 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb0940b6b6ed1: [KRunner] Set componentDisplayName for shortcuts (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

plasma-devel@kde.org

2016-08-15 Thread mart (Marco Martin)
mart updated this revision to Diff 5929. mart added a comment. - use .call(message, QDBus::NoBlock) REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2448?vs=5926&id=5929 BRANCH phab/lnfshellswitchkcm REVISION DETAIL https://phabricator.

Review Request 128688: Proofread + update khtml-behavior kcm docbook

2016-08-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128688/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure.

[Differential] [Accepted] D2445: [ksmerver/logout] KWayland integration to create PlasmaShell surface for absolute positioning

2016-08-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH ksmserver-logout-greeter-wayland-integration REVISION DETAIL https://phabricator.kde.org/D2445 EMAIL PREFERENCES https://phabric

[Differential] [Accepted] D2410: [wayland] Properly implement minimize of ShellClient

2016-08-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH minimize-shell-client REVISION DETAIL https://phabricator.kde.org/D2410 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D2413: Trigger global shortcuts also on key-repeat

2016-08-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH global-shortcut-key-repeat REVISION DETAIL https://phabricator.kde.org/D2413 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Accepted] D2407: [libinput] Expose all input devices through DBus

2016-08-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH input-device-dbus REVISION DETAIL https://phabricator.kde.org/D2407 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Review Request 128689: Proofread + update kcmcss kcm docbook

2016-08-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128689/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure.

Review Request 128690: Proofread + update khtml-adblock kcm docbook

2016-08-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128690/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure.

Review Request 128692: Don't redeclare property implicitHeight

2016-08-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128692/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

[Differential] [Request, 1,370 lines] D2449: small utility to create L&F packages

2016-08-15 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY small utility that can browse look and feel packages, edit the metadata of those installed in ~/.local and create new ones with defaults files

Review Request 128691: Proofread + update history kcm docbook

2016-08-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128691/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure.

[Differential] [Updated] D2449: small utility to create L&F packages

2016-08-15 Thread mart (Marco Martin)
mart added a dependency: D2345: use a separate configuration per look and feel. REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai,

[Differential] [Updated] D2345: use a separate configuration per look and feel

2016-08-15 Thread mart (Marco Martin)
mart added a dependent revision: D2449: small utility to create L&F packages. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2345 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc:

[Differential] [Updated] D2449: small utility to create L&F packages

2016-08-15 Thread mart (Marco Martin)
mart added a reviewer: Plasma. REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2422: [Clipboard Plasmoid] Adjust gradient for right-to-left languages

2016-08-15 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3b251bc6ccb1: [Clipboard Plasmoid] Adjust gradient for right-to-left languages (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2422?vs=5870&id=5931#toc REPOSIT

[Differential] [Closed] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

2016-08-15 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE5cdcec32252f: [Digital Clock Tooltip] Enable LayoutMirroring (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2421?vs=5925&id=5932#toc REPOSITORY rPLASMAWORKS

[Differential] [Closed] D2449: small utility to create L&F packages

2016-08-15 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDKaec60062c7be: actions in GlobalDrawer (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2449?vs=5930&id=5933#toc REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UP

[Differential] [Reopened] D2449: small utility to create L&F packages

2016-08-15 Thread mart (Marco Martin)
mart reopened this revision. REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128660: Add an optional reveal password button to TextField

2016-08-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/ --- (Updated Aug. 15, 2016, 1:34 p.m.) Status -- This change has been ma

Re: Review Request 128551: [TextFieldStyle] Calculate right padding with clear button properly

2016-08-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128551/ --- (Updated Aug. 15, 2016, 1:34 nachm.) Status -- This change has been

Re: Review Request 128549: [TextField] Hide clear button properly

2016-08-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128549/ --- (Updated Aug. 15, 2016, 1:35 nachm.) Status -- This change has been

Review Request 128693: Proofread + update khtml-java-js kcm docbook

2016-08-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128693/ --- Review request for Documentation, KDE Base Apps, Plasma, and David Faure.

[Differential] [Request, 212 lines] D2450: Add support for touch events in the Effect system

2016-08-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The Effect class is extended by three new virtual methods: - to

Re: Subsurface-mobile status update

2016-08-15 Thread Dirk Hohndel
On Mon, Aug 15, 2016 at 11:33:08AM +0200, Marco Martin wrote: > On Monday 15 August 2016, Dirk Hohndel wrote: > > Kirigami as is has a few oddities. It compiles neither with cmake nor with > > qmake. Hmm. > > > > I have patches for that, but on iOS it still dies at startup with a > > BAD_ACCESS to

Re: Now Dock - create a single widget panel?

2016-08-15 Thread Sebastian Kügler
On Saturday, August 13, 2016 1:47:18 PM UTC Michail Vourlakos wrote: > Having published the Now Dock plasmoid in kdelook, I would like in parallel > to start the effort to implement it as a panel... But I dont know from > where to start... I found in the plasmoids folder the org.kde.panel which I >

Re: Subsurface-mobile status update

2016-08-15 Thread Marco Martin
On Monday 15 August 2016, Dirk Hohndel wrote: > Do you have any idea, though, while this is crashing for me on iOS? > The crash is always in some Qt internal - and it's always that some > internal Qt managed pointer is set to 0x1 which then of course gives a bad > access when dereferencing it. on

Re: Kirigami build instructions

2016-08-15 Thread Sebastian Kügler
On Monday, August 15, 2016 5:35:00 AM UTC Police Terror wrote: > Directory /platforms does not exist Looks like you haven't exported the ANDROID_NDK vars correctly, like Aleix suggested. -- sebas http://www.kde.org | http://vizZzion.org

Re: Now Dock - create a single widget panel?

2016-08-15 Thread Marco Martin
On Saturday 13 August 2016, Michail Vourlakos wrote: > Hello everyone... > > > Having published the Now Dock plasmoid in kdelook, I would like in > parallel to start the effort to implement it as a panel... But I dont > know from where to start... I found in the plasmoids folder the > org.kde.pan

[Differential] [Request, 10 lines] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

2016-08-15 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Setting a Row's or Column's si

[Differential] [Closed] D2410: [wayland] Properly implement minimize of ShellClient

2016-08-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN8bbd53a77493: [wayland] Properly implement minimize of ShellClient (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2410?vs=5840&id=5939 REVIS

[Differential] [Request, 6 lines] D2452: Simplify and fix sizing code in ToolTipDelegate

2016-08-15 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Row's implicitWidth is already set to the width of the children. Using childrenRect results i

[Differential] [Accepted] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

2016-08-15 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2451 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Abandoned] D2452: Simplify and fix sizing code in ToolTipDelegate

2016-08-15 Thread davidedmundson (David Edmundson)
davidedmundson abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2452 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreut

[Differential] [Closed] D2435: Don't trigger modifier only shortcuts if pointer interaction

2016-08-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINbd58d7792fed: Don't trigger modifier only shortcuts if pointer interaction (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2435?vs=5894&id=593

[Differential] [Closed] D2407: [libinput] Expose all input devices through DBus

2016-08-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINab5d31426ab6: [libinput] Expose all input devices through DBus (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2407?vs=5830&id=5940 REVISION

[Differential] [Accepted] D2450: Add support for touch events in the Effect system

2016-08-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. as discussed on irc, i would have loved if it was exposed with qtouchevents (or a qtouchevent-like api however, as this seems to be really overcomplicated to do, t

[Differential] [Updated, 18 lines] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

2016-08-15 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 5943. broulik added a comment. - Get rid of _s which is just units.smallSpacing / 2 (and only used in two places after the previous patch) REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2451?vs=5937&id

[Differential] [Closed] D2446: Remove redundant manual focusOut handling in DesktopView

2016-08-15 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd95779b7df33: Remove redundant manual focusOut handling in DesktopView (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2446?vs=5921&id=5944#toc REPOSITO

[Differential] [Updated, 18 lines] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

2016-08-15 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 5945. broulik added a comment. Fix typo REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2451?vs=5943&id=5945 REVISION DETAIL https://phabricator.kde.org/D2451 AFFECTED FILES applets/taskmanager/pac

[Differential] [Closed] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

2016-08-15 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPc47e5223: [Task Manager ToolTipDelegate] Let positioner size itself automatically (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://pha

[Differential] [Request, 8 lines] D2454: [Task Manager ToolTipDelegate] Adjust for right-to-left languages

2016-08-15 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Enable LayoutMirroring - A

Re: Subsurface-mobile status update

2016-08-15 Thread Dirk Hohndel
> On Aug 15, 2016, at 7:10 AM, Marco Martin wrote: > > On Monday 15 August 2016, Dirk Hohndel wrote: >> Do you have any idea, though, while this is crashing for me on iOS? >> The crash is always in some Qt internal - and it's always that some >> internal Qt managed pointer is set to 0x1 which th

[Differential] [Accepted] D2454: [Task Manager ToolTipDelegate] Adjust for right-to-left languages

2016-08-15 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2454 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Request, 15 lines] D2455: Use new inline revealpassword action

2016-08-15 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Clicked a new connection. Toggled show/hide action REPOSITORY rPLASMANM Plasma Network Management A

[Differential] [Closed] D2455: Use new inline revealpassword action

2016-08-15 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP708ba4b426f5: [Task Manager ToolTipDelegate] Adjust for right-to-left languages (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2455?vs=5948&id=5949#toc REPOSITO

  1   2   >