Re: task manager lines instead of blocks

2016-07-31 Thread Eike Hein
Hi Andreas, task.svgz is really non-trivial to get right, partly because the Task Manager has a lot of non-obvious modes. I trust you guys, but please make sure that any changes to it goes through Review first and that I get enough time to have a look. I spent hours (yes, hours of fiddling!) fixin

Re: task manager lines instead of blocks

2016-07-31 Thread Marco Martin
On Saturday 30 July 2016 10:20:41 kainz.a wrote: > Hi, > > in plasma 5.4 we had the lines for the task manager. Uri changed it in > blocks. Since the last year with blocks I think lines would fit better the > breeze theme. > > http://linux.sothorn.org/wp-content/uploads/2015/08/plasma1.png I lik

Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualActions menu

2016-07-31 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128562/ --- Review request for Plasma and Marco Martin. Bugs: 366294 http://bugs.

Re: Review Request 128557: Folder View Plasmoid: Undo trash

2016-07-31 Thread Chinmoy Ranjan Pradhan
> On July 30, 2016, 3:58 p.m., Eike Hein wrote: > > Ship It! I dont have commit access. Please ship it for me :) - Chinmoy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128557/#review9

Re: Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

2016-07-31 Thread Chinmoy Ranjan Pradhan
> On July 29, 2016, 3:28 p.m., Eike Hein wrote: > > Ping -- Eike :-) - Chinmoy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128552/#review97909 ---

Re: Review Request 128557: Folder View Plasmoid: Undo trash

2016-07-31 Thread Bhushan Shah
> On July 30, 2016, 9:45 p.m., Chinmoy Ranjan Pradhan wrote: > > I dont have commit access. Please commit it on my behalf :) You should apply for developer application : https://community.kde.org/Infrastructure/Get_a_Developer_Account .. feel free to add my name as supporter. - Bhushan ---

Re: Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualActions menu

2016-07-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128562/#review97944 --- Fix it, then Ship it! src/scriptengines/qml/plasmoid/appl

Re: Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualActions menu

2016-07-31 Thread Eike Hein
On July 31, 2016, 11:14 a.m., Eike Hein wrote: > > Slightly OT but I'm sure there's some code duplication here, as > > ContainmentInterface is *also* trying to handle the right clicks for > > applets within that containment. It does the appletAt() and then loads the > > applets menu. > > Somet

Re: Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualActions menu

2016-07-31 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128562/ --- (Updated July 31, 2016, 12:13 p.m.) Review request for Plasma and Marco M

Re: Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualActions menu

2016-07-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128562/#review97949 --- Ship it! Ship It! - David Edmundson On July 31, 2016, 1

Re: Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

2016-07-31 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128552/#review97950 --- containments/desktop/plugins/folder/foldermodel.cpp (line 95

Re: Review Request 128557: Folder View Plasmoid: Undo trash

2016-07-31 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128557/ --- (Updated July 31, 2016, 12:23 p.m.) Status -- This change has been m

Re: Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

2016-07-31 Thread Chinmoy Ranjan Pradhan
> On July 31, 2016, 12:18 p.m., Eike Hein wrote: > > containments/desktop/plugins/folder/foldermodel.cpp, line 952 > > > > > > I still don't like this because we're going from a 'smart' icon with > > multiple av

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 232 - Failure!

2016-07-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/232/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 31 Jul 2016 12:23:40 + Build duration: 11 min CHANGE SET Revision 8a152cb7a66362c91d48d0b201d44436d79e8

Re: Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

2016-07-31 Thread Eike Hein
> On July 31, 2016, 12:18 p.m., Eike Hein wrote: > > containments/desktop/plugins/folder/foldermodel.cpp, line 952 > > > > > > I still don't like this because we're going from a 'smart' icon with > > multiple av

Re: Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

2016-07-31 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128552/#review97953 --- containments/desktop/package/contents/ui/FolderItemDelegate.

[Powerdevil] [Bug 366299] New: System setting "Energy Saving" window is too large for a standard laptop screen

2016-07-31 Thread Oded Arbel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366299 Bug ID: 366299 Summary: System setting "Energy Saving" window is too large for a standard laptop screen Product: Powerdevil Version: 5.7.2 Platform: Neon Packages

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

2016-07-31 Thread Oded Arbel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366299 --- Comment #1 from Oded Arbel --- Created attachment 100398 --> https://bugs.kde.org/attachment.cgi?id=100398&action=edit attachment showing the problem -- You are receiving this mail because: You are the assignee for the bug. _

Re: Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualActions menu

2016-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128562/#review97954 --- Ship it! Ship It! - Marco Martin On July 31, 2016, 12:1

[Differential] [Updated] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-07-31 Thread drosca (David Rosca)
drosca added reviewers: Plasma, Plasma: Design. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2314 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, #plasma, #plasma:_design Cc: plasma-devel, ali-mohamed

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 290 - Still Unstable!

2016-07-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/290/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 31 Jul 2016 15:05:05 + Build duration: 9 min 48 sec CHANGE SET Revision 5e099fac50a8e63f1be78fa9

Re: Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualActions menu

2016-07-31 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128562/ --- (Updated July 31, 2016, 3:18 p.m.) Status -- This change has been ma

Re: Review Request 128314: Fix for bug 364530

2016-07-31 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128314/ --- (Updated July 31, 2016, 3:20 p.m.) Status -- This change has been ma

Re: Review Request 128314: Fix for bug 364530

2016-07-31 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128314/ --- (Updated July 31, 2016, 3:28 p.m.) Status -- This change has been di

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2016-07-31 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=350365 gust...@angulosolido.pt changed: What|Removed |Added CC||gust...@angulosolido.pt --- Comment #6

[Differential] [Request, 2 lines] D2322: [Kickoff] Fix start row for drag not always being correct

2016-07-31 Thread net147 (Jonathan Liu)
net147 created this revision. net147 added reviewers: Plasma, broulik. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The start row for the dra

[Differential] [Updated, 3 lines] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-07-31 Thread net147 (Jonathan Liu)
net147 updated this revision to Diff 5592. net147 added a comment. Added copyright. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2310?vs=5566&id=5592 REVISION DETAIL https://phabricator.kde.org/D2310 AFFECTED FILES applets/kickoff/p

Re: Review Request 128519: Fix XDG_DATA_DIRS path in startkde

2016-07-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128519/#review97964 --- If changed, pleases make sure to include the same change into

[Differential] [Commented On] D2242: [ksplash] Better support for Wayland with multiple screens

2016-07-31 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D2242#42628, @sebas wrote: > The wayland portions look good, so as soon as you guys are happy, I am. > > I guess the platform name stuff can happen async? Yes, that can be done later on. We need to mass adopt code anyway

Re: "Software not found" Runner

2016-07-31 Thread Martin Graesslin
On Tuesday, July 26, 2016 2:17:32 PM CEST Aleix Pol wrote: > On Tue, Jul 26, 2016 at 1:10 PM, Marco Martin wrote: > > On Tuesday 26 July 2016 13:01:10 Aleix Pol wrote: > >> Hi, > >> Last week I put together this runner, thought it might be useful, so > >> if you type in krunner an application but

[Differential] [Accepted] D2299: split load into two methods to improve readability a tad

2016-07-31 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKINFOCENTER KInfoCenter BRANCH split-load REVISION DETAIL https://phabricator.kde.org/D2299 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

Re: Plasma 5.8 and openSUSE 42.2

2016-07-31 Thread Martin Graesslin
On Thursday, July 28, 2016 10:11:56 AM CEST Jonathan Riddell wrote: > On Tue, Jul 26, 2016 at 03:56:21PM +0200, Antonio Larrosa wrote: > > This mean bringing forward some kde release dates and postponing some > > opensuse pre-releases to make everything fit tightly. > > > > 2016-09-01: openSUSE 42

Re: From Grub to Shutdown project update

2016-07-31 Thread Martin Graesslin
On Monday, July 25, 2016 12:24:56 PM CEST Jens Reuterberg wrote: > KSPLASH > Ksplash is removed in favour for two clear effects, one is the "fade to > desktop" already present in Kwin, the other is an effect where SDDM fades in > a very specific way. (the SDDM interface fades leaving only the chos