broulik added a comment.
So, should we get this into 5.7.2? It's definitely an improvement to the
5.7.1 situation, especially for the blurry xembed icons.
As for Eike's issue, I have really no clue why that happens, I looked into
CompactApplet and everywhere and don't see any additional
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
KWin needs to support restarting the OpenGL compositor in case of a
mart added a comment.
yes, definitely in 5.7.2
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2160
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart
Cc: hein, mart, plasma-devel, jensreu
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2099
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: brou
mart added inline comments.
INLINE COMMENTS
> scriptengine.h:74
>
> -// containment accessors
> -static QStringList availableContainments(const QString &type);
> +static QStringList availableActivities(QScriptContext *context,
> QScriptEngine *engine);
> +
does this makes an api c
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE1caec23e0e92: [System Tray] Animate only the
icon (authored by broulik).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2099?vs=4979
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE6a3ea8abb5a5: [System Tray] Round item size to
icon size (authored by broulik).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2160?
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 18 Jul 2016 09:01:03 +
Build duration: 44 sec
CHANGE SET
Revision 6a3ea8abb5a545d7cad5c534a
Hello plasma team,
I am not much happy to write this, but here it goes,
Since last three Plasma release it always bugged me that there were no
usefull changes in plasma-mediacenter, mostly because after being
contracted by Bluesystems I got involved into Plasma Mobile related
work and didn't mana
Hi,
On Mon, Jul 18, 2016 at 2:29 PM, Bhushan Shah wrote:
> Hello plasma team,
>
> I am not much happy to write this, but here it goes,
>
> Since last three Plasma release it always bugged me that there were no
> usefull changes in plasma-mediacenter, mostly because after being
> contracted by Bl
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2187
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, #plasma, d
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINb8ad6d73ed6e: Support restarting the OpenGL compositor on
Wayland (authored by graesslin).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2202?vs=5260&id=5263
REVISI
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE3af24524702e: ScriptEngine exports the list of
activities known to Plasma (authored by ivan).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.
graesslin reopened this revision.
graesslin added a comment.
erm, commit was in a branch, not on master.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D2202
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/269/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 18 Jul 2016 09:23:58 +
Build duration: 17 min
CHANGE SET
Revision 3af24524702e92215a9cce4dcba6b421ac
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128447/#review97518
---
No review for this?
You applied this to kamera, shipped with
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 18 Jul 2016 09:47:20 +
Build duration: 1 min 0 sec
CHANGE SET
Revision 1fe810eb404d3aa83c67
hein created this revision.
hein added reviewers: Plasma, graesslin.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma on Wayland.
REPOSITORY
rKWAYLAND KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2203
AFFECTED FILES
autotests/c
elvisangelaccio added a comment.
Ping?
I've been testing `QFileDialog` on Gnome shell and this issue cannot be
reproduced there. So we should definitely fix in Plasma.
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1
Minutes Plasma 'hangout', 18-7-2016, 12:00 CET
Present: mgraesslin, bshah, Sho, kbroulik, notmart, sebas
bshah:
- Not much update last week, just new phone image with sound working
- I also submitted initial patches for nexus 5 mainline support that supports
volume up and down button and serial
https://bugs.kde.org/show_bug.cgi?id=362198
--- Comment #3 from Ivan Čukić ---
Which file-system is on /Data?
are you able to edit .config/katerc file (for example, in vim or something) and
save it. Then confirm the data has been written?
Having 92% of a partition used might lead to insufficien
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
please also add a test to verify that the geometry actually works in the
model. Right now it only verifies that the default geometry is set.
REPOSITORY
rKWAYLAND KWayland
https://bugs.kde.org/show_bug.cgi?id=360339
Ivan Čukić changed:
What|Removed |Added
Version|5.19.0 |master
Status|ASSIGNED
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128089/#review97519
---
Ping.
Can we have this in? Without the "Open Link" then, I g
hein updated this revision to Diff 5266.
hein added a comment.
Add test for Geometry change.
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2203?vs=5265&id=5266
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2203
AFFECTED FILES
au
hein updated this revision to Diff 5267.
hein added a comment.
Add flush.
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2203?vs=5266&id=5267
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2203
AFFECTED FILES
autotests/client/test
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> test_plasma_window_model.cpp:446-447
> +{
> +auto model = m_pw->createWindowModel();
> +QVERIFY(model);
> +
you don't need to create a model. Yo
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Kickoff tr
sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2204
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: b
davidedmundson added a comment.
I'm pretty sure I remember a conversation with Vishesh where he deliberately
didn't do this because the results then look utterly random as you can't see
the comment.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org
davidedmundson added a comment.
I'm pretty sure I remember a conversation with Vishesh where he deliberately
didn't do this because the results then look utterly random as you can't see
the comment.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org
graesslin added a comment.
Looks good to me. You expanded the manual test, would it be possible to also
expand the autotest?
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1813
EMAIL PREFERENCES
https://phabricator.
broulik added a comment.
I changed it so the comment is shown at least when the item is currently
selected in the list [1] as it often provides useful information, not just for
telling apart similar entries (as the old logic did).
[1]
https://quickgit.kde.org/?p=milou.git&a=commit&h=f6d
broulik added a subscriber: dfaure.
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1813
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, #plasma
Cc: dfaure, graesslin,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128089/#review97527
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 7, 2016,
colomar added a comment.
> There is one strange thing regarding the behaviour - the sub-item links.
>
> The first problem is that it is not obvious what is clickable and what is
not - the only hint is a slight change in the background (at least with my
colour scheme) on hover.
Is th
colomar added a comment.
Big +1, both showing and being able to search in the description is crucial
especially for newer users who have not memorized the often entirely arbitrary
application names.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org
graesslin created this revision.
graesslin added reviewers: Plasma, bshah.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The test creates a Wayland display, locks the screen and destroys
the output. In this situation k
https://bugs.kde.org/show_bug.cgi?id=352497
--- Comment #8 from Matteo Croce ---
yes, power plug / unplug actually works
--
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
graesslin added a comment.
Most likely the test won't work on build.kde.org due to the known problems of
no OpenGL
INLINE COMMENTS
> noscreens.cpp:138
> +// give some time to show the window
> +QTest::qWait(5000);
> +
without the timeout kscreenlocker_greet crashes, but I fail to ge
https://bugs.kde.org/show_bug.cgi?id=357621
Matteo Croce changed:
What|Removed |Added
CC||rootki...@yahoo.it
--- Comment #6 from Matteo Cr
https://bugs.kde.org/show_bug.cgi?id=358588
Matteo Croce changed:
What|Removed |Added
CC||rootki...@yahoo.it
--- Comment #2 from Matteo Cr
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rKSCREENLOCKER KScreenLocker
BRANCH
test-no-screens
REVISION DETAIL
https://phabricator.kde.org/D2208
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128475/
---
Review request for Plasma and KDE Usability.
Repository: kde-gtk-config
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128475/
---
(Updated Juli 18, 2016, 2:08 nachm.)
Review request for Plasma and KDE Us
> On July 18, 2016, 5:49 a.m., Martin Gräßlin wrote:
> > I acknowledge the problem in general, but I think the solution is wrong as
> > this creates now a race condition on startup where apps don't show up in
> > the systray at all. That is if an application tries to create a systray
> > icon
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128475/
---
(Updated Juli 18, 2016, 2:30 nachm.)
Review request for Plasma and KDE Us
> On July 18, 2016, 7:49 a.m., Martin Gräßlin wrote:
> > I acknowledge the problem in general, but I think the solution is wrong as
> > this creates now a race condition on startup where apps don't show up in
> > the systray at all. That is if an application tries to create a systray
> > icon
> On July 18, 2016, 7:49 a.m., Martin Gräßlin wrote:
> > I acknowledge the problem in general, but I think the solution is wrong as
> > this creates now a race condition on startup where apps don't show up in
> > the systray at all. That is if an application tries to create a systray
> > icon
This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREENLOCKERdb67f095fd12: Autotest to simulate that no
screens are available (authored by graesslin).
REPOSITORY
rKSCREENLOCKER KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22
> On July 18, 2016, 5:49 a.m., Martin Gräßlin wrote:
> > I acknowledge the problem in general, but I think the solution is wrong as
> > this creates now a race condition on startup where apps don't show up in
> > the systray at all. That is if an application tries to create a systray
> > icon
> On July 18, 2016, 5:49 a.m., Martin Gräßlin wrote:
> > I acknowledge the problem in general, but I think the solution is wrong as
> > this creates now a race condition on startup where apps don't show up in
> > the systray at all. That is if an application tries to create a systray
> > icon
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128475/#review97542
---
Ship it!
It's unfortunate that this needs to be in the KCM
ivan created this revision.
ivan added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Containment creation relies on the current activity, so
we need to change the current activity when creating
ivan updated the test plan for this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2211
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, #plasma, mart
Cc: plasma-devel, jensreuterberg, abetts, seb
ochurlaud created this revision.
ochurlaud added reviewers: Plasma: Design, Plasma, davidedmundson.
ochurlaud set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
ochurlaud added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
I
ochurlaud updated the summary for this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2212
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: plasma
> On Juli 18, 2016, 9:45 vorm., Luigi Toscano wrote:
> > No review for this?
> >
> > You applied this to kamera, shipped with KDE Applications, and you applied
> > it to master only, which means KDE Applications 16.12 (next December).
> >
> > Questions:
> > - was this intended, or should have
https://bugs.kde.org/show_bug.cgi?id=360339
--- Comment #2 from Haris Tampakopoulos ---
I am currently at 5.7.1 as soon as I update I will try to reproduce and let you
know
--
You are receiving this mail because:
You are on the CC list for the bug.
__
jriddell updated this revision to Diff 5285.
jriddell added a comment.
Update script to Perl and do testing to check it works
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1816?vs=4329&id=5285
REVISION DETAI
jriddell added a comment.
Source Code Pro doesn't seem to be easily downloadable or packaged by any
distro so I don't see that as something distros will accept easily. But feel
free to add it into Kate.
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETA
jriddell added a comment.
Maybe I dismissed Source Code Pro too quickly, I've asked distros for an
opinion on it
https://mail.kde.org/pipermail/kde-distro-packagers/2016-July/000201.html
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://
jriddell added a comment.
http://i.imgur.com/rhZhlzY.png
Oxygen Mono has no bold/italic so nothing removed from status quo by using
Noto Mono
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1816
EMAIL PREFERENCES
h
> On July 10, 2016, 8:49 p.m., Thomas Pfeiffer wrote:
> > Nice feature, but the UI unnecessarily mixes two different interaction
> > patterns: Checkboxes and drag&drop.
> > What I'd prefer to do (and we should introduce that as a general paradigm
> > for such things): Put a box "Hidden tabs" be
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
Plasma/5.7
REVISION DETAIL
https://phabricator.kde.org/D2211
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, #plasm
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEa566273eb80d: Switching activity while
creating it from PlasmaScript (authored by ivan).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 18 Jul 2016 21:34:11 +
Build duration: 38 sec
CHANGE SET
Revision a566273eb80dd2eb40c4fdea3
> On July 18, 2016, 5:49 a.m., Martin Gräßlin wrote:
> > I acknowledge the problem in general, but I think the solution is wrong as
> > this creates now a race condition on startup where apps don't show up in
> > the systray at all. That is if an application tries to create a systray
> > icon
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/270/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 18 Jul 2016 21:39:46 +
Build duration: 18 min
CHANGE SET
Revision bd633d8289b20687f152fb6f90b43fac6d
dfaure added inline comments.
INLINE COMMENTS
> kdeplatformfiledialoghelper.cpp:78
> /*
> * Map a KDE filter string into a Qt one.
> */
Can you explain and document here what this function does, i.e. input args and
return value? It's a bit confusing.
"kde" is a mimetype name, e.g. applica
jriddell added a comment.
http://i.imgur.com/Cv6bgUy.png Source Code Pro
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1816
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jriddel
On Mon, Jul 18, 2016 at 7:03 AM, Sebastian Kügler wrote:
>
> kbroulik:
> * wrote a few ideas for plasma notifications
> https://community.kde.org/Plasma/Notifications
Yes!! Just a note however - the standard you're talking about
is not the actual standard, it's Gnome's own extension of the
stan
mck182 added a comment.
Can you post a screenshot of before/after?
For future reference - any review request that touches the UI should always
be accompanied by a screenshot ;)
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2212
EMAIL PREF
> On July 18, 2016, 5:49 a.m., Martin Gräßlin wrote:
> > I acknowledge the problem in general, but I think the solution is wrong as
> > this creates now a race condition on startup where apps don't show up in
> > the systray at all. That is if an application tries to create a systray
> > icon
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128473/#review97506
---
KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool e
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128484/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128485/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
lbeltrame added a comment.
I've been using this all week without ill side effects. In fact, this solves
an issue I had when testing notmart's p-w branch.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
https://phabricator.kde.org/setting
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128485/#review97585
---
Ship it!
Ship It!
- Martin Gräßlin
On July 19, 2016, 6:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128484/#review97586
---
In KWin it can be seen when e.g. activating Present Windows w
80 matches
Mail list logo
