This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP1b18ec6461c4: Rewrite Window List plasmoid.
(authored by hein).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2089?vs=4962&id=5055
REVIS
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Jul 2016 08:08:20 +
Build duration: 1 min 27 sec
CHANGE SET
Revision 901e76e4b0fbf91a9f4c4
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Jul 2016 08:11:21 +
Build duration: 46 sec
CHANGE SET
Revision 9ade4105e0741bec29fca0ad423
hein reopened this revision.
hein added a comment.
Sorry, I pushed this accidentally. Reopening.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2089
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma
hein added a comment.
Reverted - please continue reviewing so this can actually go in ...
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2089
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma
Cc: bro
I would make a bugreport of it.
(Also I notice that you have a few icons there that don't come with any
padding at all (like trojita icons (hmm you've managed to sort out multiple
IMAP accounts?) and the weird circle one)) which is something we simply can't
fix except by actively fixing all br
https://bugs.kde.org/show_bug.cgi?id=351693
August Rydberg changed:
What|Removed |Added
CC||august.rydb...@gmail.com
--- Comment #4 from A
https://bugs.kde.org/show_bug.cgi?id=351693
--- Comment #5 from August Rydberg ---
Some more info:
Lenovo Yoga 2 Pro @ 1920x1080
Kernel: 4.4.0-24-generic
--
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailin
> On Juli 10, 2016, 6:42 vorm., Eike Hein wrote:
> > New features to libtaskmanager should be implemented on Wayland first.
> > Otherwise they increase the porting effort, which I'm not willing to do
> > (i.e. I'm not going to take any drive-by feature contributions that leave
> > me to figuri
davidedmundson added inline comments.
INLINE COMMENTS
> main.qml:70
>
> -function setOnDesktop(id, desktop) {
> -var service = tasksSource.serviceForSource("tasks");
> -var operation = service.operationDescription("toDesktop");
> -operation.Id = id;
> -operation.desk
I sent this email on the kde-devel mailing list and I was redirected here.
Hi all,
I've been trying to develop some KRunner plug-ins for plasma 5 using Qt
Creator (no cmake) but it seems like they all fail to actually run, so I
wanted to ask here if somebody could help me understand what's going
Hi all,
time ago I've designed a Plasma 4 plasmoid together with a dataengine to
configure and control a process (redshift).
The structure is the following:
- The plasmoid allow the user to start and stop the process, this is done
by running a servicejob provided by the dataengine
- The dataengin
hein marked an inline comment as done.
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in main.qml:70
> You're using the margins from this frame, but you're not even rendering this
> frame anywhere?
> Using the margins from something we're not rendering doesn't make really mak
hein marked 2 inline comments as done.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2089
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma
Cc: davidedmundson, broulik, plasma-devel, jensreuterberg, abe
hein added inline comments.
INLINE COMMENTS
> hein wrote in main.qml:70
> We use this same technique in Kicker and FV and other places. It's the only
> way to get element sizes from a themer and cope with themes that miss certain
> elements. I have asked for better APIs over the years and got a
You're missing this line somewhere:
K_EXPORT_PLASMA_RUNNER(my-test-runner, MyTestRunner)
It exports the big that make it a plugin, with the entry point that krunner
needs.
Also you can then kill your mytestrunner_global.h code, as that's exporting
code for linking against, which is a bit differ
No, I dont, see the last line in mytestrunner.cpp:
https://github.com/Bakuriu/MyTestRunner/blob/master/mytestrunner.cpp#L64
And this is exactly the thing that puzzles me. If I put the .desktop file
in place but I do not provide the .so library, I can see the KRunner load
stating that it is unable
On Sunday 10 July 2016, Simone Gaiarin wrote:
> The problem now is how to manage the configuration.
>
> I know that the plasmoid configuration can be accessed via
> plasmoid.configuration and that I can map the fields in main.xml to the ui
> elements of the config dialog. The problem is how to sy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97267
---
Nice feature, but the UI unnecessarily mixes two different in
On Sun, Jul 10, 2016 at 3:31 PM, Giacomo Alzetta
wrote:
> No, I dont, see the last line in mytestrunner.cpp:
> https://github.com/Bakuriu/MyTestRunner/blob/master/mytestrunner.cpp#L64
>
> You're right.
> And this is exactly the thing that puzzles me. If I put the .desktop file
> in place but I
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128408/#review97273
---
Ship it!
Ship It!
- David Edmundson
On July 9, 2016, 9:
> On July 10, 2016, 6:42 a.m., Eike Hein wrote:
> > New features to libtaskmanager should be implemented on Wayland first.
> > Otherwise they increase the porting effort, which I'm not willing to do
> > (i.e. I'm not going to take any drive-by feature contributions that leave
> > me to figurin
davidedmundson added inline comments.
INLINE COMMENTS
> hein wrote in main.qml:70
> Oh the Math.max() is because the margin sizes differ for some themes and this
> avoids ui jumps in cases like that -- another real world fix ...
The main bug I'm complaining about isn't you using the margins, it
hein marked an inline comment as done.
hein added inline comments.
INLINE COMMENTS
> hein wrote in main.qml:70
> Oh the Math.max() is because the margin sizes differ for some themes and this
> avoids ui jumps in cases like that -- another real world fix ...
Can you please summarize all this int
hein marked an inline comment as not done.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2089
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma
Cc: davidedmundson, broulik, plasma-devel, jensreuterberg,
graesslin added a comment.
> Fixes desktop window losing the keep-below flag
Just saying: this doesn't make sense. Keep-below doesn't matter for a desktop
window. I just checked KWin's source code and the layer of the desktop window
is only determined by the window type. Keep above/below
26 matches
Mail list logo
