GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/138/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 07:33:16 +
Build duration: 11 min
CHANGE SET
Revision b3bcc02a56d5d4816e27b5069e42f2da1e
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb399cd908e53: systemtray container: fix
m_internalSystray nullptr crash (authored by dfaure).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.
hein added a reviewer: broulik.
hein added a comment.
Kai, please have a look.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1831
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: pinakahuja, #plasma, broulik
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
He sat next to me while writing the patch and it works. :)
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1831
EMAIL PREFERENCES
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE110f58471510: Add rule for chromium to
taskmanagerrulesrc for proper grouping.` (authored by pinakahuja).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE6c0b1e542c19: [Device Notifier] Be more
declarative (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D1793?vs=4285&id=4373#toc
REPOSITORY
rPLASMAWORKSPACE Plas
hein created this revision.
hein added a reviewer: davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
This is needed for subsequent feature work which needs to be able
to turn this off.
This review also includes a number
mart added a comment.
even if not optimal i think we should go for it
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1816
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jriddell,
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/139/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 07:59:37 +
Build duration: 15 min
CHANGE SET
Revision b399cd908e53086c1c030d288260fa611c
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP87b7e283a58a: [Pager] Don't update models when
not visible (authored by broulik).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1788?vs=4
broulik abandoned this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1748
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: graesslin, drosca, davidedmundson, plasma-devel, sebas
__
broulik added a comment.
Ping
REPOSITORY
rPOWERDEVIL Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D1735
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasma:_design
Cc: colomar, lueck, graesslin, plasma-devel, sebas
___
mart added a comment.
+1
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D1772
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: mart, plasma-devel, sebas
_
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1757
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, davidedmundson, #plasma, mar
davidedmundson added a comment.
ok, but it'd have to be 5.8 given we're past dependency freeze.
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D1816
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpr
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rPOWERDEVIL Powerdevil
BRANCH
broulik/notifyPeripherals
REVISION DETAIL
https://phabricator.kde.org/D1735
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/em
mart added a comment.
In https://phabricator.kde.org/D1816#34042, @davidedmundson wrote:
> ok, but it'd have to be 5.8 given we're past dependency freeze.
yeah, makes sense, let's go for 5.8
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/140/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 08:19:07 +
Build duration: 20 min
CHANGE SET
Revision 110f5847151000f9e413f56e8c904fc5de
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 08:17:06 +
Build duration: 26 min
CHANGE SET
Revision 87b7e283a58a57ab04c473a068d2895ebeaae
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 08:17:06 +
Build duration: 26 min
CHANGE SET
Revision 87b7e283a58a57ab04c473a068d2895ebeaae
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1838
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein,
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPb003ca6b79a0: [Panel] Reduce duplicate enabled
borders calculation (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D1757?vs=4233&id=4378#toc
REPOSITORY
rPLASMAD
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The length binding was assigni
graesslin updated this revision to Diff 4380.
graesslin added a comment.
Integrated wallpaper configuration. It works (loads and saves correctly),
but the QtQuick integration needs a look from experts
REPOSITORY
rKSCREENLOCKER KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE00fb293d7963: Add a prop to toggle the special
grouping behavior for tasks in demanding… (authored by hein).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/141/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 09:15:18 +
Build duration: 13 min
CHANGE SET
Revision 00fb293d7963e9d077aa59d4f642261e42
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127332/
---
(Updated June 13, 2016, 9:45 a.m.)
Status
--
This change has been ma
https://bugs.kde.org/show_bug.cgi?id=340063
--- Comment #12 from Kai Uwe Broulik ---
Compositing needs to be enabled and the "KScreen helper effect" in Desktop
Effects enabled (only shown when you uncheck the "Exclude internal desktop
effects" in the menu next to the search field). However, the e
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/142/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 09:32:46 +
Build duration: 3 min 26 sec
CHANGE SET
Revision ec92ebbdcca4ec82c10ef96903935
https://bugs.kde.org/show_bug.cgi?id=364217
Kai Uwe Broulik changed:
What|Removed |Added
CC||k...@privat.broulik.de
Resolution|---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128171/
---
Review request for KDE Frameworks and Plasma.
Repository: plasma-framewor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128171/#review96408
---
Ship it!
Ship It!
- Eike Hein
On June 13, 2016, 9:53 a.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128171/#review96407
---
Ship it!
Ship It!
- Martin Gräßlin
On June 13, 2016, 11
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128171/#review96409
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 13, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128152/#review96410
---
Ship it!
Ship It!
- Eike Hein
On June 11, 2016, 2:16 p.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128171/
---
(Updated June 13, 2016, 5:59 a.m.)
Status
--
This change has been ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128152/
---
(Updated June 13, 2016, 10:02 a.m.)
Status
--
This change has been d
dfaure created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
org.kde.plasma.digitalclock/contents/ui/main.qml:51: TypeError: Cannot read
property 'width' of null
REPOSITORY
rPLASMAWORKSPACE Plasma Work
dfaure added a reviewer: mck182.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1840
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, mck182
Cc: plasma-devel, sebas
___
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1840
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefe
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE820f563cc7f6: Fix runtime warning on startup
of digital-clock (authored by dfaure).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1
dfaure created this revision.
dfaure added a reviewer: hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1841
AFFECTED FILES
https://bugs.kde.org/show_bug.cgi?id=102097
Kai Uwe Broulik changed:
What|Removed |Added
Resolution|--- |FIXED
Version Fixed In|
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/143/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 10:25:22 +
Build duration: 4 min 25 sec
CHANGE SET
Revision 820f563cc7f63f43efad5de7d4402
broulik added inline comments.
INLINE COMMENTS
> xwindowtasksmodel.cpp:662
> +
> +// FIXME Hard-coding 64x64 or SizeLarge is not scaling-aware.
>
Can't you make a property where the applet tells it the size it likes to have,
similar to what you do with the drag pixmap size?
REPOSITORY
dfaure added inline comments.
INLINE COMMENTS
> broulik wrote in xwindowtasksmodel.cpp:662
> Can't you make a property where the applet tells it the size it likes to
> have, similar to what you do with the drag pixmap size?
No clue, this "fixme" was already there, I'm only optimizing for speed.
broulik updated this revision to Diff 4386.
broulik added a comment.
Use "when" to not mess with the panel length until we have a containment.
Otherwise we would start and briefly have the panel at 0 size which looks
ugly. This probably was concealed by the old code just throwing an excep
hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dfaure wrote in xwindowtasksmodel.cpp:662
> No clue, this "fixme" was already there, I'm only optimizing for speed. I'll
> let Eike reply to this.
64 is the valu
Kanedias updated this revision to Diff 4387.
Kanedias marked 8 inline comments as done.
Kanedias added a comment.
Changed getter methods to public as we'll need them from KWin side.
+ Doxygen typo
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1231?
This revision was automatically updated to reflect the committed changes.
Closed by commit rPOWERDEVIL550bdc40d4e8: Merge branch
'broulik/notifyPeripherals' (authored by broulik).
REPOSITORY
rPOWERDEVIL Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1735?vs=4163&id=4388
R
dfaure added inline comments.
INLINE COMMENTS
> hein wrote in xwindowtasksmodel.cpp:665
> Why not use the one from line 654?
Oops, didn't see it. I'll adjust the patch.
However this makes me wonder, given this code
if (!data.icon.name().isEmpty()) {
return data.url;
}
do I still nee
graesslin added a comment.
> [14:17] jensreu: so you ack that we remove the blurred variant
in the lockscreen by default?
> [14:17] mgraesslin: yes
So the problematic area of how to get the blurred wallpaper is scratched.
REPOSITORY
rKSCREENLOCKER KScreenLocker
REVISION DETAIL
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/144/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 12:24:52 +
Build duration: 17 min
CHANGE SET
Revision 05d459eca9c0cf22496a6578a4474714d2
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
LGTM
REPOSITORY
rKWIN KWin
BRANCH
cleanup-static-fade-alpha-picture
REVISION DETAIL
https://phabricator.kde.org/D1733
EMAIL PREFERENCES
https://phabri
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
LGTM
REPOSITORY
rKWIN KWin
BRANCH
cleanup-static-blend-picture
REVISION DETAIL
https://phabricator.kde.org/D1731
EMAIL PREFERENCES
https://phabricator
jriddell created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Add Appinfo metadata file
TEST PLAN
build and install
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
master
REVISION DETAIL
https
sebas requested changes to this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision now requires changes to proceed.
Should also have a screenshot?
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1844
EMAIL PREFERENCES
htt
jriddell added reviewers: Plasma, Visual design and promo, mak.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1844
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jriddell, #plasma, #visual_design_and_promo, mak
Cc
bshah added inline comments.
INLINE COMMENTS
> plasma-desktop.metainfo.xml:11
> +
> +plasma-desktop
> +
This is wrong, no? there is no plasma-desktop binary anymore? or you mean
package name?
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D184
I've submitted a review for a plasma-desktop metadata file.
https://phabricator.kde.org/D1844
But I was surprised to see the metadata format doesn't support many
types. Shouldn't something like Plasma widgets be a good target for
appstream metadata?
Jonathan
On 7 April 2016 at 16:35, Matthias K
hein added inline comments.
INLINE COMMENTS
> dfaure wrote in xwindowtasksmodel.cpp:665
> Oops, didn't see it. I'll adjust the patch.
>
> However this makes me wonder, given this code
>
> if (!data.icon.name().isEmpty()) {
> return data.url;
> }
>
> do I still need to handle the case
jriddell updated this revision to Diff 4392.
jriddell added a comment.
fix binary name
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1844?vs=4391&id=4392
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1844
AFFECTED FILES
jriddell added a comment.
In https://phabricator.kde.org/D1844#34142, @sebas wrote:
> Should also have a screenshot?
No such option in metadata XML files it seems
https://techbase.kde.org/MetaInfo/Components
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://p
jriddell added a comment.
I wonder if it should go into plasma-workspace too
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1844
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jriddell, #visual_design_and_promo
bshah added a comment.
In https://phabricator.kde.org/D1844#34149, @jriddell wrote:
> fix binary name
Well, even plasmashell is not provided by this :-D should go to
plasma-workspace probably
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.or
mak added a comment.
In https://phabricator.kde.org/D1844#34142, @sebas wrote:
> Should also have a screenshot?
Normally I would say "yes", but since this is a so-called generic component,
which means that it will be possible to search for it with cli tools and
install it easily
2016-06-13 14:54 GMT+02:00 Jonathan Riddell :
> I've submitted a review for a plasma-desktop metadata file.
> https://phabricator.kde.org/D1844
> But I was surprised to see the metadata format doesn't support many
> types. Shouldn't something like Plasma widgets be a good target for
> appstream me
jriddell updated this revision to Diff 4393.
jriddell added a comment.
- seems it changed preferred directory
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1844?vs=4392&id=4393
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
jriddell updated this revision to Diff 4394.
jriddell added a comment.
- add screenshot
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1844?vs=4393&id=4394
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1844
AFFECTED FILE
Minutes Plasma 'hangout', 13-6-2016, 12:00 CET
Present: mgraesslin, bshah, notmart, Sho, kbroulik, sebas, Riddell
mgraesslin:
* lost my notes for second last week due to X crashing
* many bug fixes which are open on phab, please review I want them integrated
soon as I need to do more fixes which
mak added inline comments.
INLINE COMMENTS
> mak wrote in plasma-desktop.metainfo.xml:3
> This should ideally be a reverse-domain-name, to fit the general style of
> AppStream unique IDs.
> So something like "org.kde.plasmashell" or "org.kde.plasma-desktop".
> See
> https://www.freedesktop.org/
jriddell updated this revision to Diff 4395.
jriddell added a comment.
- add screenshot
- use e-c-m install path
- rename appstream file
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1844?vs=4394&id=4395
BRANCH
master
REVISION DETA
jriddell updated this revision to Diff 4396.
jriddell marked 2 inline comments as done.
jriddell added a comment.
- remove width/height, they get ignored. use a reverse domain name id
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1844?vs=
jriddell updated this revision to Diff 4397.
jriddell marked 3 inline comments as done.
jriddell added a comment.
- better image caption
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1844?vs=4396&id=4397
BRANCH
master
REVISION DETAIL
mak added inline comments.
INLINE COMMENTS
> CMakeLists.txt:158
> endif()
> +install(FILES "${CMAKE_CURRENT_BINARY_DIR}/plasma-desktop.metainfo.xml"
> DESTINATION ${METAINFODIR})
> feature_summary(WHAT ALL INCLUDE_QUIET_PACKAGES
> FATAL_ON_MISSING_REQUIRED_PACKAGES)
I might be wrong with tha
> On Jun 13, 2016, at 6:20 AM, Sebastian Kügler wrote:
> notmart:
> * attending store meeting
> * systray gives applets a screen
> * Kirigami: better logic and explicit api for the "reachable" mode (all ui
> slides down)
> ** a new component for a toolbar in the header: to be used only in deskt
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINd49fba5d30cb: [libkwinxrenderutils] Clean up static blend
picture before going down (authored by graesslin).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1731?vs=41
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN1b40feca3a11: SceneXRender::Window uses a static
XRenderPicture which it didn't clean up (authored by graesslin).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1733?
graesslin added inline comments.
INLINE COMMENTS
> test_remote_access.cpp:161
> +// client fd is different, not subject to check
> +QVERIFY(rbuf->width() == 50);
> +QVERIFY(rbuf->height() == 50);
use QCOMPARE to test two values. If it fails with QCOMPARE you get the values
it actual
dfaure updated this revision to Diff 4400.
dfaure added a comment.
Simplify as suggested
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1841?vs=4385&id=4400
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1841
AFFECTED
On Monday 13 June 2016, Dirk Hohndel wrote:
> > size, should be more reliable, should resize more smoothly
>
> Is current Kirigami master expected to be stable?
> We get a bunch of reports that the action buttons either don't work at all
> or only work very randomly...
i seem to be able to reprod
> i seem to be able to reproduce it on android, i suspect Qt on andoid (or
> maybe ios) is not adjusting its Qt::startDragDistance based on dpi...
I bet it doesn't on Android. That's why we also have a hack for the flickable
scroll speed which still isn't optimal.
On ios the system itself alrea
Kanedias updated the test plan for this revision.
Kanedias updated this revision to Diff 4401.
Kanedias marked 12 inline comments as done.
Kanedias added a comment.
Review comments & cleanup
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1231?vs=4387&
Kanedias marked 12 inline comments as done.
Kanedias added inline comments.
INLINE COMMENTS
> graesslin wrote in test_remote_access.cpp:161
> use QCOMPARE to test two values. If it fails with QCOMPARE you get the values
> it actually had. With QVERIFY you only see that it failed
Got it
> graes
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/145/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 14:25:56 +
Build duration: 10 min
CHANGE SET
Revision 80971307b459144bcd71599f5729f83065
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/146/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 14:51:38 +
Build duration: 12 min
CHANGE SET
Revision 42b64e1bd2c64a43f47a1f9d0b8895e3f3
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When you hover an applet and r
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/147/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 15:07:17 +
Build duration: 11 min
CHANGE SET
Revision b77a13079c9a44294a41270565ef3f6a10
On Monday 13 June 2016, Dirk Hohndel wrote:
> >
> > size, should be more reliable, should resize more smoothly
>
> Is current Kirigami master expected to be stable?
> We get a bunch of reports that the action buttons either don't work at all
> or only work very randomly...
with the latest commit
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1841
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, hein
Cc:
dfaure closed this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1841
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, hein
Cc: broulik, plasma-devel, sebas
broulik retitled this revision from "[Notifications] Limit notification size
and scroll to the bottom if needed" to "[Notifications] Limit notification size
and add scroll bar if needed".
broulik updated the summary for this revision.
broulik updated the test plan for this revision.
broulik set t
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/148/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 16:49:52 +
Build duration: 9 min 25 sec
CHANGE SET
Revision 07d950bded2b8e50eb330fab1b23
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/149/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 17:05:18 +
Build duration: 1 min 56 sec
CHANGE SET
Revision 9ffcb3178cea8b06fdf964fd05cf2
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/38/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 13 Jun 2016 17:05:47 +
Build duration: 2 min 23 sec
CHANGE SET
Revision 9ffcb3178cea8b06fdf
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128052/#review96424
---
Ping? I'd hate to miss the deadline again, this feature has b
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When you click an item it
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1847
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: brou
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1845
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik,
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The highlight currently o
1 - 100 of 164 matches
Mail list logo
