Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/#review95574 --- Ship it! always accept - Marco Martin On May 17, 2016,

Re: Review Request 127946: [KDeclarative] [KCMShell] Add "authorized" wrapper around KAuthorize::authorizeControlModules

2016-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127946/#review95575 --- Ship it! Ship It! - Marco Martin On May 17, 2016, 6:31

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-18 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- (Updated May 18, 2016, 11:07 a.m.) Review request for kde-workspace and P

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-18 Thread Jonathan Marten
> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Review Request 127954: force icon themes explicitly via new testing helper function

2016-05-18 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127954/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: p

Re: Review Request 127954: force icon themes explicitly via new testing helper function

2016-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127954/#review95587 --- Ship it! Ship It! - Marco Martin On May 18, 2016, 11:40

Re: Review Request 127954: force icon themes explicitly via new testing helper function

2016-05-18 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127954/ --- (Updated May 18, 2016, 12:53 p.m.) Status -- This change has been ma

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/ --- (Updated Mai 18, 2016, 1:20 nachm.) Review request for Plasma. Reposito

[Differential] [Request, 5,664 lines] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-18 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change introduces support for text input. Text input allows to compose text on the server (e.g. th

[Differential] [Commented On] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-18 Thread Martin Gräßlin
graesslin added a comment. Sorry for the large review. The fact that it supports two interfaces made it rather complex. When reviewing please check whether the exposed methods sound good, are well documented, etc. Please also verify whether the implementation actually matches what is de

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/#review95589 --- Ship it! Ship It! - Marco Martin On May 18, 2016, 1:20

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/ --- (Updated May 18, 2016, 8:42 p.m.) Status -- This change has been mar

Re: Review Request 127946: [KDeclarative] [KCMShell] Add "authorized" wrapper around KAuthorize::authorizeControlModules

2016-05-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127946/ --- (Updated May 18, 2016, 5:43 p.m.) Status -- This change has been mar

[Differential] [Request, 21 lines] D1632: [Battery/Clock] Offer KCM access only if allowed

2016-05-18 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove the context menus

[Differential] [Request, 6 lines] D1633: [Kickoff/Trash] Offer KCM access only if allowed

2016-05-18 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove the context menus that

[Differential] [Updated, 8 lines] D1633: [Kickoff/Trash] Offer KCM access only if allowed

2016-05-18 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 3863. broulik added a comment. It's kcmtrash, not trash. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1633?vs=3862&id=3863 REVISION DETAIL https://phabricator.kde.org/D1633 AFFECTED FILES applet

Re: Review Request 127753: [taskmanager] Fixing typos

2016-05-18 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127753/ --- (Updated May 18, 2016, 12:27 p.m.) Status -- This change has been ma

Re: DWD HIG Draft

2016-05-18 Thread Ken Vermette
Update; After feedback we made some moderately heavy changes to teh DWD requirements, namely removing/changing 'priority groups' in favour of 'layouts'. Instead of the application firing off widgets with a "spray & pray" manner via priority groups, we're using layouts. With layouts the applicatio

[Differential] [Commented On] D1291: Add microphone volume OSD

2016-05-18 Thread andreaska (Andreas Kainz)
andreaska added a comment. done http://commits.kde.org/breeze-icons/833beda436b64c9b4a692d4b4dbe95c0f7cab35f REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH mic-osd REVISION DETAIL https://phabricator.kde.org/D1291 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Closed] D1291: Add microphone volume OSD

2016-05-18 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf950f7843e60: Add microphone volume OSD (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1291?vs=3373&id=3867#toc REPOSITORY rPLASMAWORKSPACE Plasma Workspace

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 93 - Still Unstable!

2016-05-18 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 20:34:33 + Build duration: 12 min CHANGE SET Revision f950f7843e6006656958421d22dbcde1e51

[Differential] [Request, 14 lines] D1635: [OSD] Make volume OSD thresholds consistent with Volume Applet

2016-05-18 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The volume applet would s

Re: status of kde/plasma kiosk framework in kf5

2016-05-18 Thread Mag. Weissel Thomas
first of all... thank you all so much for your engagement.. i can't say it in other words than.. you rock! i tried the toolbars action restriction but... This can be blocked with: action/options_show_toolbar=false ...i still could hide toolbars in dolphin and gwenview for example.. what did

[Differential] [Commented On] D1635: [OSD] Make volume OSD thresholds consistent with Volume Applet

2016-05-18 Thread drosca (David Rosca)
drosca added a comment. > I wonder why we use 0, 25, 75, 100 though and not 0, 33, 66, 100 Not sure, but the medium threshold looks fine to me because most of the times you keep your volume in lower levels (because >50% is too loud), so it makes sense to show "medium" icon (one bar fille

[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

2016-05-18 Thread dfaure (David Faure)
dfaure added a comment. Right. kservicetest was still failing too, but after adding debug output it now passes every time I committed the additional debug output in kdirwatch and enabled kdirwatch debug output in filetypestest. Can you kick a build again and let me know the result?

Re: DWD HIG Draft

2016-05-18 Thread Martin Graesslin
On Wednesday, May 18, 2016 4:21:20 PM CEST Ken Vermette wrote: > Update; > > After feedback we made some moderately heavy changes to teh DWD > requirements, namely removing/changing 'priority groups' in favour of > 'layouts'. > > Instead of the application firing off widgets with a "spray & pray"

[Differential] [Updated, 5,715 lines] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-18 Thread Martin Gräßlin
graesslin updated this revision to Diff 3872. graesslin added a comment. More documentation REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1631?vs=3860&id=3872 BRANCH graesslin/text-input REVISION DETAIL https://phabricator.kde.org/D1631 AFFECT

[Differential] [Updated, 5,715 lines] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-18 Thread Martin Gräßlin
graesslin updated this revision to Diff 3873. graesslin added a comment. Some method renaming: - on client: activate -> enable, deactivate -> disable - on server: made setters not sound like getters REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org