[Differential] [Commented On] D1347: Checking whether the m_textTexture is not null before dereferencing it

ivan added a comment. That is what static analysis is for - to catch bugs that have not been exposed yet :) REPOSITORY rKWIN KWin BRANCH ivan/null-check-2 REVISION DETAIL https://phabricator.kde.org/D1347 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Closed] D1346: Checking whether m_topLevel is not null before getting its property

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN2c95a4e6b9ad: Checking whether m_topLevel is not null before getting its property (authored by ivan). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1346?vs=3197&id=3

[Differential] [Closed] D1347: Checking whether the m_textTexture is not null before dereferencing it

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf06dff3390b6: Checking whether the m_textTexture is not null before dereferencing it (authored by ivan). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1347?vs=3198&i

[Differential] [Closed] D1348: Testing whether m_lastCreatedSettings is not null before calling its method

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN1fef4760bf1d: Testing whether m_lastCreatedSettings is not null before calling its method (authored by ivan). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1348?vs=3

[Differential] [Request, 2,675 lines] D1355: Introduce an x11/standalone platform plugin for use in kwin_x11

graesslin created this revision. graesslin added reviewers: Plasma, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Move the x11 plugin sources into a x11/windowed directory Preparation step for having two x11

[Differential] [Updated] D1353: Move backends/ to plugins/platforms/

graesslin added a dependent revision: D1355: Introduce an x11/standalone platform plugin for use in kwin_x11. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1353 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, seba

[Differential] [Updated] D1355: Introduce an x11/standalone platform plugin for use in kwin_x11

graesslin added a dependency: D1353: Move backends/ to plugins/platforms/. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1355 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: plasma-devel, sebas __

[Differential] [Changed Subscribers] D1356: [kstyle] Only create Wayland shadows for top-level widgets

graesslin added a subscriber: plasma-devel. graesslin added a project: Plasma. REPOSITORY rOXYGEN Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D1356 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, hpereiradacosta Cc: plasma

[Differential] [Accepted] D1356: [kstyle] Only create Wayland shadows for top-level widgets

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ship it ! I wonder if this shouldn't actually go "upstream", for both the X11 and the Wayland implementation. Is there a reason why we should have, on X11 shadows instal

Re: Questions on Plasma i18n strings, offset=39

On Friday, April 08, 2016 02:06:07 AM David Edmundson wrote: > ​I'm taking tasks 50-59. > > if a few people grab another block of 10, we'll be done in no time. I'm on 60-69. Should these fixes go into the stable branch or just master? -- sebas http://www.kde.org | http://vizZzion.org _

[Differential] [Request, 81 lines] D1357: [autotest] Extend tests for Dpms modes

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Now also tests: - requesting mode from client side - update supported change on server side REPOS

Re: Questions on Plasma i18n strings, offset=39

On Friday 08 April 2016 11:37:27 Sebastian Kügler wrote: > On Friday, April 08, 2016 02:06:07 AM David Edmundson wrote: > > ​I'm taking tasks 50-59. > > > > if a few people grab another block of 10, we'll be done in no time. > > I'm on 60-69. > > Should these fixes go into the stable branch or j

Re: Questions on Plasma i18n strings, offset=39

On Friday, April 08, 2016 01:54:07 AM Alexander Potashev wrote: > 60. Please clarify in the msgctxt that %1 is the name of the device, > not name of a medium (e.g. optical disc). > plasma_engine_devicenotifications.po-22-#: ksolidnotify.cpp:156 > plasma_engine_devicenotifications.po-23-msgid "This

[Differential] [Closed] D1356: [kstyle] Only create Wayland shadows for top-level widgets

This revision was automatically updated to reflect the committed changes. Closed by commit rOXYGENc5edbc8365a6: [kstyle] Only create Wayland shadows for top-level widgets (authored by graesslin). REPOSITORY rOXYGEN Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1356?vs=3

Re: Questions on Plasma i18n strings, offset=39

On Friday, April 8, 2016 11:37:27 AM CEST Sebastian Kügler wrote: > On Friday, April 08, 2016 02:06:07 AM David Edmundson wrote: > > ​I'm taking tasks 50-59. > > > > if a few people grab another block of 10, we'll be done in no time. > > I'm on 60-69. > > Should these fixes go into the stable br

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 25 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Apr 2016 09:42:40 + Build duration: 1 hr 9 min CHANGE SET Revision 615c5c7fd0c197b23940df935729521

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 26 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Apr 2016 10:56:53 + Build duration: 16 min CHANGE SET Revision c37beafa92dd73c95df09b2005879bba823

Re: Questions on Plasma i18n strings, offset=39

On Friday, April 08, 2016 12:26:47 PM Martin Graesslin wrote: > On Friday, April 8, 2016 11:37:27 AM CEST Sebastian Kügler wrote: > > On Friday, April 08, 2016 02:06:07 AM David Edmundson wrote: > > > ​I'm taking tasks 50-59. > > > > > > if a few people grab another block of 10, we'll be done in no

[Differential] [Accepted] D1357: [autotest] Extend tests for Dpms modes

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. INLINE COMMENTS autotests/client/test_wayland_output.cpp:479 Could be even more extensive: Switch On/Off with unsupported, setting unsupported when it's already unsupported and checkin

Re: Questions on Plasma i18n strings, offset=39

On Fri, Apr 8, 2016 at 12:54 AM, Alexander Potashev wrote: > Hi, > > (This is a follow up to > https://mail.kde.org/pipermail/plasma-devel/2016-March/050714.html. > Because only a few of my questions/requests from that thread were > addressed, I'm going to create 30+ bug reports at bugs.kde.org, s

Re: Questions on Plasma i18n strings, offset=39

On Apr 8, 2016 14:18, "Sebastian Kügler" wrote: > > On Friday, April 08, 2016 12:26:47 PM Martin Graesslin wrote: > > On Friday, April 8, 2016 11:37:27 AM CEST Sebastian Kügler wrote: > > > > > > Should these fixes go into the stable branch or just master? > > > > depends, if it introduces new tra

[Differential] [Closed] D1352: Correctly translate combo box in media frame plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS2700c2f7c5d5: Correctly translate combo box in media frame plasmoid (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1352?vs=3203&id=3217#toc REPOSITORY

Re: Questions on Plasma i18n strings, offset=39

On Friday, April 08, 2016 03:27:56 PM Alexander Potashev wrote: > > I've pushed the "pure typo fixes" to stable, rest is only in master. > > Sorry for being late here, > > Only addition of previously untranslated strings can go into stable. If you > already committed typo fixed to stable, please

Plasma Mobile Development meeting notes

Hello there, Here is log for Plasma Mobile Future development meeting on 8th April 2016. Updated Kanban board is at: https://phabricator.kde.org/project/board/28/ Kirigami kanban https://phabricator.kde.org/project/board/84/ (i feel having it as a separate project would make people ignore it even

Re: Plasma Mobile Development meeting notes

On Fri, Apr 8, 2016 at 6:26 PM, Bhushan Shah wrote: > Here is log for Plasma Mobile Future development meeting on 8th April 2016. Those were minutes and log is attached in this one. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode [13:31:03] mgraesslin, bshah, apol, ahoney

[Differential] [Request, 13 lines] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In CMake we check whether Qt5::QVirtualKeyboardPlugin is available in Qt5Gui_PLUGINS variable. If it is

[Differential] [Accepted] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1359 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

[Differential] [Accepted] D1355: Introduce an x11/standalone platform plugin for use in kwin_x11

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Looks sane to me. REPOSITORY rKWIN KWin BRANCH x11-platform-plugin REVISION DETAIL https://phabricator.kde.org/D1355 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[Differential] [Updated] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

graesslin marked 2 inline comments as done. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1359 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: davidedmundson,

[Differential] [Updated, 24 lines] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

graesslin updated this revision to Diff 3220. graesslin added a comment. Write to a well defined QML property that virtual keyboard is available And also address the requested changes. REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1359

Re: Questions on Plasma i18n strings, offset=39

On Friday 08 April 2016 01:54:07 Alexander Potashev wrote: > 71. This should not be translatable. > plasmanetworkmanagement-kded.po-492-#. i18n: ectx: property (text), > widget (QLabel, labelText) > plasmanetworkmanagement-kded.po-493-#. i18n: ectx: property (text), > widget (QLabel, labelIcon) >

[Differential] [Accepted] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

bshah accepted this revision. bshah added a reviewer: bshah. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1359 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, Plasma, bs

[Differential] [Request, 47 lines] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The virtual keyboard is integreted through a Loader and guarded by a property which is set from the ksc

[Differential] [Updated] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

graesslin added a dependency: D1359: Support for QT_IM_MODULE qtvirtualkeyboard. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-d

[Differential] [Updated] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

graesslin added a dependent revision: D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1359 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Commented On] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

graesslin added a comment. F106348: Spectacle.T13280.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, P

[Differential] [Updated] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

graesslin added a task: T2177: Virtual Keyboard for lock screen. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1359 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, Plasma

[Differential] [Updated] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

graesslin added a task: T2177: Virtual Keyboard for lock screen. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

Re: Questions on Plasma i18n strings, offset=39

On Friday 08 April 2016 01:54:07 Alexander Potashev wrote: > 75. Translations for powerdown/suspend/... actions should be shared > between all powerdevil*config.po files, they are currently duplicated, > making them hard to maintain. Please share the code between the > respective configuration dia

[Differential] [Closed] D1357: [autotest] Extend tests for Dpms modes

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDa829cfba4dc2: [autotest] Extend tests for Dpms modes (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1357?vs=3214&id=3222 REVISIO

Re: Questions on Plasma i18n strings, offset=39

On Fri, Apr 8, 2016 at 2:31 PM, Marco Martin wrote: > > > passworddialog.ui:61 plasmanetworkmanagement-kded.po-495-msgid > "TextLabel" > > how can the string be made untranslatable from the ui file? > > Fixed > -- > Marco Martin > ___ > Plasma-devel m

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 27 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Apr 2016 13:35:12 + Build duration: 16 min CHANGE SET Revision 7c96cb370a0b7dd92658d9d80cbf7d4f9bb

Re: Questions on Plasma i18n strings, offset=39

On Friday 08 April 2016 01:54:07 Alexander Potashev wrote: > 79. Please make this a checkable pushbutton instead of a checkbox. > (Sorry for letting a request unrelated to i18n here...) > themeexplorer.po-234-#: package/contents/ui/main.qml:261 > themeexplorer.po-235-msgid "Show Margins" hmm, tha

libtaskmanager rewrite available

My ongoing work on the libtaskmanager rewrite and applet adaptation is now at: kde:clones/plasma-workspace/hein/libtmng (library) kde:clones/plasma-desktop/hein/libtmng (applet) Master branch for both, libtaskmanagerng/ and applets/{taskmanagerng,icontasksng} respectively. Both the library

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127575/#review94433 --- Ship it! Ship It! - Marco Martin On April 5, 2016, 2:32

experiment: cmake macro to extract and package breeze icons for use in kirigami applications

Hi all, a problem i'm getting in order to make a reasonably multiplatform application I don't think would be a good thing to package the whole breeze icon set for each application (storage required for a simple app is ridiculous already) I tried the approach of doing a cmake function that downloa

Autologin from Settings, User Management

Hi, Having just switched to Plasma 5 I went into Settings and under User Management I enabled autologin for my user. I discovered this wasn't working and then started User Management from the command line and noticed an error. It turns out User Management is using accountsservice under the ho

Re: Review Request 127585: integrate pasma-pa kcm docs properly into helpsystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127585/ --- (Updated April 8, 2016, 7:57 nachm.) Review request for Documentation and

Re: Review Request 127585: integrate pasma-pa kcm docs properly into helpsystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127585/#review94439 --- Ship it! - Yuri Chornoivan On Квітень 8, 2016, 7:57 післ

Re: Review Request 127585: integrate pasma-pa kcm docs properly into helpsystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127585/ --- (Updated April 8, 2016, 8:08 p.m.) Status -- This change has been ma

Re: appstream in Plasma

On Donnerstag, 7. April 2016 21:11:39 CEST Kai Uwe Broulik wrote: > > In the case of the systemd KCM, you could declare that to be an addon to > > Systemsettings... > I like that idea. There's many handy 3rd party kcms hardly anybody knows > about. I could imagine searching for system settings in t

Re: appstream in Plasma

On Donnerstag, 7. April 2016 17:35:48 CEST Matthias Klumpp wrote: > 2016-04-07 15:08 GMT+02:00 Jonathan Riddell : > > Martin's thread on metadata got me wondering about if we should have > > appstream files in Plasma. It would be nice to have plasma-desktop in > > software installers for people wh

Re: metadata.yaml for Plasma projects?

On Donnerstag, 7. April 2016 11:41:25 CEST Martin Graesslin wrote: > Hi Plasmates, > > an idea for better documentation is to introduce some metadata similar like > what frameworks have. This could be useful for potential devs who want to > contribute, but also for distributions as in that way: >