[Differential] [Commented On] D1066: Fix saving correct length of panel

drosca added a comment. The problem is that PanelView::length() is always set to Layout.preferredSize, which says nothing about the actual panel length. PanelView::length() seems to be used only for restoring size of panel, but in most (all?) cases it gets overridden by minimumLength/maximum

[Differential] [Commented On] D1066: Fix saving correct length of panel

mart added a comment. In https://phabricator.kde.org/D1066#20181, @davidedmundson wrote: > this is a binding loop. > > PanelView.cpp has > > setResizeMode(QuickViewSharedEngine::SizeRootObjectToView); > > > so we resize the window to the root object, then resize the root

[Differential] [Commented On] D1066: Fix saving correct length of panel

mart added inline comments. INLINE COMMENTS desktoppackage/contents/views/Panel.qml:134 conceptually, this is actually correct (wether it actually works, is another thing ;)) the view is supposed to resize itself over the preferred size of the containment, as long as is in the maximum/min

[Differential] [Abandoned] D1066: Fix saving correct length of panel

drosca abandoned this revision. drosca added a comment. I see it now, sorry. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1066 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, davidedmundson Cc:

[Differential] [Commented On] D1066: Fix saving correct length of panel

davidedmundson added a comment. We need knowledge of three things: - min, max - preferred/implicit size - current size min, max are pretty clear current is the root.width (or panelView.width as they're the same thing) preferred is what is currently panel.length by mashin

[Differential] [Commented On] D1066: Fix saving correct length of panel

davidedmundson added a comment. No need to apologise, I think you've highlighted something that is wrong and definitely a bit confusing. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1066 EMAIL PREFERENCES https://phabricator.kde.org/settings/pa

Re: Review Request 127260: Experiment: cache svg icons from icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/ --- (Updated March 4, 2016, 11:04 a.m.) Review request for Plasma. Changes

[Differential] [Commented On] D1066: Fix saving correct length of panel

drosca added a comment. It would probably be worth for 5.7 to rename panel.length to panel.preferredLength. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1066 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dr

[Differential] [Commented On] D1066: Fix saving correct length of panel

mart added a comment. > I don't understand what you mean about restoring. > We should restore the min and max, then the content size comes from the contents - we can't save that as that doesnt make much sense. yeah, you're right. right now it saves and restores "length". that should

[Differential] [Request, 2 lines] D1069: Fix length returned from PanelView::geometryByDistance

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY PanelView::length() is not actual length. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH geometry-by-distance (branched from master)

[Differential] [Commented On] D1066: Fix saving correct length of panel

mart added a comment. In https://phabricator.kde.org/D1066#20228, @drosca wrote: > It would probably be worth for 5.7 to rename panel.length to panel.preferredLength. the config entry, is probably better to just remove it. the property, is not much important the name i think, si

[Differential] [Commented On] D1069: Fix length returned from PanelView::geometryByDistance

drosca added a comment. I'm not sure if this should go to Plasma/5.6 as it exposes a bug in ContainmentInterface::adjustToAvailableScreenRegion. Fun fact, it was working mostly alright with the wrong available region :D The bug is that it now basically operates on available rect (and not

[Differential] [Commented On] D1069: Fix length returned from PanelView::geometryByDistance

mart added a comment. hmm, how this can expose that bug in particular? seems quite unrelated REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1069 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 2 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Mar 2016 09:15:55 + Build duration: 1 min 57 sec CHANGE SET Revision bcdaf29dceb0de15495a49

[Differential] [Commented On] D1069: Fix length returned from PanelView::geometryByDistance

drosca added a comment. availableScreenRegion is constructed from screen region minus panel rects (and panel rect = geometryByDistance(0)) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1069 EMAIL PREFERENCES https://phabricator.kde.org/setti

[Differential] [Commented On] D1069: Fix length returned from PanelView::geometryByDistance

drosca added a comment. Scrath that, it's the Dialog positioning that uses rect instead of region (and that's unrelated to this). ContainmentInterface::adjustToAvailableScreenRegion is fine. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1069

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 3 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Mar 2016 11:36:55 + Build duration: 1 min 48 sec CHANGE SET Revision d815d41460206ac582

[Differential] [Request, 12 lines] D1070: Make panel scripting setLength set min and max length

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Setting the length of the panel doesn't do anything useful as it's overwritten from the QML side as soon as it loads contents. However we need to keep API on the sc

[Differential] [Updated] D1070: Make panel scripting setLength set min and max length

davidedmundson added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1070 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: plasma-devel __

[Differential] [Commented On] D1070: Make panel scripting setLength set min and max length

mart added a comment. hmm, this quite risks to lose min and max settings in unwanted moments.. do you know exactly from where setLength is called and where/when the problem happens? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1070 EMAIL PR

[Differential] [Commented On] D1069: Fix length returned from PanelView::geometryByDistance

davidedmundson added a comment. +1 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1069 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: davidedmundson, mart, plasma-devel __

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 3 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Mar 2016 12:11:41 + Build duration: 1 min 25 sec CHANGE SET Revision 2ec84403f3ef7fb60ca7

Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127277/ --- Review request for Plasma. Repository: plasma-framework Description ---

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 4 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/4/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Mar 2016 13:24:16 + Build duration: 1 min 41 sec CHANGE SET Revision cea872505382d4ddbd08a1

Re: Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127277/#review93161 --- Could this be covered by a test? It's bound to break somewhen

[Differential] [Request, 11 lines] D1072: Make sure desktop toolbox has integer and even size

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Fixes one pixel gap when positioned on the right side. Also enable clipping only when animation is running. REPOSITORY rPLASMADESKTOP Plas

Review Request 127274: use connectedOutputs instead of outputs for ShellCorona::numScreens()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127274/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa

Re: Review Request 127274: use connectedOutputs instead of outputs for ShellCorona::numScreens()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127274/#review93166 --- Ship it! Makes sense. - Aleix Pol Gonzalez On March 4,

Re: Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127277/#review93168 --- Ship it! yep, the patch is correct... +1 for adding a test

Re: Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

> On March 4, 2016, 4:29 p.m., Marco Martin wrote: > > yep, the patch is correct... > > +1 for adding a test tough I'm for adding test too, but there are currently no tests in plasma-workspace and also I think it won't be easy to test it. So maybe a good thing to look into during sprint next w

Re: Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

> On March 4, 2016, 4:29 p.m., Marco Martin wrote: > > yep, the patch is correct... > > +1 for adding a test tough > > David Rosca wrote: > I'm for adding test too, but there are currently no tests in > plasma-workspace and also I think it won't be easy to test it. So maybe a > good thing

Re: Review Request 127274: use connectedOutputs instead of outputs for ShellCorona::numScreens()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127274/ --- (Updated March 4, 2016, 5:36 p.m.) Status -- This change has been ma

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 4 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/4/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Mar 2016 17:37:02 + Build duration: 1 min 29 sec CHANGE SET Revision 33e91b85fd65e968c847

[RFC-PATCH] Don't show empty pages on the right

When building Subsurface-mobile against Qt 5.6.0 RC we are observing an odd problem with Kirigami: if the window is wide enough to show more than one page (e.g., a device in landscape mode), the page stack always shows the "top" page on the left edge and empty space to the right of it. With earlie

Re: [RFC-PATCH] Don't show empty pages on the right

On Friday 04 March 2016 10:09:45 Dirk Hohndel wrote: > > The patch below seems to fix the problem, but I'm not sure it's the right > patch... Marco, Sebastian, comments? > I think the patch is good for master. Will required further testing on the refactor as pagerow changed a lot there -- Marc

Re: [RFC-PATCH] Don't show empty pages on the right

On Fri, Mar 04, 2016 at 07:48:05PM +0100, Marco Martin wrote: > On Friday 04 March 2016 10:09:45 Dirk Hohndel wrote: > > > > The patch below seems to fix the problem, but I'm not sure it's the right > > patch... Marco, Sebastian, comments? > > > > I think the patch is good for master. > Will req

Review Request 127280: Fix memory leak in icon item test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127280/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 127280: Fix memory leak in icon item test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127280/#review93175 --- There is a cleanup that deletes all children, I don't think t

Re: Review Request 127260: Experiment: cache svg icons from icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/#review93174 --- Given how many troubles we've had (and still have) with cache

Re: Review Request 127280: Fix memory leak in icon item test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127280/ --- (Updated March 4, 2016, 8:52 p.m.) Status -- This change has been di

Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127282/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127282/#review93177 --- Fix it, then Ship it! autotests/iconitemtest.cpp (line 29

Re: Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

> On March 4, 2016, 10:23 p.m., David Edmundson wrote: > > autotests/iconitemtest.cpp, line 299 > > > > > > ? svg imagePath was set in setSource and also in loadPixmap. It is now set only in loadPixmap, so it i

Re: Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127282/ --- (Updated March 4, 2016, 10:43 p.m.) Review request for Plasma. Changes

Re: Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127282/ --- (Updated March 4, 2016, 10:49 p.m.) Status -- This change has been m

Re: Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127277/ --- (Updated March 4, 2016, 10:49 p.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 05 Mar 2016 04:08:09 + Build duration: 1 min 39 sec CHANGE SET Revision b270e277599cc6812777e4

Review Request 127285: use QDBusConnectionInterface::serviceOwnerChanged to watch mpris2 service

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127285/ --- Review request for Plasma and Aleix Pol Gonzalez. Repository: plasma-work

Re: Review Request 127285: use QDBusConnectionInterface::serviceOwnerChanged to watch mpris2 service

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127285/ --- (Updated March 5, 2016, 5:48 a.m.) Review request for Plasma and Aleix Po