Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it fails I

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

> On Jan. 15, 2016, 1:54 a.m., David Edmundson wrote: > > do you have commit access? no. - James --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126742/#review91122 -

Re: Review Request 126752: Auto-add Input Method Panel widget to Default Panel when run with relevant language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126752/#review91132 --- Ship it! having the list of languages hardcoded there seem

[Differential] [Updated] D827: Suspend/Hibernate through daemon instead of greeter

graesslin added a reviewer: Plasma. graesslin added a subscriber: plasma-devel. graesslin added a project: Plasma. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: gr

Re: Review Request 126752: Auto-add Input Method Panel widget to Default Panel when run with relevant language

> On Jan. 15, 2016, 7:24 a.m., Martin Gräßlin wrote: > > layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js, > > line 45 > > > > > > could we feed them in from a config file? So that also the

Re: Review Request 126752: Auto-add Input Method Panel widget to Default Panel when run with relevant language

> On Jan. 15, 2016, 10:02 a.m., Marco Martin wrote: > > having the list of languages hardcoded there seems indeed a bit hmm, > > hardcoded. > > however I think it's just fine to have it quickly and may well end up being > > enough Need review on https://git.reviewboard.kde.org/r/126751/ too

Re: Review Request 126751: Expose BCP47 language id in shell scripting interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126751/#review91141 --- Ship it! Ship It! - Marco Martin On Jan. 15, 2016, 2:10

Re: Review Request 126751: Expose BCP47 language id in shell scripting interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126751/ --- (Updated Jan. 15, 2016, 1:09 p.m.) Status -- This change has been ma

Re: Review Request 126752: Auto-add Input Method Panel widget to Default Panel when run with relevant language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126752/ --- (Updated Jan. 15, 2016, 1:10 p.m.) Status -- This change has been ma

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it fails

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it fails

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it fails I

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it fails I

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/ --- (Updated Jan. 15, 2016, 3:03 nachm.) Review request for Plasma, Jan Gruli

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91149 --- kded/notification.h (line 60)

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91150 --- Ship it! Looks good to me, maybe just change what I pointe

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 15, 2016, 3:20 nachm., Jan Grulich wrote: > > Looks good to me, maybe just change what I pointed out (storing just UUIDs > > as strings instead active connections). I don't have time right now to test > > it, but I trust you that it works. > > > > Looking only for active connections

Jenkins-kde-ci: polkit-kde-agent-1 Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/polkit-kde-agent-1%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jan 2016 13:03:33 + Build duration: 9.9 sec CHANGE SET No changes _

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91153 --- kded/notification.cpp (line 56)

Jenkins-kde-ci: polkit-kde-agent-1 Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/polkit-kde-agent-1%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jan 2016 16:21:10 + Build duration: 3 min 22 sec CHANGE SET Revision 9d1c8b2ba5d7561811

Jenkins-kde-ci: polkit-kde-agent-1 Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/polkit-kde-agent-1%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jan 2016 16:21:10 + Build duration: 3 min 22 sec CHANGE SET Revision 9d1c8b2ba5d7561811

Re: Review Request 126713: fix font preview colors

> On Jan. 10, 2016, 10:31 p.m., David Edmundson wrote: > > Can I suggest you copy SNIProxy::convertFromNative from > > plasma-workspace/xembedsniproxy/sniproxy.cpp > > > > (which in itself is copied from KWindowSystem, which I think was copied > > from Qt) > > David Edmundson wrote: >

Re: Review Request 126713: fix font preview colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126713/#review91158 --- Ship it! Ship It! - David Edmundson On Jan. 10, 2016, 1

Re: Review Request 126713: fix font preview colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126713/ --- (Updated Jan. 15, 2016, 1:12 p.m.) Status -- This change has been ma

Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 56 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jan 2016 21:13:13 + Build duration: 5 min 29 sec CHANGE SET Revision 9977edac12d6bec56f8d9