Re: Review Request 119062: Add a script to enforce window decorations for GTK windows

> On July 1, 2014, 6:04 p.m., Hugo Pereira Da Costa wrote: > > @Martin > > yes we can (tm). But then I'll get complains (got some already in the past) > > from people using oxygen-gtk on gnome (or other DEs). > > so there needs to be a way to communicate. (or as thomas suggested, some > > syst

Re: Review Request 119062: Add a script to enforce window decorations for GTK windows

> On July 1, 2014, 8:04 p.m., Hugo Pereira Da Costa wrote: > > @Martin > > yes we can (tm). But then I'll get complains (got some already in the past) > > from people using oxygen-gtk on gnome (or other DEs). > > so there needs to be a way to communicate. (or as thomas suggested, some > > syst

Re: Review Request 119062: Add a script to enforce window decorations for GTK windows

> On July 1, 2014, 6:04 p.m., Hugo Pereira Da Costa wrote: > > @Martin > > yes we can (tm). But then I'll get complains (got some already in the past) > > from people using oxygen-gtk on gnome (or other DEs). > > so there needs to be a way to communicate. (or as thomas suggested, some > > syst

Re: [plasma-workspace] /: Move path argument into KIconLoader ctor

Probably breaks the systray icons for qt4 apps (it wouldn't work in this way); however dfaure reverted the commit in a wrong branch and is reverting it and retaging and stuff, so can you please keep an eye on KIconThemes and revert this commit once it's reverted in there? Thank you. Cheers -- Mar

The "Social Desktop" KCM

Hey guys We seem to be shipping a broken "Social Desktop" KCM. This KCM has not seen any commits in the past few years, and crashes for me (on exit) in Plasma 5. The KCM says it is used for the following - * Get Hot New Stuff * Community applet * Social News applet We're not shipping the last 2

Re: The "Social Desktop" KCM

On Wed, Jul 2, 2014 at 11:50 AM, Vishesh Handa wrote: > Hey guys > > We seem to be shipping a broken "Social Desktop" KCM. This KCM has not > seen any commits in the past few years, and crashes for me (on exit) in > Plasma 5. > > The KCM says it is used for the following - > * Get Hot New Stuff >

Re: The "Social Desktop" KCM

On Wednesday 02 July 2014, Vishesh Handa wrote: > > It may be best if we do not ship the KCM from now on. Specially since the > openDesktop.org is proprietary. Opinions? yeah, better removing it for now -- Marco Martin ___ Plasma-devel mailing list P

Re: The "Social Desktop" KCM

+1 from me too. but I don't think we want to delete the code or anything just yet, just comment out the CMakeLists.txt. Open a bug report somewhere so it's not forgotten. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/lis

Re: [plasma-workspace] /: Move path argument into KIconLoader ctor

On Wednesday, July 02, 2014 10:20:26 Martin Klapetek wrote: > Probably breaks the systray icons for qt4 apps (it wouldn't work in this > way); however dfaure reverted the commit in a wrong branch and is reverting > it and retaging and stuff, so can you please keep an eye on KIconThemes and > revert

Re: The "Social Desktop" KCM

On Wednesday, July 02, 2014 11:52:48 Aleix Pol wrote: > On Wed, Jul 2, 2014 at 11:50 AM, Vishesh Handa wrote: > It may be best if we do not ship the KCM from now on. Specially since the > openDesktop.org is proprietary. Opinions? > +1 > > I never understood why this got in, anyway. +1 -- seba

Re: The "Social Desktop" KCM

On Wed, Jul 2, 2014 at 11:56 AM, David Edmundson wrote: > +1 from me too. but I don't think we want to delete the code or > anything just yet, just comment out the CMakeLists.txt. > > Open a bug report somewhere so it's not forgotten. > > What do you fear to have forgotten? Don't you think it can

Re: The "Social Desktop" KCM

On Wed, Jul 2, 2014 at 12:13 PM, Aleix Pol wrote: > On Wed, Jul 2, 2014 at 11:56 AM, David Edmundson > wrote: >> >> +1 from me too. but I don't think we want to delete the code or >> anything just yet, just comment out the CMakeLists.txt. >> >> Open a bug report somewhere so it's not forgotten. >

Re: The "Social Desktop" KCM

On Wednesday 02 July 2014, David Edmundson wrote: > The KCM says it is used for the following - > * Get Hot New Stuff > > We do use get hot new stuff (for now) > > Meh, maybe it can just die, I won't object. as far i know, the username and password are uniquely for the two applets. so is fine to

Re: The "Social Desktop" KCM

On Wednesday, July 02, 2014 12:28:49 Marco Martin wrote: > On Wednesday 02 July 2014, David Edmundson wrote: > > The KCM says it is used for the following - > > * Get Hot New Stuff > > > > We do use get hot new stuff (for now) > > > > Meh, maybe it can just die, I won't object. > > as far i know,

Re: The "Social Desktop" KCM

On Wednesday 02 July 2014, Sebastian Kügler wrote: > > as far i know, the username and password are uniquely for the two > > applets. so is fine to drop, unless and until somebody from opendesktop > > would pick them up and rewrite them > > And, IMO, resubmit them: We have been way to relaxed all

Re: The "Social Desktop" KCM

Seems like consensus. Kill it with fire. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build became unstable: plasma-workspace_master_qt5 #586

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The "Social Desktop" KCM

Removed - commit e6e1948c49b455ef1865dd76d4ffccaa43970880 Author: Vishesh Handa Date: Wed Jul 2 14:56:32 2014 +0200 Remove the attica-kde aka "The Social Desktop" KCM This KCM was only used for providing credentials for loging into opendesktop.org (or other mythical providers whic

Jenkins build is back to stable : plasma-workspace_master_qt5 #587

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119015: Fixing full screen settings on Plasma Mediacenter exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119015/#review61494 --- Ship it! Looks to be good, just a small modification and this

[plasma-workspace] /: Revert 95ce6207c59671

Git commit ea2619baa91a4684609591b3ce78ec3455a25509 by Sebastian Kügler. Committed on 02/07/2014 at 13:45. Pushed by sebas into branch 'master'. Revert 95ce6207c59671 Quoting the KIconThemes change that lead to this change: Revert "Revert "Allow passing custom theme base path together with c

Review Request 119089: Use appropiate licensed files for modeltest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119089/ --- Review request for Plasma. Repository: plasmate Description --- Us

Re: Review Request 119089: Use appropiate licensed files for modeltest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119089/ --- (Updated July 2, 2014, 6:28 p.m.) Review request for Plasma. Repository

Re: Plasmate Debian packaging issues

Hi ! El Martes, 1 de julio de 2014 11:36:21 Sebastian Kügler escribió: > > > Do you have push privileges? If yes just go ahead and replace the files > > > yourself. > > > > Not, I could go with a review request If this could help ? > > That would be really nice. > > Thanks, Created at

Re: Plasmate Debian packaging issues

Hello, sorry for my late response but I am still in an exam period On Wednesday 02 of July 2014 20:26:25 David Suárez wrote: > Created at I have already replied to it. It looks ok to me but I would like someone else more exprerienced with licensing to

Re: Review Request 119089: Use appropiate licensed files for modeltest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119089/#review61508 --- +1 from me but I would like someone else to have a look at it

Re: Review Request 119089: Use appropiate licensed files for modeltest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119089/#review61510 --- Ship it! Ship It! - Sebastian Kügler On July 2, 2014, 6:28

Review Request 119092: Add "sudo" to the make install command in the README file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119092/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository:

Re: Review Request 119092: Add "sudo" to the make install command in the README file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119092/#review61512 --- sudo make install will install things as root. Use "make ; s

Re: Review Request 119092: Add "sudo" to the make install command in the README file

> On July 2, 2014, 10:22 p.m., Aleix Pol Gonzalez wrote: > > sudo make install will install things as root. > > > > Use "make ; sudo make install/fast". > > Or alternatively, don't recommend to be root. It's not the best way to > > develop. I mean, will compile things as root - Aleix --

Re: Review Request 119092: Add "sudo" to the make install command in the README file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119092/#review61514 --- err.. What is done in that readme is bad practice. It should a

Re: Review Request 119092: Add "sudo" to the make install command in the README file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119092/ --- (Updated July 2, 2014, 10:53 p.m.) Review request for Plasma, Shantanu Tu

Re: Review Request 119092: Add "sudo" to the make install command in the README file

> On July 2, 2014, 10:28 p.m., Mark Gaiser wrote: > > err.. What is done in that readme is bad practice. It should advertise > > compiling into a prefix the user has permissions. Then make install also > > works just fine (or it should). > > What you propose (+ the configure line that is alread

Re: Review Request 118977: KSMServer: Do not autostart files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118977/ --- (Updated July 3, 2014, 12:14 a.m.) Status -- This change has been ma

Re: Review Request 118977: KSMServer: Do not autostart files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118977/#review61516 --- This review has been submitted with commit 68b27ba6abbce9c8f0

Re: Review Request 118977: KSMServer: Do not autostart files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118977/#review61517 --- Ship it! Hi, I had it applied and I pushed because I thought

Re: Review Request 119015: Fixing full screen settings on Plasma Mediacenter exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119015/#review61518 --- This review has been submitted with commit a615f2abaef7769f9d

Re: Review Request 119015: Fixing full screen settings on Plasma Mediacenter exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119015/ --- (Updated July 3, 2014, 2:02 a.m.) Status -- This change has been mar

Re: Review Request 119092: Add "sudo" to the make install command in the README file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119092/#review61519 --- this is a very bad suggestion. Given the README it will instal