Re: Review Request 119163: Add basic accessibility properties

2014-07-08 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/ --- (Updated July 8, 2014, 8:50 a.m.) Status -- This change has been mar

Re: Review Request 119163: Add basic accessibility properties

2014-07-07 Thread David Edmundson
> On July 7, 2014, 11:57 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/Slider.qml, line 143 > > > > > > This needs bounding to max/min. > > > > i.e if step size is 10 and w

Re: Review Request 119163: Add basic accessibility properties

2014-07-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/#review61868 --- src/declarativeimports/plasmacomponents/qml/Slider.qml

Re: Review Request 119163: Add basic accessibility properties

2014-07-07 Thread Aleix Pol Gonzalez
> On July 7, 2014, 6:27 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/ProgressBar.qml, line 140 > > > > > > This probably needs > > > > Accessible.name: value > > > >

Re: Review Request 119163: Add basic accessibility properties

2014-07-07 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/ --- (Updated July 7, 2014, 6:51 p.m.) Review request for Plasma, Sebastian Sa

Re: Review Request 119163: Add basic accessibility properties

2014-07-07 Thread Frederik Gladhorn
> On July 7, 2014, 6:27 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/ProgressBar.qml, line 140 > > > > > > This probably needs > > > > Accessible.name: value > > > >

Re: Review Request 119163: Add basic accessibility properties

2014-07-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/#review61844 --- src/declarativeimports/plasmacomponents/qml/ProgressBar.qml <

Re: Review Request 119163: Add basic accessibility properties

2014-07-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/#review61839 --- Ship it! lookf fine to me. Thanks for taking care of this! -

Re: Review Request 119163: Add basic accessibility properties

2014-07-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/#review61838 --- Ship it! Looks good, thanks for looking into it! - Aleix Pol

Re: Review Request 119163: Add basic accessibility properties

2014-07-07 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/ --- (Updated July 7, 2014, 5:27 p.m.) Review request for Plasma, Sebastian Sa