Re: Review Request 116722: Allow setTransientParent from an item

2014-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116722/ --- (Updated July 29, 2014, 8:53 a.m.) Status -- This change has been di

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-13 Thread David Edmundson
> On March 11, 2014, 3:57 p.m., Marco Martin wrote: > > Oddly is exactly the patch that i was trying yesterday ;) > > one thing i found out tough: item->window() of course is not aways there > > (for instance whenthe item is in a Dialog that hasn't been shown yet) > > so in many cases this won't

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread David Edmundson
> On March 11, 2014, 3:57 p.m., Marco Martin wrote: > > Oddly is exactly the patch that i was trying yesterday ;) > > one thing i found out tough: item->window() of course is not aways there > > (for instance whenthe item is in a Dialog that hasn't been shown yet) > > so in many cases this won't

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread Marco Martin
> On March 11, 2014, 3:57 p.m., Marco Martin wrote: > > Oddly is exactly the patch that i was trying yesterday ;) > > one thing i found out tough: item->window() of course is not aways there > > (for instance whenthe item is in a Dialog that hasn't been shown yet) > > so in many cases this won't

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread David Edmundson
> On March 11, 2014, 3:57 p.m., Marco Martin wrote: > > Oddly is exactly the patch that i was trying yesterday ;) > > one thing i found out tough: item->window() of course is not aways there > > (for instance whenthe item is in a Dialog that hasn't been shown yet) > > so in many cases this won't

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116722/#review52650 --- Oddly is exactly the patch that i was trying yesterday ;) one

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116722/#review52649 --- Oddly is exactly the patch that i was trying yesterday ;) one

Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116722/ --- Review request for Plasma. Repository: plasma-framework Description ---