Re: Review Request 126713: fix font preview colors

2016-01-15 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126713/ --- (Updated Jan. 15, 2016, 1:12 p.m.) Status -- This change has been ma

Re: Review Request 126713: fix font preview colors

2016-01-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126713/#review91158 --- Ship it! Ship It! - David Edmundson On Jan. 10, 2016, 1

Re: Review Request 126713: fix font preview colors

2016-01-15 Thread Thomas Lübking
> On Jan. 10, 2016, 10:31 p.m., David Edmundson wrote: > > Can I suggest you copy SNIProxy::convertFromNative from > > plasma-workspace/xembedsniproxy/sniproxy.cpp > > > > (which in itself is copied from KWindowSystem, which I think was copied > > from Qt) > > David Edmundson wrote: >

Re: Review Request 126713: fix font preview colors

2016-01-10 Thread Thomas Lübking
> On Jan. 10, 2016, 10:31 p.m., David Edmundson wrote: > > Can I suggest you copy SNIProxy::convertFromNative from > > plasma-workspace/xembedsniproxy/sniproxy.cpp > > > > (which in itself is copied from KWindowSystem, which I think was copied > > from Qt) > > David Edmundson wrote: >

Re: Review Request 126713: fix font preview colors

2016-01-10 Thread David Edmundson
> On Jan. 10, 2016, 10:31 p.m., David Edmundson wrote: > > Can I suggest you copy SNIProxy::convertFromNative from > > plasma-workspace/xembedsniproxy/sniproxy.cpp > > > > (which in itself is copied from KWindowSystem, which I think was copied > > from Qt) ...or maybe I should be the one

Re: Review Request 126713: fix font preview colors

2016-01-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126713/#review90858 --- Can I suggest you copy SNIProxy::convertFromNative from plasm