Re: Review Request 126597: Notificatioins rework

2016-01-08 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126597/ --- (Updated Ян. 8, 2016, 12:54 след обяд) Status -- This change has bee

Re: Review Request 126597: Notificatioins rework

2016-01-04 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126597/ --- (Updated Ян. 4, 2016, 7:18 след обяд) Review request for Plasma, David Ed

Re: Review Request 126597: Notificatioins rework

2016-01-04 Thread Anthony Fieroni
> On Ян. 4, 2016, 6:17 преди обяд, Martin Klapetek wrote: > > So I tested your patch and I will not accept removing the > > animation altogether. If you have 2 or more notifications > > at once, they just unexpectedly "jump", which causes quite > > a trouble for visual tracking. Besides, all othe

Re: Review Request 126597: Notificatioins rework

2016-01-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126597/#review90516 --- So I tested your patch and I will not accept removing the anim

Re: Review Request 126597: Notificatioins rework

2016-01-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126597/#review90451 --- The config changes are opened 2 weeks ago at https://git.revi

Re: Review Request 126597: Notificatioins rework

2016-01-02 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126597/ --- (Updated Ян. 2, 2016, 3:26 след обяд) Review request for Plasma, David Ed

Re: Review Request 126597: Notificatioins rework

2016-01-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126597/#review90437 --- applets/notifications/package/contents/ui/configNotifications

Re: Review Request 126597: Notificatioins rework

2016-01-02 Thread David Edmundson
> On Jan. 2, 2016, 9:27 a.m., David Edmundson wrote: > > Snarky comments don't really help acheive anything. > > > > What version of Qt are you running. This was all added to work round a > > change in a late Qt XCB 5.5? > > > > Also could you expand on the bugs you're seeing. You've linked to

Re: Review Request 126597: Notificatioins rework

2016-01-02 Thread Anthony Fieroni
> On Ян. 2, 2016, 11:27 преди обяд, David Edmundson wrote: > > Snarky comments don't really help acheive anything. > > > > What version of Qt are you running. This was all added to work round a > > change in a late Qt XCB 5.5? > > > > Also could you expand on the bugs you're seeing. You've lin

Re: Review Request 126597: Notificatioins rework

2016-01-02 Thread Anthony Fieroni
> On Ян. 2, 2016, 11:27 преди обяд, David Edmundson wrote: > > Snarky comments don't really help acheive anything. > > > > What version of Qt are you running. This was all added to work round a > > change in a late Qt XCB 5.5? > > > > Also could you expand on the bugs you're seeing. You've lin

Re: Review Request 126597: Notificatioins rework

2016-01-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126597/#review90434 --- Snarky comments don't really help acheive anything. What vers