Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated Jan. 4, 2016, 6:03 p.m.) Status -- This change has been mar

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review90386 --- Ship it! Ship It! - Kai Uwe Broulik On Dez. 31, 2015, 8:40

Re: Review Request 124047: Improve clock's tooltip layout

> On Dec. 31, 2015, 9:47 p.m., Kai Uwe Broulik wrote: > > you're now sorting in two separate places. can't you have one function in > > qml and sort in both component completed and in on selected timezones > > changed? No; sorting the array in onSelectingTimeZonesChanged (and setting it to pl

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review90384 --- you're now sorting in two separate places. can't you have one

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated Dec. 31, 2015, 9:40 p.m.) Review request for Plasma. Changes -

Re: Review Request 124047: Improve clock's tooltip layout

> On Dec. 22, 2015, 10:53 p.m., Kai Uwe Broulik wrote: > > It still does not shrink if timezones are removed. > > > > Otherwise looking good. > > Martin Klapetek wrote: > Tips for the shrinking issue? Ok found the issue; it was because I was setting a Loader as the tooltipItem and the Load

Re: Review Request 124047: Improve clock's tooltip layout

> On Dec. 22, 2015, 10:53 p.m., Kai Uwe Broulik wrote: > > It still does not shrink if timezones are removed. > > > > Otherwise looking good. Tips for the shrinking issue? - Martin --- This is an automatically generated e-mail. To repl

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review89958 --- applets/digital-clock/package/contents/ui/Tooltip.qml (line 1

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review89950 --- It still does not shrink if timezones are removed. Otherwise

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated Dec. 22, 2015, 8:38 p.m.) Review request for Plasma. Changes -

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated Dec. 22, 2015, 8:34 p.m.) Review request for Plasma. Changes -

Re: Review Request 124047: Improve clock's tooltip layout

> On Juni 12, 2015, 10:52 nachm., Kai Uwe Broulik wrote: > > I don't like that it now shows a timezone even when I have just one > > timezone selected which is pretty much redundant. Also, the tooltip always > > slides in from the left when I hover over the clock (some maximum width > > issue

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review81434 --- I don't like that it now shows a timezone even when I have jus

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review81403 --- Ship it! - Marco Martin On June 10, 2015, 11:49 a.m., Marti

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated June 10, 2015, 1:49 p.m.) Review request for Plasma. Changes -

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated June 10, 2015, 1:47 p.m.) Review request for Plasma. Changes -

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated June 10, 2015, 1:46 p.m.) Review request for Plasma. Changes -

Re: Review Request 124047: Improve clock's tooltip layout

> On June 8, 2015, 11:20 p.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 452 > > > > > > I think you can clean this up a bit to not duplicate all those strings.

Re: Review Request 124047: Improve clock's tooltip layout

> On June 8, 2015, 9:20 p.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 452 > > > > > > I think you can clean this up a bit to not duplicate all those strings. >

Re: Review Request 124047: Improve clock's tooltip layout

> On June 8, 2015, 11:20 p.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 452 > > > > > > I think you can clean this up a bit to not duplicate all those strings.

Re: Review Request 124047: Improve clock's tooltip layout

> On June 8, 2015, 9:20 p.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 452 > > > > > > I think you can clean this up a bit to not duplicate all those strings. >

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review81320 --- Nice improvement! applets/digital-clock/package/contents/ui/