This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d45584d1de4f: [xembedsniproxy] Free windowAttributes in
every case (authored by wbauer).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6389?vs=15883&id=15
davidedmundson accepted this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6389
To: wbauer, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
wbauer updated this revision to Diff 15883.
wbauer edited the summary of this revision.
wbauer added a comment.
Use a QScopedPointer instead of manually calling free()
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6389?vs=15869&id=15883
REVISION
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Urgh, how did I not catch that last review.
Might be better to just swap with:
QScopedPointer =
xcb_get_window_attrib
which we do for the other replies
REPO
wbauer created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The structure was only freed in case the XTest method was chosen.
But it should always be freed of course (as long as it isn't NULL).
TEST PL