D6386: [Digital Clock] Allow speaking out loud current time

2017-09-12 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. Going to address David's comments REVISION DETAIL https://phabricator.kde.org/D6386 To: broulik, #plasma, #vdg, mart Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D6386: [Digital Clock] Allow speaking out loud current time

2017-09-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D6386 To: broulik, #plasma, #vdg, mart Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6386: [Digital Clock] Allow speaking out loud current time

2017-06-29 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in main.xml:65 > It does not have to be. It also says "every n *minutes*" It does. you take the modulus. If you have it every 19 minutes you'd announce on: 21:57, 22:00, 22:19 that's not every 19 minutes. You jump about ev

D6386: [Digital Clock] Allow speaking out loud current time

2017-06-29 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.xml:65 > mention it has to be a factor of 60. It does not have to be. It also says "every n *minutes*" REVISION DETAIL https://phabricator.kde.org/D6386 To: broulik, #plasma, #vdg Cc: davidedmundson, plasma-devel,

D6386: [Digital Clock] Allow speaking out loud current time

2017-06-29 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > main.xml:65 > + > + Speak out loud current time every n minutes (0 = > disabled) > + 0 mention it has to be a factor of 60. > texttospeech.cpp:95 > +"It is %1:%2 p m", > +

D6386: [Digital Clock] Allow speaking out loud current time

2017-06-26 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This re-introduces the ability to automatically speak out loud the current time in intervals configured by the user (between every minute and