This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c5961c16a69d: Hoist the actions overlay out of the frame
loader. (authored by hein).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5309?vs=13126&id=13356#toc
REPOSITORY
R119 Plasma Desktop
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Indeed RTL seems broken with and without this patch..
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5309
To: hein, #plasma, broulik
Cc:
hein added a comment.
[10:14:07] Sho_: listview mode in popup is broken in RTL in
FolderView with your patch (didnt check if it's actually the patch but I recall
it working)
[10:18:26] kbroulik: i saw that but i felt like i saw it in the past
and it fixes itself if you keyboard nav so i
hein updated this revision to Diff 13126.
hein added a comment.
Fix ltr :D
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5309?vs=13125&id=13126
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5309
AFFECTED FILES
containments/desk
hein updated this revision to Diff 13125.
hein added a comment.
Fix rtl.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5309?vs=13111&id=13125
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5309
AFFECTED FILES
containments/deskto
broulik added inline comments.
INLINE COMMENTS
> FolderItemDelegate.qml:455
> +top: frameLoader.top
> +leftMargin: root.useListViewMode ? (icon.x + (icon.width
> / 2)) - (width / 2) : 0
> +topMargin: root.useListViewMode ? (icon.y + (ic
hein updated this revision to Diff 13111.
hein added a comment.
Add back the visible property expression, it's still needed for
the spring-loading case after all.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5309?vs=13110&id=13111
BRANCH
maste
hein added a comment.
Hold on - I just found a small regression during further testing, this needs
some more work.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5309
To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuter
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
This fixes a race condition causing the actions overlay to sometimes
appear in the drag pixmap attached to the DND cursor, as grabToImage
is run against the frame loader.
As a bonus it simplifie
