This revision was automatically updated to reflect the committed changes.
Closed by commit R102:fab046273c6a: Port away from KDELibs4Support (authored by
rthomsen).
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5169?vs=12793&id=13010
REVISION DETAIL
ht
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5169
To: rthomsen, #plasma, elvisangelaccio, davidedmundson
Cc: cfeck, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuter
rthomsen marked an inline comment as done.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5169
To: rthomsen, #plasma, elvisangelaccio
Cc: cfeck, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
rthomsen edited the summary of this revision.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5169
To: rthomsen, #plasma, elvisangelaccio
Cc: cfeck, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
rthomsen updated this revision to Diff 12793.
rthomsen added a comment.
- Also port the libraw1394 module.
- Fix tab indentation.
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5169?vs=12779&id=12793
REVISION DETAIL
https://phabricator.kde.org/D516
cfeck added inline comments.
INLINE COMMENTS
> kpci.cpp:96
> // line.setAscii(nameBuffer); //not work,
> workaround below
> - line = QString::fromAscii(pci_lookup_name(PCIAccess,
> nameBuffer, NAME_BUFFER_SIZE, PCI_LOOKUP_VENDOR, info->cooked.vendor, 0, 0,
rthomsen updated this revision to Diff 12779.
rthomsen added a comment.
Add KCrash integration.
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5169?vs=12777&id=12779
REVISION DETAIL
https://phabricator.kde.org/D5169
AFFECTED FILES
CMakeLists.txt
cfeck added a comment.
Please add KCrash integration (which was done automatically for KApplication,
but not for QApplication).
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5169
To: rthomsen, #plasma, elvisangelaccio
Cc: cfeck, plasma-devel, progwolff, leslie
rthomsen created this revision.
rthomsen added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Remove dependency on KDELibs4Support.
NOTE: I didn't port the `RAW1394` module, since I can't build that.
TEST PLAN
Everything works and looks norma
