D5036: UI fixes for logout dialog

2017-03-22 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:5f2f343ef6a3: UI fixes for logout dialog (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5036?vs=12459&id=12677#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UP

D5036: UI fixes for logout dialog

2017-03-22 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Logout.qml:21 > import QtQuick 2.2 > +import QtQuick.Window 2.2 > import QtQuick.Layouts 1.2 I think that's unused now REPOSITORY R120 Plasma Workspace BRANCH

D5036: UI fixes for logout dialog

2017-03-20 Thread Sebastian Kügler
sebas added a comment. No issues other than the ones Kai pointed out found. Once Kai is happy, you got my shipit, too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5036 To: mart, #plasma, sebas Cc: graesslin, broulik, plasma-devel, progwolff, lesliezhai,

D5036: UI fixes for logout dialog

2017-03-14 Thread Marco Martin
mart updated this revision to Diff 12459. mart added a comment. - adress comments - panel contrast still altered, probably a bug in the effect REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5036?vs=12437&id=12459 BRANCH phab/logoutpretty REVI

D5036: UI fixes for logout dialog

2017-03-14 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D5036#94741, @broulik wrote: > Background is quite dark for me now :/ eh, the problem was mainly that there wasn't enough contrast. i agree that it looks a bit dark, but if the priority is to ensure the text pops out, it kinda

D5036: UI fixes for logout dialog

2017-03-14 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > broulik wrote in shutdowndlg.cpp:200 > From what I can tell KWin doesn't support different background contrasts, ie. > once you click Leave you'll change your Panel background contrast. > > Bhushan experienced the same when running a plasmoid in pla

D5036: UI fixes for logout dialog

2017-03-13 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > broulik wrote in Logout.qml:54 > Don't let Martin see that you animate a window opacity manually ;-) But yes for a good, flicker free experience it needs to be animated by KWin. We can re add the logout effect to do the fading. REPOSITORY R

D5036: UI fixes for logout dialog

2017-03-13 Thread Kai Uwe Broulik
broulik added a comment. Background is quite dark for me now :/ Also, can we perhaps have pressing the arrow keys cancel the timer? It's quite unintuitive that when I press left the label still says "Logging out in n seconds" although Shutdown is highlighted. INLINE COMMENTS > shutdown

D5036: UI fixes for logout dialog

2017-03-13 Thread Marco Martin
mart added a comment. F2801217: Spectacle.Sm5414.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5036 To: mart, #plasma, sebas Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D5036: UI fixes for logout dialog

2017-03-13 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - use backgroundcontrast effect, improves readability a lot - non-current actions a bit more translucent - background is actually black if the