D28222: Add ShadowedImage and ShadowedTexture items

2020-03-31 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R169:0c7ba88d3970: Add ShadowedImage and ShadowedTexture items (authored by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28222?vs=78294&id=78987#toc REPOSITORY R169 Kirigami CHANGE

D28222: Add ShadowedImage and ShadowedTexture items

2020-03-27 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. this one i think is good to go, then afterwards, the independent radii REPOSITORY R169 Kirigami BRANCH shadowed_texture REVISION DETAIL https://phabricator.kde.org/D28222 To: ahiemstra,

D28222: Add ShadowedImage and ShadowedTexture items

2020-03-23 Thread Arjen Hiemstra
ahiemstra added a comment. Yeah if we split the radius into 4 that should be doable. The shader supports it, just need to bubble everything up all the way to the items. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28222 To: ahiemstra, #kirigami Cc: mart, plasma-

D28222: Add ShadowedImage and ShadowedTexture items

2020-03-23 Thread Marco Martin
mart added a comment. +100, works very well here. an api question. it was supposed to be possible to have the corners with independent radius (to have things like an image rounded only at top) would it still be possible with that approach? i guess would be expanding roundedrectangle to hav

D28222: Add ShadowedImage and ShadowedTexture items

2020-03-23 Thread Arjen Hiemstra
ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds the ShadowedImage and ShadowedTexture items. The first is a QML-only item th