davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> davidedmundson wrote in lnflogic.cpp:155
> That's the wrong group name.
> It should be TabBox.
>
> (and if this is copy pastad from somewhere
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> lnflogic.cpp:92
> emit messageRequested(ErrorLevel::Error, i18n("Cannot retrieve
> the current Plasma layout."));
> +
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> lnflogic.cpp:85
> +
> +QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(pcall,
> this);
> +
leaks
> lnflogic.cpp:155
> +
davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> main.qml:43
> +}
> +//FIXME: why crashes?
> +//model: lnfL
