davidedmundson added a comment.
> it look a bit "boring" you can select single button for app menu but when I
didn't select it what happens than? I would prefer instead of the checkbox all
different styles and radio button to select the style the user want.
That's a good idea,simply beca
andreaska added a comment.
**settingspage**
it look a bit "boring" you can select single button for app menu but when I
didn't select it what happens than? I would prefer instead of the checkbox all
different styles and radio button to select the style the user want.
**compact view**
davidedmundson added inline comments.
INLINE COMMENTS
> davidedmundson wrote in appmenumodel.cpp:85
> If you return here you have an unmatching begin/remove
Turns out this is what was causing that kate->konsole crash.
I should have trusted my reviewing instead of spending some time in valgrind.
davidedmundson added inline comments.
INLINE COMMENTS
> appmenuapplet.cpp:141
> +if (e->key() == Qt::Key_Left) {
> +emit requestActivateIndex(m_currentIndex - 1);
> +return true;
It's more normal to do the bounding to the right value before you emit a
signal, rat
davidedmundson added a comment.
Bugs from running it:
The menu doesn't immediately disappear when I focus from a window with a
shared menu, to a window without. Interacting with menu still crashes.
The config option for "compact and full" is a bit unusual. The Plasma style,
is to tr
broulik added inline comments.
INLINE COMMENTS
> appmenuapplet.cpp:91
> +ctx->window()->mouseGrabberItem()->ungrabMouse();
> +}
> +
Somehow your indentation is a bit off?
> configGeneral.qml:44
> +id: fullRepresentationRadio
> +text: i18n("Ful
