mart added inline comments.
INLINE COMMENTS
> broulik wrote in Logout.qml:45
> Can we have an enum for that?
it is an enum coming somewhere from solid, i don't think it has bindings?
> broulik wrote in Logout.qml:128
> Given you already set currentAction based on the sdtype, could be simplified
broulik added inline comments.
INLINE COMMENTS
> Logout.qml:147
> +text: {
> +switch (sdtype) {
> +case ShutdownType.ShutdownTypeReboot:
Also bind to currentAction insted of sdtype
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
mart added a comment.
difference from the mockup, only buttons currently supported by the logout
screen implemented atm
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2502
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpref
mart added a comment.
http://imgur.com/a/B6abc
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2502
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jen
