[Differential] [Commented On] D2173: WIP: New System Settings delegate design

broulik added a comment. Ping. I just noticed, the search is also broken, ie. the delegates don't visually indicate that they're disabled when no result was shown (a spotlight kind of highlight would be nice, though ;) REPOSITORY rSYSTEMSETTINGS System Settings REVISION DETAIL http

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

broulik added a comment. Pretty! Having the sub-categories shown by default and being able to navigate to them directly is a significant improvement over the old layout. The layout layout doesn't handle different font sizes very well, I run at 125 dpi with 1x device pixel ratio which cau

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

ivan added a comment. > Is that different to how it was before? Before, we had the icon and the text - and the whole are was one-clickable thing. Having different sub-areas with bigger differences in behaviour, and not having them visually separated is a problem (the thing you

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

colomar added a comment. > There is one strange thing regarding the behaviour - the sub-item links. > > The first problem is that it is not obvious what is clickable and what is not - the only hint is a slight change in the background (at least with my colour scheme) on hover. Is th

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

ivan added a comment. The last one - when closing the SySett, this is written a few dozen times: User of KWidgetItemDelegate should not delete widgets created by createItemWidgets! REPOSITORY rSYSTEMSETTINGS System Settings REVISION DETAIL https://phabricator.kde.org/D2173 EMAIL

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

ivan added a comment. There is a problem with the dark colour scheme - the view now has white borders on the sides: F182088: systemsettings.png The second thing, I think that the items would benefit from more padding. The third is that the i

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

mart added a comment. code seems ok, seems some pixel measures here and there, that i guess are ok. can you add a screenshot as well? INLINE COMMENTS > CategorizedView.cpp:30 > setWordWrap( true ); > +setViewportMargins(20,0,20,0); > +QPalette pal(palette()); does this give pr