[Differential] [Accepted] D2395: [Milou] Optimize and cleanup sources model

2016-08-10 Thread vhanda (Vishesh Handa)
vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rMILOU Milou REVISION DETAIL https://phabricator.kde.org/D2395 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #pl

[Differential] [Updated] D1185: drkonqi mappings: Move baloo_file* to "frameworks-baloo|Baloo File Daemon"

2016-03-20 Thread vhanda (Vishesh Handa)
vhanda added a comment. A big -1 from me. This is going to affect users with the most recent version of Plasma, which means previous versions will still keep filing bugs against Baloo. If anything, "frameworks-baloo" should be deleted. It's too late to change the product name. If someon

[Differential] [Accepted] D908: [Baloo Runner] Add mime data to matches

2016-02-05 Thread vhanda (Vishesh Handa)
vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. I'm guessing this is for drag and drop. Seems fairly straightforward. INLINE COMMENTS runners/baloo/baloosearchrunner.cpp:180 I don't think this is required. From the QMimeData d