[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

kossebau added a comment. Okay, thanks for fixing for Qt 5.8. Cherry-picked your commit also for the Plasma/5.8 branch now for upcoming Plasma 5.8.4 release, given Plasma 5.9.0 will only appear after Qt 5.8.0 (by schedules at least), so chances are people will want to run 5.8 with 5.8 :) RE

[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kdeplatformfiledialoghelper.cpp:368 > This does NOT build for me. > > qplatformdialoghelper.h:295:5: error: > ‘QFileDialogOptions::QFileDialogOptions(const QFileDialogOptions&)’ is private > kdeplatformfiledialoghelper.cpp:368:77

[Differential] [Closed] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

kossebau closed this revision. kossebau marked an inline comment as done. kossebau added a comment. Committed with 7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3796 EMAIL PREFERENCES http

[Differential] [Request, 25 lines] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

kossebau created this revision. kossebau added reviewers: Plasma, Frameworks, dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QFileDialog does not set the initialDirectory option in codepaths from QFileDialog::se

[Differential] [Closed] D2726: Make kpackage_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED

kossebau closed this revision. kossebau added a comment. Submitted as http://commits.kde.org/kpackage/cf70d380d7a9b2207f8e83e02d36db42a47c85ca and parents REVISION DETAIL https://phabricator.kde.org/D2726 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Request, 9 lines] D2726: Make kpackage_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED

kossebau created this revision. kossebau added reviewers: Plasma, mart, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently kpackage_install_package fails if KDE_INSTALL_DIRS_NO_DEPRECATED is set to TRUE, bec

[Differential] [Closed] D2633: Make plasma_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED

kossebau closed this revision. REVISION DETAIL https://phabricator.kde.org/D2633 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #plasma, sebas, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 6 lines] D2633: Make plasma_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED

kossebau created this revision. kossebau added reviewers: Plasma, mart, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently plasma_install_package fails if KDE_INSTALL_DIRS_NO_DEPRECATED is set to TRUE, beca

[Differential] [Request, 49 lines] D1372: Fix unsetting associated application/urls for applets

kossebau created this revision. kossebau added a reviewer: mart. kossebau added a subscriber: plasma-devel. REVISION SUMMARY Current code does not properly handle any resetting, which results in Applet::hasValidAssociatedApplication() still returning true when urls have been set to an empty

[Differential] [Updated, 43 lines] D1372: Fix unsetting associated application/urls for applets

kossebau updated this revision to Diff 3250. kossebau added a comment. Remove accidentally commited CMakeLists.txt work adaptions CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1372?vs=3249&id=3250 BRANCH allowAssignedUrlAppUnsetting REVISION DETAIL https://phabricator.kde.org/

[Differential] [Closed] D1372: Fix unsetting associated application/urls for Plasma::Applets

kossebau closed this revision. REVISION DETAIL https://phabricator.kde.org/D1372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kd

[Differential] [Commented On] D1372: Fix unsetting associated application/urls for Plasma::Applets

kossebau added a comment. Backtrace I just got with my recent post 5.6.2 fix to the weather widget unsetting the urls with an empty QList (will have to workaround it seems and set some fallback url for now): Thread 1 (Thread 0x7f13e16a08c0 (LWP 24002)): [KCrash Handler] #6 0x7f1

[Differential] [Updated] D1372: Fix unsetting associated application/urls for Plasma::Applets

kossebau retitled this revision from "Fix unsetting associated application/urls for applets" to "Fix unsetting associated application/urls for Plasma::Applets". kossebau updated the summary for this revision. kossebau added a project: Plasma. REVISION DETAIL https://phabricator.kde.org/D1372 E

[Differential] [Commented On] D1372: Fix unsetting associated application/urls for applets

kossebau added a comment. Hmpf, did I not tell arc to not pick up the CMakeLists.txt change? REVISION DETAIL https://phabricator.kde.org/D1372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, mart Cc: plasma-devel __

[Differential] [Closed] D1279: Add a template for Weather Ion dataengines

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe3a8bc4f6efd: Add a template for Weather Ion dataengines (authored by kossebau). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1279

[Differential] [Request, 327 lines] D1279: Add a template for Weather Ion dataengines

kossebau created this revision. kossebau added a reviewer: apol. kossebau added a subscriber: plasma-devel. Herald added a project: Plasma. TEST PLAN Used kapptemplate (needs fix, was just commited) and created a new ion based on the installed template. Successfully tested the ion following th