D5405: Create desktop file name based on organization domain unless set explicitely

This revision was automatically updated to reflect the committed changes. Closed by commit R467:ddd546251022: Set organization name for Wayland icon. (authored by lesliezhai). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5405?vs=13342&id=15416#toc REPOSITORY R467 K3b CHANGES SINCE L

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

marked as submitted. Review request for Plasma, Kai Uwe Broulik and David Edmundson. Changes --- Submitted with commit 2b7ef97f8104db6212e2a75d2578c6edca96e05a by Leslie Zhai to branch master. Repository: plasma-workspace Description --- Hi KDE developer, Bug reported by the clang

Re: Review Request 129995: Fix KillRunner Memory leak

marked as submitted. Review request for Plasma, Aleix Pol Gonzalez and Kai Uwe Broulik. Changes --- Submitted with commit 55237430bdab1bfbbfb442281ca5e34f5eb5e212 by Leslie Zhai to branch master. Repository: plasma-workspace Description --- Hi KDE developers, Bug reported by the

Re: Review Request 129995: Fix KillRunner Memory leak

nCode = process->execute(QStringLiteral("kill"), args); ? Within the expansion of the macro 'QStringLiteral': a Potential leak of memory pointed to by 'process' 187 188 if (returnCode == 0) ``` So I simply add ```delete process``` to free the allocate

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

t; > return; > > } > > > > QMenu *actionMenu = createMenu(idx); Hi Kai, Why use nullptr everywhere? it is my understanding http://www.leetcode.cn/2017/02/use-nullptr-everywhere.html please point out my fault, thanks! Regards, Leslie Zhai

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

move mode :/ 164 ctx->window()->mouseGrabberItem()->ungrabMouse(); 165 } 166 167 const auto &geo = ctx->window()->screen()->availableVirtualGeometry(); 5 ? Called C++ object pointer is null ``` So I simply add some checker for ctx, ctx->

Review Request 129995: Fix KillRunner Memory leak

n the expansion of the macro 'QStringLiteral': a Potential leak of memory pointed to by 'process' 187 188 if (returnCode == 0) ``` So I simply add ```delete process``` to free the allocated memory. Regards, Leslie Zhai Diffs - runners/kill/ki

Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

e(); 165 } 166 167 const auto &geo = ctx->window()->screen()->availableVirtualGeometry(); 5 ? Called C++ object pointer is null ``` So I simply add some checker for ctx, ctx->window() and ctx->window()->screen() pointers. Regards, Leslie Zhai

[Differential] [Updated] D4571: Fix adding files to data project

lesliezhai added a comment. Hi Kai Uwe, Thanks a lot for the fix! And I will try to fix clang analyzer's false positive ;-) Regards, Leslie Zhai REPOSITORY R467 K3b REVISION DETAIL https://phabricator.kde.org/D4571 EMAIL PREFERENCES https://phabricator.kd

Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

/CqxlXX1W8AAtoee.jpg so it is better to show it directly by default! Regards, Leslie Zhai Diffs - src/kmessagebox.cpp 194ffae tests/kmessageboxtest.cpp 8ea2848 Diff: https://git.reviewboard.kde.org/r/128768/diff/ Testing --- add case 26 in the patch, for long (> 512) deta

Re: Review Request 128633: Wether nor not install the private header?

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128633/#review98213 ------- On 八月 9, 2016, 2:49 p.m., Leslie Zhai wrote: > >

Re: Review Request 128633: Wether nor not install the private header?

marked as submitted. Review request for Plasma and Sune Vuorela. Changes --- Submitted with commit 2b21133372c82374977878e4d55538c16df68e95 by Leslie Zhai to branch frameworks. Repository: prison Description --- Hi Sune, People might directly use Prison::QRCodeBarcode https

Re: Review Request 128633: Wether nor not install the private header?

Vuorela. Repository: prison Description --- Hi Sune, People might directly use Prison::QRCodeBarcode https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.cpp#L9 instead of via Prison::createBarcode so is it able to install the private header? Regards, Leslie Zhai Diffs - lib

Review Request 128633: Wether nor not install the private header?

Description --- Hi Sune, People might directly use Prison::QRCodeBarcode https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.cpp#L9 instead of via Prison::createBarcode so is it able to install the private header? Regards, Leslie Zhai Diffs - lib/CMakeLists.txt 95391cc Diff

Re: Review Request 128454: Kickoff query for CJK support

place? Why isn't using your IME to convert > pinyin to Chinese good enough? I assume the better IMEs are also smart enough > to suggest ?? for wy anyway? > > Leslie Zhai wrote: > > It's only in a specific KRunner plugin > > Yes, it is better to develo

Re: Review Request 128454: Kickoff query for CJK support

place? Why isn't using your IME to convert > pinyin to Chinese good enough? I assume the better IMEs are also smart enough > to suggest ?? for wy anyway? > > Leslie Zhai wrote: > > It's only in a specific KRunner plugin > > Yes, it is better to develo

Re: Review Request 128454: Kickoff query for CJK support

/r/128454/diff/ Testing --- Thanks, Leslie Zhai ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128454: Kickoff query for CJK support

> On 七月 15, 2016, 9:19 a.m., Kai Uwe Broulik wrote: > > Thanks. I can't really comment on this. Hi Kai, Thanks for your careful review ;-) I will fix the issues when I develop the same function KRunner plugin for KJieba. Regards, Leslie Z

Re: Review Request 128454: Kickoff query for CJK support

place? Why isn't using your IME to convert > pinyin to Chinese good enough? I assume the better IMEs are also smart enough > to suggest ?? for wy anyway? > > Leslie Zhai wrote: > > It's only in a specific KRunner plugin > > Yes, it is better to develo

plasma-desktop containments desktop isFolder check

older", correct? ;-) Expect result: plugin new output, the primary screen keeps FolderView, and the extended is DesktopView by default if not change the default settings. Please someone give me some advice to point out my fault, thanks a lot! -- Regards, Leslie Zhai https://git.reviewboard.kde

Re: Review Request 128454: Kickoff query for CJK support

inyin is more comvinoent. - Leslie --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128454/#review97418 --- On 七月 15, 2016, 7

Review Request 128454: Kickoff query for CJK support

-UUoAADWEs.png Diffs - CMakeLists.txt 74e1518 runners/services/CMakeLists.txt 7e33a3e runners/services/servicerunner.h 8d9ad1a runners/services/servicerunner.cpp aa9d2bd Diff: https://git.reviewboard.kde.org/r/128454/diff/ Testing --- Thanks, Leslie Zhai

Re: Is it able to make kservice's weightedOffers public access?

&serviceType); is private access, is it able to make it public access? This is best discussed on the frameworks mailing list, KDE Frameworks Cheers, -- Regards, Leslie Zhai ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mai

Re: [Development] How to speed up QML for KDE5 without QML compiler

在 2015年09月16日 17:51, Konstantin Tokarev 写道: 16.09.2015, 07:04, "Leslie Zhai" : Hi great Qt and KDE developers, I like QML, it is high speed development language, easy to create candy UI and not difficult to debug. KDE4 began to use it in some projects, for example, KScreen`s kcm

How to speed up QML for KDE5 without QML compiler

components follow the Qt Quick Compiler`s resource.qrc way, so is it able to compile? for example, kickoff applet (the start menu of KDE5). -- Regards, Leslie Zhai - a KDE developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

On 2015年08月01日 08:04, David Edmundson wrote: On Fri, Jul 31, 2015 at 11:33 PM, Jonathan Riddell > wrote: Thanks for doing this, the kcm_useraccounts has long needed to be replaced. It was a longstanding todo item to replace it with user-manager which

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

d CI. In case someone is interested, here's a link to the API review task: https://github.com/hawaii-desktop/qtaccountsservice/issues/7 -- Regards, Leslie Zhai ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

.icon, so I can't imagine this doing anything. --- We have some code in KDeclarative that returns a user, wrapping kuser. I don't want to have code in our lib that does one thing, and have our shell code doing another. So, do you agree to wrapping AccountsService ;-) David -- Regar

AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

a=shortlog&h=c2b7a63e54375d49d0204e97fc521ea27caec719 Please give me some advice, thanks a lot! -- Regards, Leslie Zhai - a KDE developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel