[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

https://bugs.kde.org/show_bug.cgi?id=375249 Jonathan Marten changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED

[kio-extras] [Bug 348163] NFS configuration fails on absence of xdr_u_int64_t type

https://bugs.kde.org/show_bug.cgi?id=348163 Jonathan Marten changed: What|Removed |Added Status|REPORTED|RESOLVED CC

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

This revision was automatically updated to reflect the committed changes. Closed by commit R120:eed2d620cbd5: Consistent virtual desktop numbering between Switch Window popup and taskbar (authored by marten). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

marten updated this revision to Diff 66138. marten added a comment. Ignore the desktop ID and simply use the loop index, adjusted so that the desktop numbers start at 1. This is the same formatting as used by KWin (kwin/useractions.cpp) and the Task Manager applet (plasma-desktop/applets/ta

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

marten planned changes to this revision. marten added a comment. @GB_2 thanks for testing; a desktop UUID is obviously not friendly to show to the user, so there needs to be some sort of X11/Wayland runtime check here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

marten added a comment. In D22740#512556 , @ngraham wrote: > So does this fully fix 410190, or only partially? Fixes it completely for X11. Should really verify on Wayland before considering the bug to be completely fixed. REPOSITORY

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

marten created this revision. marten added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. marten requested review of this revision. REVISION SUMMARY Bug https://bugs.kde.org/show_bug.cgi?id=410190 describes the inconsistent virtual desktop numbering

D7820: man ioslave: spurious numbers included in clang(1) man page

marten added a comment. Confirmed that man:clang(1) now correctly displays the man page with no spurious numbers shown. Would be happy to abandon this review request. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7820 To: marten, #plasma, kfm-devel, mkoller Cc

D13360: Touchpad KDED module: Convert to JSON metadata

marten added a comment. Apologies for the unforeseen trouble. I'll revert the committed change for now, and then investigate the fix that @kossebau suggests in the previous comment. If this doesn't work then I'll look into splitting the kded and kcm modules into separate ones with a common

D13360: Touchpad KDED module: Convert to JSON metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d0307eff98f2: Touchpad KDED module: Convert to JSON metadata (authored by marten). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13360?vs=35608&id=36264#toc REPOSITORY R119 Plasma Desktop

D13360: Touchpad KDED module: Convert to JSON metadata

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. marten requested review of this revision. REVISION SUMMARY This is now the preferred way of providing plugin metadata. It's not

D9033: man ioslave: asserts trying to display pam(8)

marten added a comment. Ping anyone - is the updated diff enough for review? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D7820: man ioslave: spurious numbers included in clang(1) man page

marten added a comment. Ping - anyone able to review? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7820 To: marten, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9079: bluedevil-sendfile: Set option descriptions for command line help

This revision was automatically updated to reflect the committed changes. Closed by commit R97:85351d220d83: bluedevil-sendfile: Set option descriptions for command line help (authored by marten). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9079?vs=23201&i

D9079: bluedevil-sendfile: Set option descriptions for command line help

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The "--kio", "--ubi" and "--files"options (or their short equivalents) have no description text set. This doe

D9033: man ioslave: asserts trying to display pam(8)

marten updated this revision to Diff 23118. marten added a comment. Used const where appropriate. Apologies for the lack of context in the diff - I hadn't realised until you pointed it out that Phabricator doesn't automatically provide context (unlike Reviewboard). Maybe there should be

D9033: man ioslave: asserts trying to display pam(8)

marten marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9033: man ioslave: asserts trying to display pam(8)

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY That page, and many others, links to another page with just a plain name: .so PAM.8 This is read by

D8617: Folder View previews dialogue: Improve visual layout

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ad5f2e332708: Folder View previews dialogue: Improve visual layout (authored by marten). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8617?vs=21768&id=2183

D8617: Folder View previews dialogue: Improve visual layout

marten updated this revision to Diff 21768. marten added a comment. Fix name for view background colour REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8617?vs=21766&id=21768 REVISION DETAIL https://phabricator.kde.org/D8617 AFFECTED FILES conta

D8617: Folder View previews dialogue: Improve visual layout

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is the small dialogue that is summoned by the "More Preview Options" button on the "Icons" page. Previou

D8563: Folder View icons properties: Improve visual layout

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7af16dc48fa0: Folder View icons properties: Improve visual layout (authored by marten). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8563?vs=21601&id=21691

D8563: Folder View icons properties: Improve visual layout

marten updated this revision to Diff 21601. marten added a comment. Minor comment fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8563?vs=21600&id=21601 REVISION DETAIL https://phabricator.kde.org/D8563 AFFECTED FILES containments/desktop/pa

D8563: Folder View icons properties: Improve visual layout

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change is similar to https://phabricator.kde.org/D8424, for the "Icons" tab of the dialogue. In the curr

D8424: Folder View location properties: Improve visual layout

This revision was automatically updated to reflect the committed changes. Closed by commit R119:540a90cdeac2: Folder View location properties: Improve visual layout (authored by marten). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8424?vs=21132&id=21

D8424: Folder View location properties: Improve visual layout

marten added a comment. Thanks! - yes, I have push access. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8424 To: marten, #plasma, hein Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8424: Folder View location properties: Improve visual layout

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The current appearance of this dialogue: F5443493: folderview-properties-location_BEFORE.png

D7820: man ioslave: spurious numbers included in clang(1) man page

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Viewing the clang(1) man page shows spurious floating point numbers, either "0.0", "3.5" or "7.0", scattered throughout the page: F3910985

D6573: Babelfish plugin: Allow secure URLs to be translated

This revision was automatically updated to reflect the committed changes. Closed by commit R226:b90b0b0321a9: Babelfish plugin: Allow secure URLs to be translated (authored by marten). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6573?vs=16361&id=16394#toc REPOSITORY R226 Konqueror

D6573: Babelfish plugin: Allow secure URLs to be translated

marten updated this revision to Diff 16361. marten added a comment. Use KParts::BrowserExtension::childObject(part) to test for browser part (needs to be guarded by part!=NULL). Split up the big conditional. Use part->widget() as parent for message boxes. REPOSITORY R226 Konqueror CHAN

D6573: Babelfish plugin: Allow secure URLs to be translated

marten marked 2 inline comments as done. REPOSITORY R226 Konqueror REVISION DETAIL https://phabricator.kde.org/D6573 To: marten, #konqueror, #plasma, dfaure Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6573: Babelfish plugin: Allow secure URLs to be translated

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added subscribers: Dolphin, plasma-devel. REVISION SUMMARY The plugin originally only allows HTTP URLs to be translated. With the increasing use of automatic redirection to HTTPS, this seriousl

D5871: Remove obviously wrongly-named symbolic links

This revision was automatically updated to reflect the committed changes. Closed by commit R267:1b641f89d752: Remove obviously wrongly-named symbolic links (authored by marten). REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5871?vs=14560&id=14564 REVISI

D5871: Remove obviously wrongly-named symbolic links

marten created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It's not clear where these entries came from, but they are clearly a mistake - either scripting or copy-and-paste. The

D5761: Removal of KDELibs4Support means own copy of FindSamba.cmake needed

This revision was automatically updated to reflect the committed changes. Closed by commit R320:92c9c0f31966: Add FindSamba.cmake, needed for the SMB ioslave (authored by marten). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5761?vs=14274&id=14395#toc REPOSITORY R320 KIO Extras CHAN

D5761: Removal of KDELibs4Support means own copy of FindSamba.cmake needed

marten added a comment. In https://phabricator.kde.org/D5761#108658, @lbeltrame wrote: > Sorry, I have to backtrack. You need to add also COPYING-CMAKE-SCRIPTS to this commit, if it's not in the repository already, or there won't be any reference to the license. Sorry, I'm not ye

D5564: Man ioslave: Port away from KDELibs4Support

marten added inline comments. INLINE COMMENTS > dfaure wrote in kio_man.cpp:247 > keep the spaces around != Will fix. > dfaure wrote in man2html.cpp:6015 > why PLASMA? This is kde/kdenetwork/kio-extras, usable outside of a plasma > workspace. I'm curious where PLASMA_VERSION_STRING even comes

D5761: Removal of KDELibs4Support means own copy of FindSamba.cmake needed

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This CMake module used to be provided by KDELibs4Support. Since the removal of that dependency from kio-extras, the module is not found and th

[kio-extras] [Bug 379593] git master fails to build: plasma_version.h not found

https://bugs.kde.org/show_bug.cgi?id=379593 Jonathan Marten changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

[kio-extras] [Bug 379593] git master fails to build: plasma_version.h not found

https://bugs.kde.org/show_bug.cgi?id=379593 --- Comment #2 from Jonathan Marten --- CI (comment #1) should have been fixed by commit 6be8b06a to kio-extras. I'll commit a further fix for the version numbering: to avoid introducing an extra dependency it should be possible to just us

D5562: Fish ioslave: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:149d281277df: fish ioslave: Port away from KDELibs4Support (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5562?vs=13743&id=14192 REVISION

D5566: recentdocuments ioslave: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:26f76fc64bae: recentdocuments ioslave: Port away from KDELibs4Support (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5566?vs=13748&id=14194

D5568: SFTP ioslave: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:11df45b3d216: SFTP ioslave: Port away from KDELibs4Support (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5568?vs=14036&id=14196 REVISION

D5569: thumbnail ioslave: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b0b12086e786: Thumbnail ioslave: Port away from KDELibs4Support (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5569?vs=13752&id=14197 REVI

D5564: Man ioslave: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:cefa4de62964: Man ioslave: Port away from KDELibs4Support (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5564?vs=13744&id=14191 REVISION D

D5567: Settings ioslave: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:117e6235ce81: Settings ioslave: Port away from KDELibs4Support (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5567?vs=13750&id=14195 REVIS

D5565: Network ioslave: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:17effe0d9f73: Network ioslave: Port away from KDELibs4Support (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5565?vs=13746&id=14193 REVISI

D5560: Archive ioslave: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bbd3d8feb250: Archive: Port away from KDELibs4Support (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5560?vs=13741&id=14189 REVISION DETAI

D5561: Filter ioslave: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:c285acd05e32: filter: Port away from KDELibs4Support (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5561?vs=13742&id=14190 REVISION DETAIL

D5568: SFTP ioslave: Port away from KDELibs4Support

marten updated this revision to Diff 14036. marten added a comment. There seems to be only one place where the result from the openPasswordDialog is actually propagated to the outside. I've changed this one; the point of changing the others was to port away from the old deprecated function.

D5569: thumbnail ioslave: Port away from KDELibs4Support

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the thumbnail ioslave and therefore, along with the previously s

D5568: SFTP ioslave: Port away from KDELibs4Support

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the SFTP ioslave. TEST PLAN Built kio-extras with this change

D5567: Settings ioslave: Port away from KDELibs4Support

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the settings ioslave. TEST PLAN Built kio-extras with this ch

D5566: recentdocuments ioslave: Port away from KDELibs4Support

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the recentdocuments ioslave. TEST PLAN Built kio-extras with

D5565: Network ioslave: Port away from KDELibs4Support

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the network ioslave. TEST PLAN Built kio-extras with this cha

D5564: Man ioslave: Port away from KDELibs4Support

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the man ioslave and the man2html converter. TEST PLAN Built k

D5562: Fish ioslave: Port away from KDELibs4Support

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the ioslave. TEST PLAN Built kio-extras with this change, che

D5561: Filter ioslave: Port away from KDELibs4Support

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the filter-based ioslaves: bzip/bzip2, gzip, lzma, xz TEST PLAN

D5560: Archive ioslave: Port away from KDELibs4Support

marten added a comment. Also: Install KIOArchive library with LIBRARY NAMELINK_SKIP so that clients will depend on major soversion, as suggested by jriddell. Make major soversion number the same as first part of full version, for consistency. REPOSITORY R320 KIO Extras REVISION DETAIL

D5560: Archive ioslave: Port away from KDELibs4Support

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the archive-based ioslaves (ar, tar and zip). TEST PLAN Built

D5112: Make archiver ioslave extensible

This revision was automatically updated to reflect the committed changes. Closed by commit R320:785d85f3fe5a: Make the archiver KIOslave extensible (authored by marten). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5112?vs=12896&id=12972#toc REPOSITORY R320 KIO Extras CHANGES SINCE

D5112: Make archiver ioslave extensible

marten added a comment. I'd done some porting away from kdelibs4 in this change, in particular KMimeType -> QMime* but realized that it was getting a bit involved and would be mixing up two unrelated changes (involving about 30 files for the whole of kio-extras) . So I'll submit a separate

D5112: Make archiver ioslave extensible

marten updated this revision to Diff 12896. marten added a comment. Remove KF5 prefixes, the library is now libkioarchive.so REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5112?vs=12641&id=12896 REVISION DETAIL https://phabricator.kde.org/D5112 AFFEC

D5112: Make archiver ioslave extensible

marten added a comment. Point taken regarding the KF5 prefix, this was based on the installed names for libkonq (= libKF5Konq.so etc) although not every application support library is named the same way (libkworkspace5.so isn't). Would the name libKioArchive.so, etc be appropriate, or sh

D5112: Make archiver ioslave extensible

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The tar, zip and ar ioslaves are implemented in kio-extras/archive by a single plugin (class ArchiveProtocol). This uses the URL scheme to det

[Differential] [Closed] D4740: Fonts KCM: Fix layout of hinting settings, port away from KDE4

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc5720494a01: Fonts KCM: Fix layout of hinting settings, port away from KDE4 (authored by marten). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4740?vs=116

[Differential] [Changed Subscribers] D4744: ReceiveFileJob: Don't cancel the request right after accepting it

marten added inline comments. INLINE COMMENTS > receivefilejob.h:69 > BluezQt::Request m_request; > +bool m_accepted = false; > }; Allowed in C++11, but would this not be clearer done in the constructor initialization list? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabri

[Differential] [Request, 126 lines] D4740: Fonts KCM: Fix layout of hinting settings, port away from KDE4

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change improves the layout of the font hinting sub-dialogue of this KCM. Previously there was no spacing around or between the GUI elemen

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

marten added a comment. Agreed that a decision needs to be made, but I'm not an expert on the KPackage system and so wasn't sure whether the warning may be useful to package developers in some cases - in which case leaving it commented out would make it easier to reinstate than removing it e

[Plasma Workspace Wallpapers] [Bug 363860] Slideshow does not cycle if only one image in set directory

https://bugs.kde.org/show_bug.cgi?id=363860 Jonathan Marten changed: What|Removed |Added CC||p.suetter...@royac.iac.es --- Comment #2

[Differential] [Request, 2 lines] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

marten created this revision. marten added reviewers: Frameworks, Plasma. marten set the repository for this revision to R290 KPackage. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As described in https://bug

[Differential] [Closed] D2853: Mouse KCM: Align spin boxes, port to Qt5

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP8bee1a78b04a: Mouse KCM: Align spin boxes, port to Qt5 (authored by marten). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2853?vs=7051&i

[Differential] [Updated, 170 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten updated this revision to Diff 7051. marten added a comment. Using a form layout wrapped in an outer layout with stretch added to the right. Gives the intended effect, with all spin boxes the same size and lining up on both tabs. The boxes for the "Keyboard Navigation" tab are wider t

[Differential] [Updated, 126 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten updated this revision to Diff 7049. marten added a comment. Apologies for the confusion... this patch corresponds to the last screen shot, with ExpandingFieldsGrow and MinimumExpanding (currently only for the "Advanced" tab). Adding an outer layout with a stretch to the right seem

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten added a comment. This is what happens with a QFormLayout with fieldGrowthPolicy=ExpandingFieldsGrow and fields' sizePolicy=MinimumExpanding/Fixed. The effect is not good - it moves the spin box controls a long way away. Shall I stick with the grid layout? F349555: mouse-kcmshel

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten added a comment. Thanks for the hint David... I thought that I'd tried the approach of setting the fieldGrowthPolicy and the sizePolicy of the fields, and the problem with that was that the spinboxes were then extended to the full width of the form - not looking good, as well as putti

[Differential] [Updated, 196 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten updated this revision to Diff 7032. marten added a comment. Implemented using a grid layout. It looks the same, not needing the event filter but at the cost of more code to generate the layout (getting the required label alignment, setting label buddies, keeping track of rows...) whi

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten added a comment. A grid layout would fix it, but I assume that the point of using a form layout is that it would automatically pick up the platform and style policy (field and label alignment, stretch policy etc). REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://p

[Differential] [Request, 154 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten created this revision. marten added a reviewer: Plasma. marten set the repository for this revision to rPLASMADESKTOP Plasma Desktop. marten added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The "Advanced" and "Keyboard Navigation" tabs of

[Differential] [Closed] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE4be156bc6776: Image wallpaper: Fix verification of a background image file (authored by marten). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricat

[Differential] [Commented On] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

marten added a comment. Sorry, I'm not yet totally au fait with the Phabricator workflow. Does "accepted and ready to land" mean to commit it? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2722 EMAIL PREFERENCES https://phabricator.kde.org/

[Differential] [Updated] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

marten set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, davidedmundson, #pla

[Differential] [Updated, 11 lines] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

marten removed rPLASMAWORKSPACE Plasma Workspace as the repository for this revision. marten updated this revision to Diff 6579. marten added a comment. Implemented BackgroundFinder::isAcceptableSuffix() as suggested. Yes, I already have Git commit access (assuming that nothing special ne

[Differential] [Commented On] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

marten added a comment. broulik's suggestion would make the code clearer, I'll look into it. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, #plas

[Differential] [Request, 2 lines] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

marten created this revision. marten added a reviewer: Plasma. marten set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When a new image file is det

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

marked as submitted. Review request for kde-workspace and Plasma. Changes --- Submitted with commit 226401862f2c68f9bd37e95f6fae241b2d41e733 by Jonathan Marten to branch master. Bugs: 360666 https://bugs.kde.org/show_bug.cgi?id=360666 Repository: plasma-integration Description

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

en overwriting an existing file, unless the QFileDialog::DontConfirmOverwrite option is specified. Thanks, Jonathan Marten ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

ed in build/autotests. The > relevant one would be kfiledialog_unittest and kfiledialogqml_unittest > > Jonathan Marten wrote: > Ok, found them and how - thanks. > > It doesn't appear to be possible to just check that the QFileDialog > option is passed correct

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

Diff: https://git.reviewboard.kde.org/r/127944/diff/ Testing --- Built plasma-intergration with this change, confirmed correct operation of file dialogues and that confirmation is requested when overwriting an existing file, unless the QFileDialog::DontConfirmOverwrite option is specified. Thanks, J

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

his is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95535 ------- On May 17, 2016, 3:20 p.m., Jonathan Marten wrote: > > ---

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

rg/r/127944/#review95535 --- On May 17, 2016, 3:20 p.m., Jonathan Marten wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127944/ > --

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

visit: https://git.reviewboard.kde.org/r/127944/#review95532 --- On May 17, 2016, 3:20 p.m., Jonathan Marten wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

oard.kde.org/r/127944/diff/ Testing --- Built plasma-intergration with this change, confirmed correct operation of file dialogues and that confirmation is requested when overwriting an existing file, unless the QFileDialog::DontConfirmOverwrite option is specified. Thanks, J

Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

ration of file dialogues and that confirmation is requested when overwriting an existing file, unless the QFileDialog::DontConfirmOverwrite option is specified. Thanks, Jonathan Marten ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.k

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit 3546406db06600ff61132085e08366d62cbab53f by Jonathan Marten to branch master. Repository: plasma-desktop Description --- In Plasma 5 this KCM only lists the names of the available

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/#review91537 --- Ping anyone? - Jonathan Marten On Jan. 10, 2016, 4:33 p.m

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

ch-elided-r126303.png Thanks, Jonathan Marten ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126300: Plasma Search KCM: display the runner descriptions

-4c3bb80f7955__plasmasearch-after-r126300.png Thanks, Jonathan Marten ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 78f02ac2ed40e88d6f069f35794d991b40a33139 by Jonathan Marten to branch master. Bugs: 354984 https://bugs.kde.org/show_bug.cgi?id=354984 Repository: plasma-desktop Description --- See the

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

f desktop and of CLI and GUI applications. Thanks, Jonathan Marten ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

  1   2   >