D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

arichardson added a comment. +1 LGTM. Thanks! REVISION DETAIL https://phabricator.kde.org/D14440 To: dfaure, arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

arichardson added a comment. Does this mean for Qt < 5.12 (or .13?) pressing open in kwrite will select the cwd again? I now have almost all my source directories NFS mounted rather than having to use sftp so it is no longer such a big issue for me. However, I do wonder if it makes sens

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson added a comment. In D4193#242444 , @fvogt wrote: > What about `Plasma/5.12`? It has a minimum of Qt 5.9 as well. Good point. Any objections against me cherry-picking it to the 5.12 branch? REPOSITORY R135 Integration for Qt a

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

This revision was automatically updated to reflect the committed changes. Closed by commit R135:bfd41a95530f: KDEPlatformFileDialog: Fix initial directory selection for remote files (authored by arichardson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson updated this revision to Diff 31284. arichardson edited the summary of this revision. arichardson added a comment. - Removed version check since we now depend on Qt 5.9 - Updated commit message REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson added a comment. I'll update and test this again when I get back to my work computer on Tuesday. Should I just remove the code or add a comment that since qt 5.8 it is no longer necessary to set the directory as well? REPOSITORY R135 Integration for Qt applications in Plasma R

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson updated this revision to Diff 21216. arichardson added a comment. - rebased - removed runtime check REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4193?vs=13383&id=21216 BRANCH arcpatch-D4193 REVISION DETA

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kdeplatformfiledialoghelper.cpp:365-370 > http://doc.qt.io/qt-5/qversionnumber.html I don't think we can depend on that yet, can we? Also I'm not sure we really need that runtime check. How likely is it that someone co

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson updated this revision to Diff 13383. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4193?vs=10338&id=13383 BRANCH arcpatch-D4193 REVISION DETAIL https://phabricator.kde.org/D4193 AFFECTED FILES src/platform

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson marked an inline comment as done. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma Cc: elvisangelaccio, graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

[Differential] [Commented On] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson added a comment. Ping? I work a lot with remote projects over sftp:// so this would be very important for me. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 EMAIL PREFERENCES https://phabricator.kde.org/sett

[Differential] [Commented On] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kdeplatformfiledialoghelper.cpp:365-370 > > what is the easy way to do that? > > There is KCoreAddons::version() I want the version of Qt not KCoreAddons so that won't work. Do we really need a runtime Qt version chec

[Differential] [Commented On] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson added inline comments. INLINE COMMENTS > graesslin wrote in kdeplatformfiledialoghelper.cpp:365-370 > Shouldn't that be a runtime check? Yes it should be but what is the easy way to do that? Do I have to parse the result of qVersion()? CMakeLists.txt says the minimum version is 5.5

[Differential] [Request, 4 lines] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson created this revision. arichardson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We currently get the following sequence of calls: KDEPlatformFileDialogHelper::setDirectory QUr

[Differential] [Accepted] D851: Port kded plugin to json metadata

arichardson accepted this revision. arichardson added a reviewer: arichardson. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me once the JSON has been changed to use bool INLINE COMMENTS kwrited.json:154 This and the following should be a boolean n

[Differential] [Changed Subscribers] D851: Port kded plugin to json metadata

arichardson added a subscriber: arichardson. INLINE COMMENTS CMakeLists.txt:78 Add SERVICE_TYPES kdedmodule.desktop here to ensure that all keys have the right type CMakeLists.txt:81 Could be simplified to use `kcoreaddons_add_plugin(kded_kwrite SOURCES kwrited.cpp JSON "kwrited.json" INSTA

Re: Review Request 126740: Add a script for optimizing svgs

shFAQ/001) optimize.svg.sh (line 16) <https://git.reviewboard.kde.org/r/126740/#comment62491> Here an everywhere else $v -> "$v" https://github.com/koalaman/shellcheck/wiki/SC2086 optimize.svg.sh (line 20) <https://git.reviewboard.kde.org/r/126740/#comment62490&g

Re: Review Request 126348: Make it possible to provide the metadata in json

tps://git.reviewboard.kde.org/r/126348/#comment61280> no longer required, right? src/kpackage/package.cpp (line 916) <https://git.reviewboard.kde.org/r/126348/#comment61281> `path.endsWith("/metadata.desktop") || path.endsWith("/metadata.json")`? QRegExp seems like overkil

Re: Review Request 126348: Make it possible to provide the metadata in json

od to me other than this one issue src/kpackage/private/packagejobthread.cpp (line 143) <https://git.reviewboard.kde.org/r/126348/#comment61242> I think it would be better if this code was added to the KPluginMetaData ctor (in an `if (path.endswith(".json"))` branch. - Ale

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

tps://git.reviewboard.kde.org/r/126320/#comment61224> This should probably also be changed to QStringList? - Alex Richardson On Dec. 11, 2015, 6:48 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

) <https://git.reviewboard.kde.org/r/126320/#comment61223> readStringList() is static so KPluginMetaData:: is probably the better way to call it - Alex Richardson On Dec. 11, 2015, 6:48 p.m., Martin Klapetek wrote: > > ---

Re: Review Request 126268: Move shutdown scripts into ksmserver cleanup

tps://git.reviewboard.kde.org/r/126268/#comment61038> continue? - Alex Richardson On Dec. 7, 2015, 12:26 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 126210: [phonon] Do not set RPATH

-cmake-modules so there should be no need for that code - Alex Richardson On Nov. 30, 2015, 7:16 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

zilla plugin path), they will not be set. > > Martin Gräßlin wrote: > > Woundn't this break user's workflow? > > Yes, but what do you prefer? Breaking user's workflows or a secure system? > > There is nothing wrong of course with sourci

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

> On Nov. 19, 2015, 2:08 p.m., Matthias Klumpp wrote: > > Did you consider running the whole script with `env -i`, or (likely the > > better idea) run KWin with `env -i`? > > That should sanitize the environment (unset all env vars, except for > > shell-defaults). You could then set exactly the

Re: Review Request 126104: Make networkmanager-qt an optional dependency

marked as submitted. Review request for Plasma. Changes --- Submitted with commit de5ed6c4cdded1f2ba2ce43022be1d1a9b475bf0 by Alex Richardson to branch master. Repository: plasma-workspace Description --- I can't compile networkmanager-qt on my current system because the versi

Review Request 126104: Make networkmanager-qt an optional dependency

gines/CMakeLists.txt 014da10aac5629be202bd5ad96012f817bf846ef Diff: https://git.reviewboard.kde.org/r/126104/diff/ Testing --- compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On Sept. 2, 2015, 3:14 p.m., Alex Richardson wrote: > > startkde/kstartupconfig/kdostartupconfig.cpp, line 86 > > <https://git.reviewboard.kde.org/r/124877/diff/1/?file=397209#file397209line86> > > > > `QByteArray buf = keys.readLine()` > >

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

) <https://git.reviewboard.kde.org/r/124877/#comment58667> `QByteArray buf = keys.readLine()` I don't see the point of preallocation 1024 bytes (I doubt this does any good anyway) and using the less safe C-style API - Alex Richardson On Aug. 31, 2015, 5:33 p.m., Takahiro Hash

Re: Review Request 125028: Monitor for the clock changes from the kernel

et a `EINVAL`, but it can still return `ENOMEN` or `EBADF` if the call to `timerfd_create` failed. - Alex Richardson On Sept. 2, 2015, 11:29 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 123556: KPackage::findPackages with a filter callback

tps://git.reviewboard.kde.org/r/123556/#comment54542> This will crash if there is no filter. `if (!filter || filter(plugin))` should work. - Alex Richardson On April 29, 2015, 1:12 p.m., Marco Martin wrote: > > ---

Re: Review Request 123131: Port kio_man away from kdelibs4support

as it previously returned the full list. > > Nick Shaforostoff wrote: > please see > https://projects.kde.org/projects/kde/kdesdk/lokalize/repository/revisions/master/entry/src/common/languagelistmodel.cpp > for the ways to get a list of all languages (there is a KDE-way and Q

Re: Review Request 123088: Adding libkactivities-stats to the build

> On March 26, 2015, 3:34 p.m., Hrvoje Senjan wrote: > > the library doesn't seem to like boost 1.56: > > > > ``` > > In file included from > > ../lib/kactivities-stats/src/lib/stats/resultset.cpp:425: > > ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:78:14: error: > > no viabl

Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57

style in plasma is (`static_cast(foo)` or `bool(foo)`) so I can't give the ship it. - Alex Richardson On March 26, 2015, 7:47 p.m., Tomaz Canabrava wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 123131: Port kio_man away from kdelibs4support

rated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/#review78048 ------- On März 25, 2015, 9:17 nachm., Alex Richardson wrote: > > --- > This is a

Review Request 123131: Port kio_man away from kdelibs4support

d like some feedback. Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122733: Fix path traversal checks in KPackage

it.reviewboard.kde.org/r/122733/#review77011 --- On March 3, 2015, 5:53 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 122795: Fix crashes when attempting to load invalid package

March 3, 2015, 7:32 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122795/ > --- >

Review Request 122795: Fix crashes when attempting to load invalid package

122795/diff/ Testing --- no longer crashes, prints an error message instead Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122733: Fix path traversal checks in KPackage

eb4a09b987970e89f28587426b21d63731634087 src/kpackage/private/package_p.h e451412fa02c88113aa4c7bbca2dcda3432b2b02 Diff: https://git.reviewboard.kde.org/r/122733/diff/ Testing --- Files inside the package are now found although the install location contains a symlink Thanks, Alex

Review Request 122733: Fix path traversal checks in KPackage

e451412fa02c88113aa4c7bbca2dcda3432b2b02 Diff: https://git.reviewboard.kde.org/r/122733/diff/ Testing --- Files inside the package are now found although the install location contains a symlink Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 122312: Use sysconf() instead of relying on UT_NAMESIZE

o.cpp 68fc865 Diff: https://git.reviewboard.kde.org/r/122312/diff/ Testing --- compiles, runs and shows user name too long tooltip when I enter a really long name Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 122619: [KPluginMetaData] Add support for Hidden key

to add it. - Alex Richardson On Feb. 18, 2015, 9:44 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 121738: Let kcmkded also handle kded modules that use JSON metadata

6902f3a8c30af1ae43761c53b3b235e12f1fba9c Diff: https://git.reviewboard.kde.org/r/121738/diff/ Testing --- Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122312: Use sysconf() instead of relying on UT_NAMESIZE

s and shows user name too long tooltip when I enter a really long name Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122133: Fix compilation error by using std::vector rather than a conventional array.

just pushed - Alex Richardson On Jan. 18, 2015, 7:32 p.m., Roney Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 121762: Fix build on FreeBSD

33d0752b0dc9734b Diff: https://git.reviewboard.kde.org/r/121762/diff/ Testing ------- compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121762: Fix build on FreeBSD

e.org/r/121762/diff/ Testing ------- compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121763: Fix build on FreeBSD

https://git.reviewboard.kde.org/r/121763/diff/ Testing --- Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121761: Fix build on FreeBSD

/screenlocker/greeter/autotests/killtest.cpp 6f2ef114459b5d641e357f3a817b82e7af2e72a3 libkworkspace/CMakeLists.txt 53ce6108bd91f87108206fca02ac303dadf069e1 Diff: https://git.reviewboard.kde.org/r/121761/diff/ Testing --- compiles, still compiles on linux Thanks, Alex Richardson

Re: Review Request 121762: Fix build on FreeBSD

33861d258241cf7 kcms/phonon/CMakeLists.txt 8f964e2041cc812bf70f6a48e2915427f088b990 Diff: https://git.reviewboard.kde.org/r/121762/diff/ Testing ------- compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https:/

Re: Review Request 121762: Fix build on FreeBSD

iewboard.kde.org/r/121762/#review72792 --- On Dez. 30, 2014, 6:35 nachm., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Review Request 121763: Fix build on FreeBSD

vinfo/devinfo.desktop 1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7 Modules/info/CMakeLists.txt 7b0e0affd13d6b556749f4a350012f27fb43ae0b Modules/pci/CMakeLists.txt 5b2b30a0c3791a8add00a380e61469a96cd66ae1 Diff: https://git.reviewboard.kde.org/r/121763/diff/ Testing --- Thanks, Alex Richa

Re: Review Request 121761: Fix build on FreeBSD

- On Dez. 30, 2014, 6:33 nachm., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121761/ >

Review Request 121762: Fix build on FreeBSD

b_helper.h d3dab1d9b05784ae463db44ab941119e5b214986 kcms/phonon/CMakeLists.txt 8f964e2041cc812bf70f6a48e2915427f088b990 Diff: https://git.reviewboard.kde.org/r/121762/diff/ Testing --- compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-dev

Review Request 121761: Fix build on FreeBSD

/CMakeLists.txt 53ce6108bd91f87108206fca02ac303dadf069e1 Diff: https://git.reviewboard.kde.org/r/121761/diff/ Testing --- compiles, still compiles on linux Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request 121738: Let kcmkded also handle kded modules that use JSON metadata

--- Let kcmkded also handle kded modules that use JSON metadata Diffs - kcms/kded/kcmkded.h 9afa1881f56d2f913b7e4f7eba5e556795ac5551 kcms/kded/kcmkded.cpp 6902f3a8c30af1ae43761c53b3b235e12f1fba9c Diff: https://git.reviewboard.kde.org/r/121738/diff/ Testing --- Thanks, Alex

Re: Review Request 121732: Port kcm_kded away from kdelibs4support

/kcmkded.cpp 34a1acf6c6105d3ef7202663417603b47478e359 Diff: https://git.reviewboard.kde.org/r/121732/diff/ Testing --- Compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 121732: Port kcm_kded away from kdelibs4support

/121732/diff/ Testing --- Compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel