Re: Review Request 125755: Fix build with QT5.6

> On Oct. 22, 2015, 1:38 p.m., Martin Gräßlin wrote: > > src/CMakeLists.txt, line 7 > > > > > > is KWindowSystem being found at all in sddm-kcm? Sorry for the late reply, I was very busy over the last moths. I jus

Re: VDG approved widgets

Good stuff sebras. I would also thinking about how should be the quality standards are defined? VDG usability and design PLasma additional code review, signing, ... User feedback something like at least an post on the planet or something like that. And what the dev get from plasma? An quality sig

Review Request 127337: [libksysguard] Don't call into QX11Info::connection() on wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127337/ --- Review request for Plasma and Martin Gräßlin. Repository: libksysguard

[Differential] [Commented On] D1113: New Desktop Theme KCM

drosca added a comment. F94789: kcm_desktoptheme.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1113 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: pl

[Differential] [Request, 819 lines] D1113: New Desktop Theme KCM

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY New Desktop Theme KCM It is in new directory (desktoptheme-qml) for easier review. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH desk

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 13 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Mar 2016 17:54:28 + Build duration: 1 min 36 sec CHANGE SET Revision fce16a6e4c2848ac681

[Differential] [Closed] D947: Fix path of kcheckpass when pass to chown

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENLOCKERfcfeae0cf4d6: Fix path of kcheckpass when passing it to chown (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D947?vs=2307&id=2676#toc REPOSITORY rKSCREENLOCKER K

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 17 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Mar 2016 12:47:23 + Build duration: 50 sec CHANGE SET Revision 8244b2675e5461583aa1972c6c3

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 12 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Mar 2016 11:55:27 + Build duration: 1 min 36 sec CHANGE SET Revision 740106b4885d9ec31ce

[Differential] [Abandoned] D1107: Opening activity configuration as a modal dialog when calling from kcm

ivan abandoned this revision. ivan added a comment. Not needed after the https://git.reviewboard.kde.org/r/127333/ REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1107 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Review Request 127333: KCMshell window has no reason to be modal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127333/ --- (Updated March 10, 2016, 5:51 p.m.) Status -- This change has been m

Re: Review Request 127333: KCMshell window has no reason to be modal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127333/#review93393 --- Ship it! Ship It! - Marco Martin On March 10, 2016, 5:2

Review Request 127333: KCMshell window has no reason to be modal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127333/ --- Review request for Plasma, David Edmundson and David Faure. Repository: k

Re: kdereview: breeze-grub & breeze-plymouth

On Fri, Feb 19, 2016 at 09:43:27AM +0100, Harald Sitter wrote: > GRUB is ready for review. error: unknown property 'terminal-color' https://www.flickr.com/photos/jriddell/25584072671/in/photostream/ probably it's being snobbish and it should be 'terminal-colour' :) Jonathan

Re: kdereview: breeze-grub & breeze-plymouth

On Thu, Mar 10, 2016 at 05:10:40PM +, Jonathan Riddell wrote: > On Thu, Mar 10, 2016 at 09:28:35AM +0100, Harald Sitter wrote: > > On Wed, Mar 9, 2016 at 6:19 PM, Sebastian Kügler wrote: > > > On Wednesday, March 09, 2016 17:07:21 Jonathan Riddell wrote: > > >> This does not build when using >

Re: kdereview: breeze-grub & breeze-plymouth

On Thu, Mar 10, 2016 at 09:28:35AM +0100, Harald Sitter wrote: > On Wed, Mar 9, 2016 at 6:19 PM, Sebastian Kügler wrote: > > On Wednesday, March 09, 2016 17:07:21 Jonathan Riddell wrote: > >> This does not build when using > >> -Wl,--no-undefined > >> > >> breeze-text/plugin.c:601: undefined refer

Re: Review Request 127332: [Pager] List minimized windows in the tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127332/ --- (Updated März 10, 2016, 5:09 nachm.) Review request for Plasma and KDE Us

Review Request 127332: [Pager] List minimized windows in the tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127332/ --- Review request for Plasma and KDE Usability. Bugs: 357545 https://bug

[Differential] [Request, 38 lines] D1107: Opening activity configuration as a modal dialog when calling from kcm

ivan created this revision. ivan added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY We turned of the modal-ness of the activity configuration dialogue so that we do not block plasma (https://git.reviewboard.kde.org/r/1269

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

> On March 10, 2016, 3 p.m., Marco Martin wrote: > > Ship It! Heh, hold your horses (my horses?). Still uses Qt 5.6 and doesn't have the changes we discussed. - Aleix --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 127315: Icon applet: Set sensible minimum height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127315/ --- (Updated March 10, 2016, 3:21 p.m.) Review request for Plasma. Changes

[plasmashell] [Bug 360309] [Window List applet] add text field to widget for the panel

https://bugs.kde.org/show_bug.cgi?id=360309 Martin Klapetek changed: What|Removed |Added Component|general |Window List CC|

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review93388 --- Ship it! Ship It! - Marco Martin On March 10, 2016, 10:

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated March 10, 2016, 1:02 p.m.) Status -- This change has been m

Re: Review Request 127313: [Icon Item] Don't call loadPixmap in setColorGroup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127313/ --- (Updated March 10, 2016, 11:58 a.m.) Status -- This change has been

[Differential] [Closed] D1103: [Folder View] Add "Icon Size" to "Icons" context menu

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3bf5a5a1c592: [Folder View] Add "Icon Size" to "Icons" context menu (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1103?vs=2659&id=2661#toc REPOSITORY rPLASMA

[Differential] [Closed] D1090: [krunner] Make it work on Wayland

graesslin closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: plasma-devel, Plasma __

[Differential] [Closed] D1088: [krunner] Don't call KWindowSystem::setState on every event

graesslin closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1088 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, broulik Cc: broulik, plasma-devel, Plasma __

Re: Review Request 127329: Shut down warnings about deprecated KF5Plasma API being used

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127329/ --- (Updated March 10, 2016, 11:19 a.m.) Status -- This change has been

Re: Review Request 127329: Shut down warnings about deprecated KF5Plasma API being used

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127329/#review93385 --- Ship it! Ship It! - Sebastian Kügler On March 10, 2016,

Re: Review Request 127329: Shut down warnings about deprecated KF5Plasma API being used

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127329/#review93384 --- Ship it! yep, i agree, unfortunately i can't remove the us

Review Request 127329: Shut down warnings about deprecated KF5Plasma API being used

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127329/ --- Review request for Plasma. Repository: plasma-workspace Description ---

[Differential] [Accepted] D1103: [Folder View] Add "Icon Size" to "Icons" context menu

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. This looks fine, but I'm not sure we want to expose awkward icon size names like "Small Medium" to users. But that's a broader point that has to be addressed separately. REPOSITORY rPLASMADE

[Differential] [Request, 45 lines] D1103: [Folder View] Add "Icon Size" to "Icons" context menu

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY As requested by VDG BUG: 360351 FIXED-IN: 5.7.0

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- (Updated March 10, 2016, 11:48 a.m.) Review request for Plasma. Changes

Re: Review Request 127325: Replace all keywords by Qt macros

> On Bře. 10, 2016, 9:29 dop., Kåre Särs wrote: > > daemon/powerdevilactionpool.cpp, line 130 > > > > > > Is this a mistakenly included addition? Yes, sorry, you can ignore this one. - Jan --

Re: Review Request 127325: Replace all keywords by Qt macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127325/#review93381 --- daemon/powerdevilactionpool.cpp (line 130)

Re: two exceptions for string freeze in Plasma

On Thursday, March 10, 2016 02:37:11 Alexander Potashev wrote: > 2016-03-09 19:24 GMT+03:00 Sebastian Kügler : > > Indeed. My change was not trying to get a generalized policy implemented, > > but to fix the wrong use of the KDE brand. We do have people telling us > > that they'll happily use KDE t

Re: [kde-doc-english] [kinfocenter] /: Remove all remaining bits of SCSI module

CC:ing plasma-devel. On Thursday, March 10, 2016 02:41:16 Alexander Potashev wrote: > Next time please clarify in the commit message why you remove > something (reasoning, links to discussions, etc?), SCSI support in > this case. SCSI isn't used in today's systems, it's very unlikely to find a sy

Review Request 127325: Replace all keywords by Qt macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127325/ --- Review request for Plasma, Solid and Kai Uwe Broulik. Repository: powerde

Re: kdereview: breeze-grub & breeze-plymouth

On Wed, Mar 9, 2016 at 6:19 PM, Sebastian Kügler wrote: > On Wednesday, March 09, 2016 17:07:21 Jonathan Riddell wrote: >> This does not build when using >> -Wl,--no-undefined >> >> breeze-text/plugin.c:601: undefined reference to `pow' >> breeze-text/plugin.c:601: undefined reference to `pow' > >