reviewing qemplayer (was Re: Please review my package)

2012-07-09 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2012-07-05 11:52, IOhannes m zmoelnig wrote: > no real review (and i'm no DD, so i cannot upload anyhow) but a > few remarks (without even attempting to build the package): is there any specific reason, why you install files into /usr/share/doc/qem

review qemplayer (was Re: Please review my package)

2012-07-09 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 hi. is it possible for you to "reply" to messages, so threads are kept intact? also it would be nice if you could use a more meaningful subject ("my" package refer to a number of packages, non of which is qemplayer) On 2012-07-05 22:14, wbrana wrote

Please review my package

2012-07-05 Thread wbrana
> That doesn't change that it is a security hazard! > Don't run user apps as root! > Don't implement super-user features in user apps - implement it > separately, and make it optional to use it. I don't run user apps as root. MPlayer is never started as root. Here is mplayer_nice source code with

Re: Please review my package

2012-07-05 Thread Jonas Smedegaard
On 12-07-05 at 08:36pm, wbrana wrote: > > - - why are you setting setuid permissions in the postinst script? > > this is a security hazard (and if you do it to gain realtime > > priviliges, then it is no-longer needed and deprecated for a while, in > > favour of pam_limits) > According to http://li

Please review my package

2012-07-05 Thread wbrana
> - - why are you setting setuid permissions in the postinst script? > this is a security hazard (and if you do it to gain realtime > priviliges, then it is no-longer needed and deprecated for a while, in > favour of pam_limits) According to http://linux.die.net/man/5/limits.conf it is possible to

Re: Please review my package

2012-07-05 Thread Jonas Smedegaard
On 12-07-05 at 03:49pm, wbrana wrote: > I added following compiler flags, but it didn't help. Do you know how > to fix it? > > cxxflags+='-fstack-protector --param=ssp-buffer-size=4 > -Wformat -Werror=format-security' > ldflags+='-Wl,-z,relro' > cppflags+='-D_FORTIFY_SOURC

Please review my package

2012-07-05 Thread wbrana
I fixed most things and updated mentor's repository. Please check. > - - the version is "12.5-1.1", indicating a non-maintainer upload (which > you also state in the changelog). > even though you are not an official "Debian Maintainer", you (or d-m-m > as a team) is "the maintainer" of the package

Re: Please review my package

2012-07-05 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2012-07-05 11:52, IOhannes m zmoelnig wrote: > On 2012-07-05 10:47, wbrana wrote: > > - you have "Debian Multimedia Maintainers" set as the maintainer. > p-m-m has a few rules, on how packaging is done. > > e.g., all the pacakging in a git reposi

Re: Please review my package

2012-07-05 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2012-07-05 10:47, wbrana wrote: > Hello, I have created package for qemplayer great that you want to contribute. > http://mentors.debian.net/package/qemplayer no real review (and i'm no DD, so i cannot upload anyhow) but a few remarks (without e

Re: Please review my package

2012-07-05 Thread wbrana
On Thu, Jul 5, 2012 at 11:23 AM, IOhannes m zmoelnig wrote: > maybe i missed that bit, but i think it would be polite if you > introduced yourself and expressed your willingness to work with p-m-m > as a team, before throwing a dry review-request on us, without even > caring to explain what that p

Re: Please review my package

2012-07-05 Thread Matteo F. Vescovi
On Thu, Jul 05, 2012 at 11:23:44AM +0200, IOhannes m zmoelnig wrote: > maybe i missed that bit, but i think it would be polite if you > introduced yourself and expressed your willingness to work with p-m-m > as a team, before throwing a dry review-request on us, without even > caring to explain wha

Re: Please review my package

2012-07-05 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2012-07-05 10:47, wbrana wrote: > Hello, I have created package for qemplayer maybe i missed that bit, but i think it would be polite if you introduced yourself and expressed your willingness to work with p-m-m as a team, before throwing a dry revi

Please review my package

2012-07-05 Thread wbrana
Hello, I have created package for qemplayer http://mentors.debian.net/package/qemplayer ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-