Re: [Piglit] [PATCH] EXT_shader_image_load_store: skip atomics for not-1x32 types

2019-08-07 Thread Pelloux-prayer, Pierre-eric
Reviewed-by: Pierre-Eric Pelloux-Prayer On 07/08/2019 02:33, Ilia Mirkin wrote: > From the spec: > > The format of the image unit must be in the "1x32" equivalence class > in Table X.2 in Section 3.9.X of the OpenGL specification, otherwise > the atomic operation is invalid. > > So

Re: [Piglit] [PATCH] EXT_shader_image_load_store: atomics should be done on single-component images

2019-08-07 Thread Pelloux-prayer, Pierre-eric
Reviewed-by: Pierre-Eric Pelloux-Prayer On 07/08/2019 04:42, Ilia Mirkin wrote: > The shader has size1x32, but the images are 4-component. In such a case, > the results are undefined. Make it a single component. > > Signed-off-by: Ilia Mirkin > --- > .../image_functions.c