[Piglit] [PATCH] Add test for external sampler with 2D tex

2019-02-02 Thread Aditya Swarup
Commit 649c149dbb96ac367 removed the test for intel external sampler with dma only because of failure due to commit a5c39ed974402c - ("i965: Lift restriction in external textures for EGLImage support"). Since, there is no test coverage for external sampler with 2D tex, adding the test with modifica

[Piglit] [PATCH] shader_runner: skip GLSL version check when running SPIR-V shaders

2019-02-02 Thread Alejandro PiƱeiro
Because after all, you are not running GLSL shaders in that case. SPIR-V requirements are OpenGL version >= 3.30 and having ARB_gl_spirv available. About why this is needed: most SPIR-V tests include the GLSL used to generate the SPIR-V, so the SPIR-V could be regenerated easily if we test needs a

Re: [Piglit] [PATCH 09/10] arb_enhanced_layouts: add another xfb_stride overflow test

2019-02-02 Thread Andres Gomez
On Sat, 2019-02-02 at 10:15 +1100, Timothy Arceri wrote: > On 2/2/19 4:55 am, Andres Gomez wrote: > > Additional check to address a bug in mesa in which a stride which > > is a divisor of the declared offset for an overflowing varying > > won't fail. > > > > From the GL_ARB_enhanced_layouts spec:

Re: [Piglit] [PATCH 09/10] arb_enhanced_layouts: add another xfb_stride overflow test

2019-02-02 Thread Timothy Arceri
On 3/2/19 7:30 am, Andres Gomez wrote: On Sat, 2019-02-02 at 10:15 +1100, Timothy Arceri wrote: On 2/2/19 4:55 am, Andres Gomez wrote: Additional check to address a bug in mesa in which a stride which is a divisor of the declared offset for an overflowing varying won't fail. From the GL_ARB_

Re: [Piglit] [PATCH] Add test for external sampler with 2D tex

2019-02-02 Thread Mark Janes
FWIW, the skqp test is run constantly in mesa ci: https://mesa-ci.01.org/mesa_master/builds/15138/results/174306816 Aditya Swarup writes: > Commit 649c149dbb96ac367 removed the test for intel external sampler > with dma only because of failure due to commit a5c39ed974402c - > ("i965: Lift rest